* [Bug 214921] amdgpu hangs HP Laptop on shutdown
2021-11-03 2:46 [Bug 214921] New: amdgpu hangs HP Laptop on shutdown bugzilla-daemon
@ 2021-11-04 8:15 ` bugzilla-daemon
2021-11-05 16:21 ` bugzilla-daemon
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2021-11-04 8:15 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=214921
spasswolf@web.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Regression|No |Yes
--- Comment #1 from spasswolf@web.de ---
It turns out that ressuming from suspend has been broken a long time on the
above hardware. The last Kernel where it works is 5.12.
The first commit where resuming from suspend leads to screen corruption is
4588f7b7dd5f09e70b6e223490a0d054c3d64071
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 214921] amdgpu hangs HP Laptop on shutdown
2021-11-03 2:46 [Bug 214921] New: amdgpu hangs HP Laptop on shutdown bugzilla-daemon
2021-11-04 8:15 ` [Bug 214921] " bugzilla-daemon
@ 2021-11-05 16:21 ` bugzilla-daemon
2021-11-07 13:21 ` bugzilla-daemon
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2021-11-05 16:21 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=214921
Paul Gover (pmw.gover@yahoo.co.uk) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pmw.gover@yahoo.co.uk
--- Comment #2 from Paul Gover (pmw.gover@yahoo.co.uk) ---
Spasswolf's comment doesn't seem in any way related to this bug report. I
presume it was filed against the wrong bug!
I can confirm on my setup, HP laptop with an AMD "Stoney" chipset, on kernel
5.15.0 the system doesn't shutdown when you use KDE power menu "shutdown", nor
if you issue the "halt" or "poweroff" commands, nor "shutdown -P now".
The keyboard is dead, so Ctl-Alt-Del doesn't reboot, all that's left is holding
the power button down.
Behaviour was correct on kernel 5.14 (at least, up to 5.14.14).
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 214921] amdgpu hangs HP Laptop on shutdown
2021-11-03 2:46 [Bug 214921] New: amdgpu hangs HP Laptop on shutdown bugzilla-daemon
2021-11-04 8:15 ` [Bug 214921] " bugzilla-daemon
2021-11-05 16:21 ` bugzilla-daemon
@ 2021-11-07 13:21 ` bugzilla-daemon
2021-11-14 20:31 ` bugzilla-daemon
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2021-11-07 13:21 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=214921
spasswolf@web.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Kernel Version|5.15 |5.15, 5.15.1
--- Comment #3 from spasswolf@web.de ---
Shutdown still hangs with linux-5.15.1.
This fixes the shutdown issue for me:
diff -aur linux-5.15.1.orig/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
linux-5.15.1/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
--- linux-5.15.1.orig/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c 2021-11-06
14:13:31.000000000 +0100
+++ linux-5.15.1/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c 2021-11-07
14:19:39.194630084 +0100
@@ -554,18 +554,6 @@
* jobs for clockgating/powergating/dpm setting to
* ->set_powergating_state().
*/
- cancel_delayed_work_sync(&adev->uvd.idle_work);
-
- if (adev->pm.dpm_enabled) {
- amdgpu_dpm_enable_uvd(adev, false);
- } else {
- amdgpu_asic_set_uvd_clocks(adev, 0, 0);
- /* shutdown the UVD block */
- amdgpu_device_ip_set_powergating_state(adev,
AMD_IP_BLOCK_TYPE_UVD,
- AMD_PG_STATE_GATE);
- amdgpu_device_ip_set_clockgating_state(adev,
AMD_IP_BLOCK_TYPE_UVD,
- AMD_CG_STATE_GATE);
- }
if (RREG32(mmUVD_STATUS) != 0)
uvd_v6_0_stop(adev);
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 214921] amdgpu hangs HP Laptop on shutdown
2021-11-03 2:46 [Bug 214921] New: amdgpu hangs HP Laptop on shutdown bugzilla-daemon
` (2 preceding siblings ...)
2021-11-07 13:21 ` bugzilla-daemon
@ 2021-11-14 20:31 ` bugzilla-daemon
2021-11-15 16:56 ` bugzilla-daemon
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2021-11-14 20:31 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=214921
spasswolf@web.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Kernel Version|5.15, 5.15.1 |5.15, 5.15.1,
| |5.15.0-next-20211112
--- Comment #4 from spasswolf@web.de ---
This still bug is still present in the 5.15.0-next-20211112 where it breaks
suspend:
static int uvd_v6_0_suspend(void *handle)
{
int r;
struct amdgpu_device *adev = (struct amdgpu_device *)handle;
/*
* Proper cleanups before halting the HW engine:
* - cancel the delayed idle work
* - enable powergating
* - enable clockgating
* - disable dpm
*
* TODO: to align with the VCN implementation, move the
* jobs for clockgating/powergating/dpm setting to
* ->set_powergating_state().
*/
#if 0
cancel_delayed_work_sync(&adev->uvd.idle_work);
if (adev->pm.dpm_enabled) {
amdgpu_dpm_enable_uvd(adev, false);
} else {
amdgpu_asic_set_uvd_clocks(adev, 0, 0);
/* shutdown the UVD block */
amdgpu_device_ip_set_powergating_state(adev,
AMD_IP_BLOCK_TYPE_UVD,
AMD_PG_STATE_GATE);
amdgpu_device_ip_set_clockgating_state(adev,
AMD_IP_BLOCK_TYPE_UVD,
AMD_CG_STATE_GATE);
}
#endif
r = uvd_v6_0_hw_fini(adev);
if (r)
return r;
return amdgpu_uvd_suspend(adev);
}
This makes suspend work again.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 214921] amdgpu hangs HP Laptop on shutdown
2021-11-03 2:46 [Bug 214921] New: amdgpu hangs HP Laptop on shutdown bugzilla-daemon
` (3 preceding siblings ...)
2021-11-14 20:31 ` bugzilla-daemon
@ 2021-11-15 16:56 ` bugzilla-daemon
2021-11-15 23:19 ` bugzilla-daemon
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2021-11-15 16:56 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=214921
Alex Deucher (alexdeucher@gmail.com) changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alexdeucher@gmail.com
--- Comment #5 from Alex Deucher (alexdeucher@gmail.com) ---
Should be fixed with this patch:
https://patchwork.freedesktop.org/series/96646/
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 214921] amdgpu hangs HP Laptop on shutdown
2021-11-03 2:46 [Bug 214921] New: amdgpu hangs HP Laptop on shutdown bugzilla-daemon
` (4 preceding siblings ...)
2021-11-15 16:56 ` bugzilla-daemon
@ 2021-11-15 23:19 ` bugzilla-daemon
2021-11-17 16:38 ` bugzilla-daemon
2021-11-28 19:16 ` bugzilla-daemon
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2021-11-15 23:19 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=214921
--- Comment #6 from spasswolf@web.de ---
Tested the patch with linux-5.15.2, linux-next-20211115 and linux-5.16-rc1. It
solves the hang on suspend (or shutdown) problem in all cases but resuming from
suspend is still broken on linux-5.15.2 when the IOMMU is missing:
https://bugzilla.kernel.org/show_bug.cgi?id=214963
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 214921] amdgpu hangs HP Laptop on shutdown
2021-11-03 2:46 [Bug 214921] New: amdgpu hangs HP Laptop on shutdown bugzilla-daemon
` (5 preceding siblings ...)
2021-11-15 23:19 ` bugzilla-daemon
@ 2021-11-17 16:38 ` bugzilla-daemon
2021-11-28 19:16 ` bugzilla-daemon
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2021-11-17 16:38 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=214921
spasswolf@web.de changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |PATCH_ALREADY_AVAILABLE
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug 214921] amdgpu hangs HP Laptop on shutdown
2021-11-03 2:46 [Bug 214921] New: amdgpu hangs HP Laptop on shutdown bugzilla-daemon
` (6 preceding siblings ...)
2021-11-17 16:38 ` bugzilla-daemon
@ 2021-11-28 19:16 ` bugzilla-daemon
7 siblings, 0 replies; 9+ messages in thread
From: bugzilla-daemon @ 2021-11-28 19:16 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=214921
--- Comment #7 from Paul Gover (pmw.gover@yahoo.co.uk) ---
Kernel 5.15.5 (which IIUC contains the patch or equivalent) works for me.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread