* [Bug 23382] New: Nouveau DRM module out-of-tree compile errors
@ 2009-08-17 23:07 bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
[not found] ` <bug-23382-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
0 siblings, 1 reply; 4+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2009-08-17 23:07 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
http://bugs.freedesktop.org/show_bug.cgi?id=23382
Summary: Nouveau DRM module out-of-tree compile errors
Product: xorg
Version: git
Platform: All
OS/Version: Linux (All)
Status: NEW
Severity: blocker
Priority: high
Component: Driver/nouveau
AssignedTo: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
ReportedBy: tavianator-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
QAContact: xorg-team-go0+a7rfsptAfugRpC6u6w@public.gmane.org
Created an attachment (id=28717)
--> (http://bugs.freedesktop.org/attachment.cgi?id=28717)
Patch to fix drm_encoder_slave.h includes.
When doing an out-of-tree compile on the nouveau kernel module, recent GIT
versions fail to compile without patching for a couple reasons. The first can
be fixed with the attached patch.
The second has to do with the fact that drivers/gpu/drm/nouveau/nouveau_drv.h
declares the prototype for nouveau_encoder_connector_get, which relies on the
type `struct nouveau_encoder*', defined in
drivers/gpu/drm/nouveau/nouveau_encoder.h. However, nouveau_encoder.h needs
nouveau_drv.h for the type `struct nv04_output_reg'. This circular dependency
causes compilation of nouveau_drv.c to fail.
Also, any reason the include guard for nouveau_encoder.h is called
__NOUVEAU_OUTPUT_H__?
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug 23382] Nouveau DRM module out-of-tree compile errors
[not found] ` <bug-23382-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
@ 2009-08-18 7:36 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2009-08-18 8:52 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2009-08-21 5:30 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2 siblings, 0 replies; 4+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2009-08-18 7:36 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
http://bugs.freedesktop.org/show_bug.cgi?id=23382
--- Comment #1 from Pekka Paalanen <pq-X3B1VOXEql0@public.gmane.org> 2009-08-18 00:36:02 PST ---
(In reply to comment #0)
> Created an attachment (id=28717)
--> (http://bugs.freedesktop.org/attachment.cgi?id=28717) [details]
> Patch to fix drm_encoder_slave.h includes.
The equivalent patch is already present in the master-compat branch
(commit 1b527aded95176a2bc4b19f0191f9e6d412ad413), and has been sent to DRM
upstream. It will come to master branch in time, in the mean time you can
use master-compat.
> When doing an out-of-tree compile on the nouveau kernel module, recent GIT
> versions fail to compile without patching for a couple reasons. The first can
> be fixed with the attached patch.
master-compat has always worked for me (since I try to remember to check and
fix it before pushing).
> The second has to do with the fact that drivers/gpu/drm/nouveau/nouveau_drv.h
> declares the prototype for nouveau_encoder_connector_get, which relies on the
> type `struct nouveau_encoder*', defined in
> drivers/gpu/drm/nouveau/nouveau_encoder.h. However, nouveau_encoder.h needs
> nouveau_drv.h for the type `struct nv04_output_reg'. This circular dependency
> causes compilation of nouveau_drv.c to fail.
I've never seen this problem. In what I see, the prototype for
nouveau_encoder_connector_get() is in nouveau_encoder.h. Okay, it has already
been fixed in commit 8745851d364bc175d06d4de3cfa47cd65c399a04.
> Also, any reason the include guard for nouveau_encoder.h is called
> __NOUVEAU_OUTPUT_H__?
Indeed, I'll fix that.
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug 23382] Nouveau DRM module out-of-tree compile errors
[not found] ` <bug-23382-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
2009-08-18 7:36 ` [Bug 23382] " bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
@ 2009-08-18 8:52 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2009-08-21 5:30 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2 siblings, 0 replies; 4+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2009-08-18 8:52 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
http://bugs.freedesktop.org/show_bug.cgi?id=23382
Pekka Paalanen <pq-X3B1VOXEql0@public.gmane.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #2 from Pekka Paalanen <pq-X3B1VOXEql0@public.gmane.org> 2009-08-18 01:52:52 PST ---
The include guard fix is in master, commit
2b4837bb34c053f3c81c8a28b52a0f679a71acac.
Let's keep this bug open until the drm_encoder_slave.h fix arrives to master.
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug 23382] Nouveau DRM module out-of-tree compile errors
[not found] ` <bug-23382-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
2009-08-18 7:36 ` [Bug 23382] " bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2009-08-18 8:52 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
@ 2009-08-21 5:30 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2 siblings, 0 replies; 4+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2009-08-21 5:30 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
http://bugs.freedesktop.org/show_bug.cgi?id=23382
Pekka Paalanen <pq-X3B1VOXEql0@public.gmane.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #3 from Pekka Paalanen <pq-X3B1VOXEql0@public.gmane.org> 2009-08-20 22:30:57 PST ---
All fixed in master.
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-08-21 5:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-17 23:07 [Bug 23382] New: Nouveau DRM module out-of-tree compile errors bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
[not found] ` <bug-23382-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
2009-08-18 7:36 ` [Bug 23382] " bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2009-08-18 8:52 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
2009-08-21 5:30 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.