[Bug 32855] New: Incorrect image stretching with Render in RepeatPad mode, NV50

[Bug 32855] New: Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

           Summary: Incorrect image stretching with Render in RepeatPad
                    mode, NV50
           Product: xorg
           Version: git
          Platform: x86-64 (AMD64)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
        ReportedBy: zackw-VmQCmMdMyN0AvxtiuMwx3w@public.gmane.org
         QAContact: xorg-team-go0+a7rfsptAfugRpC6u6w@public.gmane.org


Created an attachment (id=41683)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=41683)
test program

Attached is a test program which attempts to stretch a two-pixel image
horizontally using Cairo.  It generates four files: r-image-24.png should be
pixel-identical to r-xlib-24.png and r-image-32.png should be pixel-identical
to r-xlib-32.png.

On my system (I don't remember the exact marketing name of the card, but the
driver identifies it as "NVIDIA NV94" and as "a NV50 generation card"), even
with the very latest version of the Nouveau driver (xf86-video-nouveau git
dc89dac734167bcbc667b39ca6ee2043871a60bf), the -xlib- files are not identical
to their respective -image- files.  (I will also attach the test results as
produced by my system.)

With the 24bpp image, the problem appears to be simply that Cairo's EXTEND_PAD
(Render's RepeatPad) is not doing its job, despite that I do see code in the
driver to implement that mode.  The upscale is happening as if there were black
pixels around the edges of the single-pixel source image, instead of green and
white pixels as EXTEND_PAD specifies.

With the 32bpp image, in addition to that problem, there are also garbage
pixels at intervals.

I am happy to provide more information as necessary and/or to test patches.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 32855] Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

--- Comment #1 from Zack Weinberg <zackw-VmQCmMdMyN0AvxtiuMwx3w@public.gmane.org> 2011-01-05 11:55:32 PST ---
Created an attachment (id=41684)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=41684)
test output: r-image-24

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 32855] Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

--- Comment #2 from Zack Weinberg <zackw-VmQCmMdMyN0AvxtiuMwx3w@public.gmane.org> 2011-01-05 11:55:48 PST ---
Created an attachment (id=41685)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=41685)
test output: r-image-32

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 32855] Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

--- Comment #3 from Zack Weinberg <zackw-VmQCmMdMyN0AvxtiuMwx3w@public.gmane.org> 2011-01-05 11:56:06 PST ---
Created an attachment (id=41686)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=41686)
test output: r-xlib-24

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 32855] Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

--- Comment #4 from Zack Weinberg <zackw-VmQCmMdMyN0AvxtiuMwx3w@public.gmane.org> 2011-01-05 11:56:23 PST ---
Created an attachment (id=41687)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=41687)
test output: r-xlib-32

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 32855] Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

--- Comment #5 from Zack Weinberg <zackw-VmQCmMdMyN0AvxtiuMwx3w@public.gmane.org> 2011-01-05 11:56:39 PST ---
Created an attachment (id=41688)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=41688)
Xorg.log

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 32855] Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

--- Comment #6 from Zack Weinberg <zackw-VmQCmMdMyN0AvxtiuMwx3w@public.gmane.org> 2011-01-05 11:57:00 PST ---
Created an attachment (id=41689)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=41689)
dmesg

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 32855] Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

--- Comment #7 from Zack Weinberg <zackw-VmQCmMdMyN0AvxtiuMwx3w@public.gmane.org> 2011-01-05 12:00:00 PST ---
Forgot to mention: for the test program to actually test the behavior of the
driver, I believe it is necessary to use libcairo 1.7.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 32855] Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1289 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #8 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
It appears that this bug report has laid dormant for quite a while. Sorry we
haven't gotten to it. Since we fix bugs all the time, chances are pretty good
that your issue has been fixed with the latest software. Please give it a shot.
(Linux kernel 3.10.7, xf86-video-nouveau 1.0.9, mesa 9.1.6, or their git
versions.) If upgrading to the latest isn't an option for you, your distro's
bugzilla is probably the right destination for your bug report.

In an effort to clean up our bug list, we're pre-emptively closing all bugs
that haven't seen updates since 2011. If the original issue remains, please
make sure to provide fresh info, see http://nouveau.freedesktop.org/wiki/Bugs/
for what we need to see, and re-open this one.

Thanks,

The Nouveau Team

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2797 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 32855] Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1260 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

Zack Weinberg <zackw-VmQCmMdMyN0AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |WORKSFORME

--- Comment #9 from Zack Weinberg <zackw-VmQCmMdMyN0AvxtiuMwx3w@public.gmane.org> ---
It is user-hostile and unprofessional to mass-close bugs, even very old bugs,
without making any attempt to reproduce the problem first. 
http://www.jwz.org/doc/cadt.html

I'm willing to cut a *little* slack on this bug because it may have appeared to
require specific hardware to reproduce; however, I went to the trouble of
writing a self-contained test program and giving precise instructions for
reproduction, so I expect you to at least *try* to find the appropriate
hardware, and if you couldn't, to say so, instead of just "shrug, this might
have been fixed."  I would have been happy to test development drivers, even,
if I had ever been asked.

That said, with the latest software present in Debian unstable, the bug appears
to have been fixed, so I will leave it closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2668 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 32855] Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1271 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

--- Comment #10 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
(In reply to comment #9)
> It is user-hostile and unprofessional to mass-close bugs, even very old
> bugs, without making any attempt to reproduce the problem first. 
> http://www.jwz.org/doc/cadt.html

I wasn't a big fan of it either (despite proposing it and doing it). But look
at it from the project's standpoint -- volunteer based (and not exactly a big
team), high code churn rate (esp 1-2 years ago), high hardware
death(/replacement) rate, large variety of hardware, 400+ bugs deep, of which
200 are from more than 2 years without an update. So I didn't see a better way
of getting a handle on the situation. Of the 200+ bugs I closed, about 10 have
gotten follow-up comments of any sort (either that it's been fixed/hardware
gone/still a problem). I'm individually pinging newer bugs, and I'm not having
a great response rate either (but better).

Besides, you always have the option of re-opening the same bug and providing
updated information. As a bug filer, I think it's reasonable to expect you to
be the main tester (at least with nouveau).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2221 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 32855] Incorrect image stretching with Render in RepeatPad mode, NV50

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 898 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=32855

Martin Peres <martin.peres-Iz16wY1oaNPLSKGbIzaifA@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WORKSFORME                  |FIXED

--- Comment #11 from Martin Peres <martin.peres-Iz16wY1oaNPLSKGbIzaifA@public.gmane.org> ---
We must admit that for a bug reporter, he was top-notch!

Too bad no-one took a look and then the bug got lost in our bugzilla, among
400+ other bugs. Although, the team must have concentrated on getting some
features to work before addressing bugs. It is a very rationale approach in a
reverse-engineering development environment.

So, my sincere apologies, we are trying to make more case of bug reports now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2274 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau