[Bug 38440] New: ETQW: Model in team select rendering too bright

[Bug 38440] New: ETQW: Model in team select rendering too bright

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38440

           Summary: ETQW: Model in team select rendering too bright
           Product: Mesa
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r600
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: sa@whiz.se


Created an attachment (id=48132)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=48132)
screenshot of bug

As previously mentioned in bug 36917, the game ETQW have a small rendering
error in the team select menu. The model is rendered too bright when the
setting "Lightning quality" is set to normal. There's no problem when the
setting is changed to high.

This doesn't seem to be a regression as it is present as far back as when S3TC
support was first added.

System environment:
-- system architecture: 32-bit
-- Linux distribution: Debian unstable
-- GPU: REDWOOD
-- Model: XFX Radeon HD 5670 1GB
-- Display connector: DVI
-- xf86-video-ati: 6.14.2
-- xserver: 1.10.2
-- mesa: 2fe39b46e73aea37152777fe11d489e0b1bc3f92
-- drm: 2.4.25
-- kernel: 2.6.39.1

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38440] ETQW: Model in team select rendering too bright

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38440

--- Comment #1 from Andy Furniss <lists@andyfurniss.entadsl.com> 2011-06-21 03:26:36 PDT ---
(In reply to comment #0)
> Created an attachment (id=48132)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=48132)
> screenshot of bug
> 
> As previously mentioned in bug 36917, the game ETQW have a small rendering
> error in the team select menu. The model is rendered too bright when the
> setting "Lightning quality" is set to normal. There's no problem when the
> setting is changed to high.
> 
> This doesn't seem to be a regression as it is present as far back as when S3TC
> support was first added.

In addition to this one I have found another rendering error that only appears
with lighting normal on my 4890.

On maps with sea - Island and Volacano, where the sky meets the sea there is a
band of black/junk. It's thin from ground level, so best seen from high up.

Doesn't seem to be a regression, though I only went back to April.

My other settings are those you get with the high master setting + shadows on.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38440] ETQW: Model in team select rendering too bright

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38440

--- Comment #2 from Vadim <ptpzz@yandex.ru> 2011-06-21 06:08:33 PDT ---
Created an attachment (id=48227)
 View: https://bugs.freedesktop.org/attachment.cgi?id=48227
 Review: https://bugs.freedesktop.org/review?bug=38440&attachment=48227

[PATCH] r600g: fragment/vertex color clamping

This patch should fix model brightness.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38440] ETQW: Model in team select rendering too bright

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38440

--- Comment #3 from Sven Arvidsson <sa@whiz.se> 2011-06-21 06:49:32 PDT ---
(In reply to comment #2)
> 
> This patch should fix model brightness.

Indeed it does. Wow, you have really been rocking with all the fixes for r600g,
thanks! :)



Andy, if the sky/sea issue isn't solved with this, can you post a screenshot?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38440] ETQW: Model in team select rendering too bright

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38440

--- Comment #4 from Andy Furniss <lists@andyfurniss.entadsl.com> 2011-06-21 07:20:19 PDT ---
(In reply to comment #2)
> Created an attachment (id=48227)
 View: https://bugs.freedesktop.org/attachment.cgi?id=48227
 Review: https://bugs.freedesktop.org/review?bug=38440&attachment=48227

> [PATCH] r600g: fragment/vertex color clamping
> 
> This patch should fix model brightness.

It fixes both my issues with normal lighting on rv790 - thanks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38440] ETQW: Model in team select rendering too bright

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38440

--- Comment #5 from Sven Arvidsson <sa@whiz.se> 2011-06-23 13:38:31 PDT ---
I'm not sure what the procedure for this is, but it would be great if this
patch would be merged in time for 7.11.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38440] ETQW: Model in team select rendering too bright

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38440

--- Comment #6 from Sven Arvidsson <sa@whiz.se> 2011-06-24 12:00:28 PDT ---
*** Bug 37203 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38440] ETQW: Model in team select rendering too bright

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38440

Sven Arvidsson <sa@whiz.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Sven Arvidsson <sa@whiz.se> 2011-06-24 13:18:37 PDT ---
commit eafd331cf3b024001abd3f64861f41cd33a9acb2
Author: Vadim Girlin <vadimgirlin@gmail.com>
Date:   Fri Jun 24 20:29:13 2011 +0400

    r600g: implement fragment and vertex color clamp

    Fixes https://bugs.freedesktop.org/show_bug.cgi?id=38440

    Signed-off-by: Vadim Girlin <vadimgirlin@gmail.com>

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.