[Bug 38917] New: [patch] Radeon clocks should not be limited to defaults

[Bug 38917] New: [patch] Radeon clocks should not be limited to defaults

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38917

           Summary: [patch] Radeon clocks should not be limited to
                    defaults
           Product: DRI
           Version: unspecified
          Platform: Other
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/Radeon
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: ahlaht@gmail.com


Created an attachment (id=48691)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=48691)
Do not limit clocks.patch

As of Linux 3.0-rc5 radeon_set_power_state() does not accept clock speeds
higher than the defaults set by firmware. However on my HP laptop the default
clock speeds are much lower than the maximum speeds accepted by the card.

These are the default values on my HP laptop:
engine 100000 kHz, memory 157000 kHz, vddc 900 mV

And the other values:

echo low > power_profile
power_state 4, clock_mode 0, engine 100000, memory 150000, vddc 900

echo mid > power_profile
power_state 4, clock_mode 1, engine 100000, memory 150000, vddc 900

echo high > power_profile
power_state 1, clock_mode 2, engine 100000, memory 157000, vddc 1000


The problem occurs with the "high" profile and also when using "dynpm". See the
provided patch, it fixes the problem. With the patch applied, correct
frequencies are set:

echo high > power_profile
power_state 1, clock_mode 2, engine 550000, memory 800000, vddc 1000

Now the question remains: why where those checks added in the first place? They
don't make sense to me unless default clock speeds are specified to be the
highest possible. Also there is no such check for voltage.

I do not know if this patch can break some other already broken systems, but
it's important to fix the problem somehow because it severely limits 3d
performance.

The hardware is AMD Mobility Radeon HD 5650 (1002:68C1).

I'm attaching a complete list of power states on this system. Also for
reference here are the values used by Windows 7 when on AC power (I forgot to
test battery power):

Win 7 Catalyst PowerPlay disabled:
engine 100000, memory 157000, vddc 900

Win 7 Catalyst PowerPlay enabled:
engine 100000, memory 150000, vddc 900   GPU idle
engine 450000, memory 800000, vddc 950   Light load
engine 550000, memory 800000, vddc 1000  Heavy load

The last 2 modes here are identical to what dynpm uses on Linux after the
patch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38917] [patch] Radeon clocks should not be limited to defaults

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38917

--- Comment #1 from Antti Lahtinen <ahlaht@gmail.com> 2011-07-02 11:43:03 PDT ---
Created an attachment (id=48693)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=48693)
power states by radeon_pm_print_states

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38917] [patch] Radeon clocks should not be limited to defaults

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38917

Antti Lahtinen <ahlaht@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48691|application/octet-stream    |text/plain
          mime type|                            |
  Attachment #48691|0                           |1
           is patch|                            |

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38917] [patch] Radeon clocks should not be limited to defaults

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38917

--- Comment #2 from Alex Deucher <agd5f@yahoo.com> 2011-07-05 06:40:11 PDT ---
There's no infrastructure in place yet to automatically lower clocks if the
temperature gets to a critical level so we limit the clocks to the boot up
levels for now.  On most systems the boot clocks are much closer to the
performance clocks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38917] [patch] Radeon clocks should not be limited to defaults

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=38917

Antti Lahtinen <ahlaht@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #48691|0                           |1
        is obsolete|                            |

--- Comment #3 from Antti Lahtinen <ahlaht@gmail.com> 2011-07-18 01:55:57 PDT ---
Created an attachment (id=49237)
 View: https://bugs.freedesktop.org/attachment.cgi?id=49237
 Review: https://bugs.freedesktop.org/review?bug=38917&attachment=49237

Add power_table in /sys

Here is an another patch I was asked to send. It unfortunately does not add
temperature monitoring, but it allows the user to remove the limit optionally.

It adds two new files in /sys/class/drm/card0/device: power_table and
allow_overclocking.

power_table contains the system specific list of power states and some extra
information. The whole file or just parts of it can be written back to change
some of the values run-time.

These 5 values can be changed on each clock mode:
- RADEON_PM_MODE_NO_DISPLAY (It may be useful to remove this flag to enable
  the lowest clock mode for dynpm.)
- engine clock
- memory clock
- vddc
- vddci

The changes actually done are printed to dmesg. Currently the power state is
not automatically reset after a change has been made. This must be done
manually by switching to another clock mode temporarily:
echo high > /sys/class/drm/card0/device/power_profile
echo mid > /sys/class/drm/card0/device/power_profile

For safety the clock rates and voltages can not be set to unlimited values by
default. The safety checks can be disabled with:
echo 1 > /sys/class/drm/card0/device/allow_overclocking

(This should also be done on systems affected by this bug.)

Of course incorrect combinations of clock rates and voltage can still crash the
system even with the checks enabled, but hopefully without permanent damage.

This new patch should not change the default behavior in any way other than
printing an error if the boot up clocks appear to be low.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 38917] [patch] Radeon clocks should not be limited to defaults

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 402 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=38917

--- Comment #4 from Tomas Pospisek <tpo_deb@sourcepole.ch> ---
As of linux 3.11 there is additional power management infrastructure for
radeons:

http://www.botchco.com/agd5f/?p=57

Does that change anything wrt the here required functionality respectively this
bug report?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1240 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 38917] [patch] Radeon clocks should not be limited to defaults

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 226 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=38917

--- Comment #5 from almos <aaalmosss@gmail.com> ---
Shouldn't this be resolved by new dpm method?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1004 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 38917] [patch] Radeon clocks should not be limited to defaults

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 569 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=38917

Christian König <deathsimple@vodafone.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #6 from Christian König <deathsimple@vodafone.de> ---
Yes indeed, this bug report is superfluous now to do DPM.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2111 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel