* [Bug 45558] New: cannot render on a drawable of size equal the max framebuffer size
@ 2012-02-02 18:36 bugzilla-daemon
2012-02-02 18:40 ` [Bug 45558] " bugzilla-daemon
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: bugzilla-daemon @ 2012-02-02 18:36 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=45558
Bug #: 45558
Summary: cannot render on a drawable of size equal the max
framebuffer size
Classification: Unclassified
Product: Mesa
Version: git
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: medium
Component: Drivers/DRI/i830
AssignedTo: dri-devel@lists.freedesktop.org
ReportedBy: prahal@yahoo.com
Created attachment 56550
--> https://bugs.freedesktop.org/attachment.cgi?id=56550
do not drift one pixel above what we want - x2, y2 are exclusive max
The xorg drawable sizes are exclusive as I have learned on xorg-devel irc
channel by MrCooper.
This means that width = x2 - x1 , x2 behing exclusive and thus in the places
the code does DrawBuffer->Width + x1 to get the right coordinate when we get a
coordinate one pixel above what we want (ie we send x2 which is exclusive).
This patch fixes a few places were the gen2 865g are affected by this bug. That
is gnome-shell renders badly due to cogl using atlas a power of two of the
resolution (which is good but this leads to 2048 which is the framebuffer max
size on gen2).
I will also attach the testcase I used which is dumb but reproduce the same
issue as gnome-shell /cogl. Ie a drawable attached to the context as read and
draw buffer the size equal to framebuffer max size , ie 2048, on 865g gen2.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug 45558] cannot render on a drawable of size equal the max framebuffer size
2012-02-02 18:36 [Bug 45558] New: cannot render on a drawable of size equal the max framebuffer size bugzilla-daemon
@ 2012-02-02 18:40 ` bugzilla-daemon
2012-02-02 18:40 ` bugzilla-daemon
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2012-02-02 18:40 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=45558
--- Comment #1 from Alban Browaeys <prahal@yahoo.com> 2012-02-02 10:40:03 PST ---
Created attachment 56551
--> https://bugs.freedesktop.org/attachment.cgi?id=56551
testcase for max not rendering
This testcase is made from a mesa demo. The issue is that with WindowSize 2048
(width and height - and width or height) where the max framebuffer size is 2048
the render fails.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug 45558] cannot render on a drawable of size equal the max framebuffer size
2012-02-02 18:36 [Bug 45558] New: cannot render on a drawable of size equal the max framebuffer size bugzilla-daemon
2012-02-02 18:40 ` [Bug 45558] " bugzilla-daemon
@ 2012-02-02 18:40 ` bugzilla-daemon
2012-02-05 22:50 ` bugzilla-daemon
2012-03-03 1:31 ` bugzilla-daemon
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2012-02-02 18:40 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=45558
Alban Browaeys <prahal@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56550|application/octet-stream |text/plain
mime type| |
Attachment #56550|0 |1
is patch| |
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug 45558] cannot render on a drawable of size equal the max framebuffer size
2012-02-02 18:36 [Bug 45558] New: cannot render on a drawable of size equal the max framebuffer size bugzilla-daemon
2012-02-02 18:40 ` [Bug 45558] " bugzilla-daemon
2012-02-02 18:40 ` bugzilla-daemon
@ 2012-02-05 22:50 ` bugzilla-daemon
2012-03-03 1:31 ` bugzilla-daemon
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2012-02-05 22:50 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=45558
--- Comment #2 from Alban Browaeys <prahal@yahoo.com> 2012-02-05 14:50:24 PST ---
To clarify I meant src/mesa/drivers/dri/i915/intel_context.c:
ctx->Const.MaxRenderbufferSize = 2048;
not framebuffer size. That is the drawable size attached to the gl context. It
is 2048 for less or equal to gen 3.
So the test should be right for gen3 too.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug 45558] cannot render on a drawable of size equal the max framebuffer size
2012-02-02 18:36 [Bug 45558] New: cannot render on a drawable of size equal the max framebuffer size bugzilla-daemon
` (2 preceding siblings ...)
2012-02-05 22:50 ` bugzilla-daemon
@ 2012-03-03 1:31 ` bugzilla-daemon
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2012-03-03 1:31 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=45558
Eric Anholt <eric@anholt.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #3 from Eric Anholt <eric@anholt.net> 2012-03-02 17:31:52 PST ---
The BLT ranges are exclusive -- it's only the drawrect that has that oddness.
I pushed that part of the patch, and it does almost entirely fix gnome-shell
rendering.
commit 7d13a6e64bf88566875a8f68e0aac9b937e30feb
Author: Alban Browaeys <prahal@yahoo.com>
Date: Thu Feb 2 19:20:22 2012 +0100
dri/i915: Fix off-by-one in i830 clip region size.
The hardware, like i915, uses an inclusive bounds on min and max for
the drawing rectangle, but we were providing a number for exclusive.
The number of bits used by the hardware only covers this value going
up to the maximum size, so when we programmed 2048 as the maximum
inclusive X, it saw a maximum X of 0 and clipped all rendering. This
caused rendering failures in gnome-shell.
Fixes piglit fbo-maxsize.
v2: dropped changes to the blitter, which does use an exclusive x2, y2.
[change by anholt]
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45558
Reviewed-by: Eric Anholt <eric@anholt.net>
NOTE: This is a candidate for release branches.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-03 1:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-02 18:36 [Bug 45558] New: cannot render on a drawable of size equal the max framebuffer size bugzilla-daemon
2012-02-02 18:40 ` [Bug 45558] " bugzilla-daemon
2012-02-02 18:40 ` bugzilla-daemon
2012-02-05 22:50 ` bugzilla-daemon
2012-03-03 1:31 ` bugzilla-daemon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.