[Buildroot] [Bug 5378] New: dropbear Makefile broken

[Buildroot] [Bug 5378] New: dropbear Makefile broken

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=5378

           Summary: dropbear Makefile broken
           Product: buildroot
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: Other
        AssignedTo: unassigned at buildroot.uclibc.org
        ReportedBy: arved at arved.at
                CC: buildroot at uclibc.org
   Estimated Hours: 0.0


Under some circumstances dropbear 2012.55 adds -lcrypt to the OBJS variable

Instead -lcrypt should be added to LIBS

Patch attached

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 5378] dropbear Makefile broken

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=5378

--- Comment #1 from Tilman Keskin?z <arved@arved.at> 2012-07-19 12:22:22 UTC ---
Created attachment 4430
  --> https://bugs.busybox.net/attachment.cgi?id=4430
Don't add -lcrypu to OBJS

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 5378] dropbear Makefile broken

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=5378

--- Comment #2 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 2012-08-21 12:04:35 UTC ---
What problem is this solving exactly?

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 5378] dropbear Makefile broken

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=5378

--- Comment #3 from Tilman Keskin?z <arved@arved.at> 2012-09-10 11:05:46 UTC ---
The build of the dropbear package was failing, because there was no rule to
create "-lcrypt" obj.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 5378] dropbear Makefile broken

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=5378

--- Comment #4 from Peter Korsgaard <jacmet@uclibc.org> 2012-09-10 19:53:16 UTC ---
(In reply to comment #3)
> The build of the dropbear package was failing, because there was no rule to
> create "-lcrypt" obj.

Hmm, I don't seem to be able to reproduce this. Could you provide more details
about your config, please?

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 5378] dropbear Makefile broken

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=5378

--- Comment #5 from Mike Frysinger <vapier@gentoo.org> 2012-09-10 20:05:14 UTC ---
(In reply to comment #1)

it would be better to fix Makefile.in itself and then send the fix upstream

(In reply to comment #2)

make has implicit rules to handle "-lfoo" in its dependency list.  so dropbear
does this:

dropbearobjs=$(COMMONOBJS) $(CLISVROBJS) $(SVROBJS) @CRYPTLIB@
...
dropbear: $(dropbearobjs)

this expands into:
dropbear: ... -lcrypt

and make executes its implicit code to try and find /usr/lib/libcrypt.a.  if
you don't have that, it'll fail.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 5378] dropbear Makefile broken

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=5378

--- Comment #6 from Peter Korsgaard <jacmet@uclibc.org> 2012-09-10 20:52:39 UTC ---
(In reply to comment #5)
> (In reply to comment #1)
> 
> it would be better to fix Makefile.in itself and then send the fix upstream
> 
> (In reply to comment #2)
> 
> make has implicit rules to handle "-lfoo" in its dependency list.  so dropbear
> does this:
> 
> dropbearobjs=$(COMMONOBJS) $(CLISVROBJS) $(SVROBJS) @CRYPTLIB@
> ...
> dropbear: $(dropbearobjs)
> 
> this expands into:
> dropbear: ... -lcrypt
> 
> and make executes its implicit code to try and find /usr/lib/libcrypt.a.  if
> you don't have that, it'll fail.

Ahh yes, I missed that.

And yes, I agree with Mike. Please fix it correctly (E.G. in Makefile.in) and
submit upstream.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 5378] dropbear Makefile broken

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=5378

Gustavo Zacarias <gustavo@zacarias.com.ar> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #7 from Gustavo Zacarias <gustavo@zacarias.com.ar> 2013-12-11 17:16:47 UTC ---
Upstream bug, please submit your patch to them.
Thanks.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.