* [Bug 54867] New: bug in r300 compiler
@ 2012-09-13 14:19 bugzilla-daemon
2013-05-31 2:22 ` [Bug 54867] " bugzilla-daemon
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: bugzilla-daemon @ 2012-09-13 14:19 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=54867
Bug #: 54867
Summary: bug in r300 compiler
Classification: Unclassified
Product: Mesa
Version: git
Platform: All
OS/Version: Linux (All)
Status: NEW
Severity: normal
Priority: medium
Component: Drivers/Gallium/r300
AssignedTo: dri-devel@lists.freedesktop.org
ReportedBy: son_of_the_osiris@interia.pl
Orginally posted on mailing list:
In playing with Coccinelle, I discovered a signed/unsigned bug in
radeon_rename_regs.c:rc_rename_regs.
unsigned new_index;
unsigned writemask;
struct rc_variable * var = var_ptr->Item;
if (var->Inst->U.I.DstReg.File != RC_FILE_TEMPORARY) {
continue;
}
new_index = rc_find_free_temporary_list(c, used, used_length,
RC_MASK_XYZW);
if (new_index < 0) {
rc_error(c, "Ran out of temporary registers\n");
return;
}
unsigned new_index is compared with < 0.
I don't know the code, but I can't imagine that you'd need an unsigned
to represent a register index value.
Matt Turner
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 54867] bug in r300 compiler
2012-09-13 14:19 [Bug 54867] New: bug in r300 compiler bugzilla-daemon
@ 2013-05-31 2:22 ` bugzilla-daemon
2013-06-03 13:31 ` bugzilla-daemon
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2013-05-31 2:22 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 315 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=54867
--- Comment #1 from Chistopher Krakowiak <krzysztof.krakowiak@gmail.com> ---
Created attachment 80074
--> https://bugs.freedesktop.org/attachment.cgi?id=80074&action=edit
s/signed/int/
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1249 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 54867] bug in r300 compiler
2012-09-13 14:19 [Bug 54867] New: bug in r300 compiler bugzilla-daemon
2013-05-31 2:22 ` [Bug 54867] " bugzilla-daemon
@ 2013-06-03 13:31 ` bugzilla-daemon
2013-10-04 20:02 ` bugzilla-daemon
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2013-06-03 13:31 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1028 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=54867
--- Comment #2 from Tom Stellard <tstellar@gmail.com> ---
Comment on attachment 80074
--> https://bugs.freedesktop.org/attachment.cgi?id=80074
s/signed/int/
Review of attachment 80074:
-----------------------------------------------------------------
This patch looks good to me, but for the commit message, you need to wrap long
lines to 80 or fewer characters (I actually wrap to 75, but I'm not sure what
the standard convention is) and re-organize the commit message in the form of:
Code area: Brief description
Long description (if necessary)
Link to fixed bugs
For this patch, it should be something like:
r300g/compiler: Fix unsigned comparison with less than zero
rc_find_free_temporary_list() returns signed integer (in case of lack of free
temporary registersreturns -1), so new_index in radeon_rename_regs() should be
signed.
https://bugs.freedesktop.org/show_bug.cgi?id=54867
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2354 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 54867] bug in r300 compiler
2012-09-13 14:19 [Bug 54867] New: bug in r300 compiler bugzilla-daemon
2013-05-31 2:22 ` [Bug 54867] " bugzilla-daemon
2013-06-03 13:31 ` bugzilla-daemon
@ 2013-10-04 20:02 ` bugzilla-daemon
2013-10-07 13:41 ` bugzilla-daemon
2013-10-07 16:09 ` bugzilla-daemon
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2013-10-04 20:02 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 276 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=54867
--- Comment #3 from David "okias" Heidelberger <david.heidelberger@ixit.cz> ---
So, still not pushed in today git, can someone push this small fix?
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1032 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 54867] bug in r300 compiler
2012-09-13 14:19 [Bug 54867] New: bug in r300 compiler bugzilla-daemon
` (2 preceding siblings ...)
2013-10-04 20:02 ` bugzilla-daemon
@ 2013-10-07 13:41 ` bugzilla-daemon
2013-10-07 16:09 ` bugzilla-daemon
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2013-10-07 13:41 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 358 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=54867
--- Comment #4 from Tom Stellard <tstellar@gmail.com> ---
(In reply to comment #3)
> So, still not pushed in today git, can someone push this small fix?
I can push it if you provide an updated patch with a proper commit message.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1142 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 54867] bug in r300 compiler
2012-09-13 14:19 [Bug 54867] New: bug in r300 compiler bugzilla-daemon
` (3 preceding siblings ...)
2013-10-07 13:41 ` bugzilla-daemon
@ 2013-10-07 16:09 ` bugzilla-daemon
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2013-10-07 16:09 UTC (permalink / raw)
To: dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 912 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=54867
David "okias" Heidelberger <david.heidelberger@ixit.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|dri-devel@lists.freedesktop |david.heidelberger@ixit.cz
|.org |
Attachment #80074|0 |1
is obsolete| |
--- Comment #5 from David "okias" Heidelberger <david.heidelberger@ixit.cz> ---
Created attachment 87247
--> https://bugs.freedesktop.org/attachment.cgi?id=87247&action=edit
0001-r300g-compiler-Fix-unsigned-comparison-with-less-tha.patch
Hi Tom,
sending correctly formated commit message.
David
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2711 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-07 16:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-13 14:19 [Bug 54867] New: bug in r300 compiler bugzilla-daemon
2013-05-31 2:22 ` [Bug 54867] " bugzilla-daemon
2013-06-03 13:31 ` bugzilla-daemon
2013-10-04 20:02 ` bugzilla-daemon
2013-10-07 13:41 ` bugzilla-daemon
2013-10-07 16:09 ` bugzilla-daemon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.