[Buildroot] [Bug 6128] New: [patch] Fix S01logging pidfile handling

[Buildroot] [Bug 6128] New: [patch] Fix S01logging pidfile handling

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=6128

           Summary: [patch] Fix S01logging pidfile handling
           Product: buildroot
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Other
        AssignedTo: unassigned at buildroot.uclibc.org
        ReportedBy: arved at arved.at
                CC: buildroot at uclibc.org
   Estimated Hours: 0.0


There are two issues with S01logging

1. The initscript relies on the daemon creating a Pidfile, but the relevant
option has been disabled in the busybox-1.20.x-config. 
2. The name contains a typo syslogd vs. syslog.

This is fixed with the attached patch.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 6128] [patch] Fix S01logging pidfile handling

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=6128

--- Comment #1 from Tilman Keskin?z <arved@arved.at> 2013-03-20 14:00:49 UTC ---
Created attachment 4820
  --> https://bugs.busybox.net/attachment.cgi?id=4820
Fix syslog initscript

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 6128] [patch] Fix S01logging pidfile handling

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=6128

--- Comment #2 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 2013-03-20 14:30:20 UTC ---
Thanks. Can you send this as two proper separate patches on the Buildroot
mailing list?

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 6128] [patch] Fix S01logging pidfile handling

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=6128

--- Comment #3 from Tilman Keskin?z <arved@arved.at> 2013-03-20 15:42:06 UTC ---
done, mail waits now for moderator approval

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Buildroot] [Bug 6128] [patch] Fix S01logging pidfile handling

[Tilman Keskinöz]

* bugzilla [Wed, 20 Mar 2013 14:29:36 +0000 (UTC)]:
> https://bugs.busybox.net/show_bug.cgi?id=6128
> 
> --- Comment #2 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 2013-03-20 14:30:20 UTC ---
> Thanks. Can you send this as two proper separate patches on the Buildroot
> mailing list?
> 




-------------- next part --------------
--- S01logging.orig	2013-03-20 14:42:18.313615967 +0100
+++ S01logging	2013-03-20 14:42:35.373615539 +0100
@@ -6,13 +6,13 @@
 case "$1" in
   start)
 	echo -n "Starting logging: "
-	start-stop-daemon -S -q -p /var/run/syslog.pid --exec /sbin/syslogd -- -m 0
+	start-stop-daemon -S -q -p /var/run/syslogd.pid --exec /sbin/syslogd -- -m 0
 	start-stop-daemon -S -q -p /var/run/klogd.pid --exec /sbin/klogd
 	echo "OK"
 	;;
   stop)
 	echo -n "Stopping logging: "
-	start-stop-daemon -K -q -p /var/run/syslog.pid
+	start-stop-daemon -K -q -p /var/run/syslogd.pid
 	start-stop-daemon -K -q -p /var/run/klogd.pid
 	echo "OK"
 	;;

-------------- next part --------------
--- busybox-1.20.x.config.orig	2013-03-20 14:42:31.297615642 +0100
+++ busybox-1.20.x.config	2013-03-20 14:42:51.045615146 +0100
@@ -41,7 +41,7 @@
 CONFIG_FEATURE_CLEAN_UP=y
 CONFIG_FEATURE_UTMP=y
 CONFIG_FEATURE_WTMP=y
-# CONFIG_FEATURE_PIDFILE is not set
+CONFIG_FEATURE_PIDFILE=y
 CONFIG_FEATURE_SUID=y
 # CONFIG_FEATURE_SUID_CONFIG is not set
 # CONFIG_FEATURE_SUID_CONFIG_QUIET is not set

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130325/3d5bb88f/attachment-0001.asc>

[Buildroot] [Bug 6128] [patch] Fix S01logging pidfile handling

[Thomas Petazzoni]

Dear Tilman Keskin?z,

On Mon, 25 Mar 2013 12:09:00 +0100, Tilman Keskin?z wrote:
> * bugzilla [Wed, 20 Mar 2013 14:29:36 +0000 (UTC)]:
> > https://bugs.busybox.net/show_bug.cgi?id=6128
> > 
> > --- Comment #2 from Thomas Petazzoni
> > <thomas.petazzoni@free-electrons.com> 2013-03-20 14:30:20 UTC ---
> > Thanks. Can you send this as two proper separate patches on the
> > Buildroot mailing list?

Thanks, but unfortunately, those patches can't be applied as is. They
should be Git patches, with a commit log that explains why the patch
is needed and what it is doing, a Signed-off-by line, and sent inline
(and not as attachements) using git send-email.

Could you do this?

Thanks a lot for your contribution!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [Bug 6128] [patch] Fix S01logging pidfile handling

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=6128

Samuel Martin <s.martin49@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Samuel Martin <s.martin49@gmail.com> 2013-05-26 11:36:07 UTC ---
The S01logging script typo has been merged.

The pidfile management remains deferred to start-stop-daemon, so the change in
the busybox configs is not needed; though any user can enable it.

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.