All of lore.kernel.org
 help / color / mirror / Atom feed
* [Bug 80684] New: I2C-over-AUX drops single bytes
@ 2014-06-29 18:09 bugzilla-daemon
  2014-06-29 18:35 ` [Bug 80684] " bugzilla-daemon
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: bugzilla-daemon @ 2014-06-29 18:09 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 2330 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=80684

          Priority: medium
            Bug ID: 80684
          Assignee: dri-devel@lists.freedesktop.org
           Summary: I2C-over-AUX drops single bytes
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: stefan.bruens@rwth-aachen.de
          Hardware: Other
            Status: NEW
           Version: DRI CVS
         Component: DRM/Radeon
           Product: DRI

I get frequent errors for the EDID checksum, obviously single bytes are dropped
from the EDID.

Good EDID:
Raw EDID:
      02 03 1d f1 50 90 05 04 03 02 07 16 01 06 11 12
      15 13 14 1f 20 23 09 7f 07 83 01 00 00 02 3a 80
      18 71 38 2d 40 58 2c 25 00 55 50 21 00 00 1e 01
      1d 80 18 71 1c 16 20 58 2c 25 00 55 50 21 00 00 <-- 
      9e 01 1d 00 72 51 d0 1e 20 6e 28 55 00 55 50 21
      00 00 1e 8c 0a d0 8a 20 e0 2d 10 10 3e 96 00 55
      50 21 00 00 18 00 00 00 00 00 00 00 00 00 00 00
      00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 5d

Bad EDID example:
Raw EDID:
      02 03 1d f1 50 90 05 04 03 02 07 16 01 06 11 12
      15 13 14 1f 20 23 09 7f 07 83 01 00 00 02 3a 80
      18 71 38 2d 40 58 2c 25 00 55 50 21 00 00 1e 01
      1d 80 18 1c 16 20 58 2c 25 00 55 50 21 00 00 9e <-- 0x71 is missing
      01 1d 00 72 51 d0 1e 20 6e 28 55 00 55 50 21 00
      00 1e 8c 0a d0 8a 20 e0 2d 10 10 3e 96 00 55 50
      21 00 00 18 00 00 00 00 00 00 00 00 00 00 00 00
      00 00 00 00 00 00 00 00 00 00 00 00 00 00 5d 00

The position of the dropped byte changes, sometimes the EDID is complete,
sometimes several bytes are dropped.

The bad EDIDs are *often* accompanied with [drm:radeon_process_aux_ch]
dp_aux_ch flags not zero messages.

Most probably the common i2c-over-aux code drops the byte, as it starts the
transfer again in case of -EBUSY. If I change radeon_process_aux_ch to return
-EIO in case of (ReplyStatus == 2), I no longer have any bad checksums.

Hardware is Radeon 7750 + Dell U2713HM, connected via DP.

Same monitor with Intel Haswell and different cable works without any errors.

Kernel is 3.15.1, i.e. without the i2c bus mutex, dont know if this fixes the
problems as well.^[

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3700 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 80684] I2C-over-AUX drops single bytes
  2014-06-29 18:09 [Bug 80684] New: I2C-over-AUX drops single bytes bugzilla-daemon
@ 2014-06-29 18:35 ` bugzilla-daemon
  2014-07-01 16:00 ` bugzilla-daemon
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2014-06-29 18:35 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 267 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=80684

--- Comment #1 from Stefan Brüns <stefan.bruens@rwth-aachen.de> ---
I have added the i2c bus mutex, this does *not* fix this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1034 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 80684] I2C-over-AUX drops single bytes
  2014-06-29 18:09 [Bug 80684] New: I2C-over-AUX drops single bytes bugzilla-daemon
  2014-06-29 18:35 ` [Bug 80684] " bugzilla-daemon
@ 2014-07-01 16:00 ` bugzilla-daemon
  2014-07-02 23:19 ` bugzilla-daemon
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2014-07-01 16:00 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 317 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=80684

--- Comment #2 from Alex Deucher <agd5f@yahoo.com> ---
Created attachment 102076
  --> https://bugs.freedesktop.org/attachment.cgi?id=102076&action=edit
possible fix

Does this patch help?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1252 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 80684] I2C-over-AUX drops single bytes
  2014-06-29 18:09 [Bug 80684] New: I2C-over-AUX drops single bytes bugzilla-daemon
  2014-06-29 18:35 ` [Bug 80684] " bugzilla-daemon
  2014-07-01 16:00 ` bugzilla-daemon
@ 2014-07-02 23:19 ` bugzilla-daemon
  2014-07-02 23:22 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2014-07-02 23:19 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 753 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=80684

Stefan Brüns <stefan.bruens@rwth-aachen.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #102076|0                           |1
        is obsolete|                            |

--- Comment #3 from Stefan Brüns <stefan.bruens@rwth-aachen.de> ---
Created attachment 102173
  --> https://bugs.freedesktop.org/attachment.cgi?id=102173&action=edit
different approach

This patch fixes the problem for me. I get several warning messages with "flags
not zero", but the EDID is complete and correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2258 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 80684] I2C-over-AUX drops single bytes
  2014-06-29 18:09 [Bug 80684] New: I2C-over-AUX drops single bytes bugzilla-daemon
                   ` (2 preceding siblings ...)
  2014-07-02 23:19 ` bugzilla-daemon
@ 2014-07-02 23:22 ` bugzilla-daemon
  2014-07-03 15:23 ` bugzilla-daemon
  2019-11-20  8:05 ` bugzilla-daemon
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2014-07-02 23:22 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 499 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=80684

--- Comment #4 from Stefan Brüns <stefan.bruens@rwth-aachen.de> ---
(In reply to comment #2)
> Created attachment 102076 [details] [review]
> possible fix
> 
> Does this patch help?

Nope, unfortunately not.

The transfer has actually worked, even with nonzero flags. *if* we want to
start the transfer again, we have to set the offset before doing so.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1620 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 80684] I2C-over-AUX drops single bytes
  2014-06-29 18:09 [Bug 80684] New: I2C-over-AUX drops single bytes bugzilla-daemon
                   ` (3 preceding siblings ...)
  2014-07-02 23:22 ` bugzilla-daemon
@ 2014-07-03 15:23 ` bugzilla-daemon
  2019-11-20  8:05 ` bugzilla-daemon
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2014-07-03 15:23 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 467 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=80684

--- Comment #5 from Alex Deucher <agd5f@yahoo.com> ---
Created attachment 102203
  --> https://bugs.freedesktop.org/attachment.cgi?id=102203&action=edit
return -EIO for flags not zero

Thinking about this more, I think returning -EIO is probably the right thing to
do since we don't know for sure whether the transaction succeeded or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1438 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug 80684] I2C-over-AUX drops single bytes
  2014-06-29 18:09 [Bug 80684] New: I2C-over-AUX drops single bytes bugzilla-daemon
                   ` (4 preceding siblings ...)
  2014-07-03 15:23 ` bugzilla-daemon
@ 2019-11-20  8:05 ` bugzilla-daemon
  5 siblings, 0 replies; 7+ messages in thread
From: bugzilla-daemon @ 2019-11-20  8:05 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 429 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=80684

Martin Peres <martin.peres@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1238 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-11-20  8:05 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-29 18:09 [Bug 80684] New: I2C-over-AUX drops single bytes bugzilla-daemon
2014-06-29 18:35 ` [Bug 80684] " bugzilla-daemon
2014-07-01 16:00 ` bugzilla-daemon
2014-07-02 23:19 ` bugzilla-daemon
2014-07-02 23:22 ` bugzilla-daemon
2014-07-03 15:23 ` bugzilla-daemon
2019-11-20  8:05 ` bugzilla-daemon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.