* [Bug 80738] New: Possible wrong variable used in nouveau_allocate_surface
@ 2014-07-01 2:27 bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
[not found] ` <bug-80738-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
0 siblings, 1 reply; 2+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2014-07-01 2:27 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
[-- Attachment #1.1: Type: text/plain, Size: 2002 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=80738
Priority: medium
Bug ID: 80738
Assignee: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Summary: Possible wrong variable used in
nouveau_allocate_surface
QA Contact: xorg-team-go0+a7rfsptAfugRpC6u6w@public.gmane.org
Severity: normal
Classification: Unclassified
OS: All
Reporter: pstglia-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Hardware: Other
Status: NEW
Version: unspecified
Component: Driver/nouveau
Product: xorg
Hi,
I was analyzing xf86 video nouveau code and found a possible bug on
nouveau_allocate_surface (nv_accel_common.c src file)
When setting tile_mode for NV_FERMI/NVC0 or higher families, it uses tile_mode
to calculate height. However, instead of using "cfg.nvc0.tile_mode" it is using
"cfg.nv50.tile_mode". See bellow:
if (pNv->Architecture >= NV_FERMI) {
if (height > 64) cfg.nvc0.tile_mode = 0x040;
else if (height > 32) cfg.nvc0.tile_mode = 0x030;
else if (height > 16) cfg.nvc0.tile_mode = 0x020;
else if (height > 8) cfg.nvc0.tile_mode = 0x010;
else cfg.nvc0.tile_mode = 0x000;
if (usage_hint & NOUVEAU_CREATE_PIXMAP_ZETA)
cfg.nvc0.memtype = (bpp == 16) ? 0x01 : 0x11;
else
cfg.nvc0.memtype = 0xfe;
height = NOUVEAU_ALIGN(height,
NVC0_TILE_HEIGHT(cfg.nv50.tile_mode));
If this is intentional, please mark this bug as Invalid and sorry for
disturbing.
Regards,
Paulo Sérgio Travaglia
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 3403 bytes --]
[-- Attachment #2: Type: text/plain, Size: 181 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug 80738] Possible wrong variable used in nouveau_allocate_surface
[not found] ` <bug-80738-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
@ 2014-07-01 2:58 ` bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
0 siblings, 0 replies; 2+ messages in thread
From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ @ 2014-07-01 2:58 UTC (permalink / raw)
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
[-- Attachment #1.1: Type: text/plain, Size: 709 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=80738
Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Ben Skeggs <skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
It's a typo. Fortunately, it shouldn't cause any issue as the fields should be
at the same offsets due to the union.
I've pushed a fix for the typo. Thanks for pointing it out!
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 2123 bytes --]
[-- Attachment #2: Type: text/plain, Size: 181 bytes --]
_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-01 2:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-01 2:27 [Bug 80738] New: Possible wrong variable used in nouveau_allocate_surface bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
[not found] ` <bug-80738-8800-V0hAGp6uBxMKqLRl/0Ahz6D7qz1kEfGD2LY78lusg7I@public.gmane.org/>
2014-07-01 2:58 ` [Bug 80738] " bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.