* [Buildroot] [Bug 849] New: "customize" package copys files to wrong place in target tree
@ 2010-01-08 18:43 bugzilla at busybox.net
2010-01-08 18:47 ` [Buildroot] [Bug 849] "customize" package copies " bugzilla at busybox.net
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: bugzilla at busybox.net @ 2010-01-08 18:43 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=849
Host: Gentoo Linux
Target: Atmel at91sam9g20
Summary: "customize" package copys files to wrong place in target
tree
Product: buildroot
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P5
Component: Other
AssignedTo: unassigned at buildroot.uclibc.org
ReportedBy: grant.b.edwards at gmail.com
CC: buildroot at uclibc.org
Estimated Hours: 0.0
Created an attachment (id=885)
--> (https://bugs.busybox.net/attachment.cgi?id=885)
Patch to fix bug that copies files to wrong place in target tree
I'm attempting to use the "customize" package to get
libgcc_s.so files into my target filesystem, and it doesn't
seem to work. I put files into the package like so:
$ tree customize
customize
|-- Config.in
|-- customize.mk
`-- source
|-- asdf
`-- lib
|-- foobar
|-- libgcc.a
|-- libgcc_eh.a
|-- libgcc_s.so
`-- libgcc_s.so.1
But what ends up on my target filesystem is
/asdf
/lib/lib/libgcc_s.so
/lib/lib/libgcc_s.so.1
/lib/lib/foobar
The two .a files end up being removed later in the build
process, but the other files that I expect to find in /lib end
up in /lib/lib. The mislocation appears to be due to a bug in
customize.mk:
1 #############################################################
2 #
3 # Any custom stuff you feel like doing....
4 #
5 #############################################################
6 CUST_DIR:=package/customize/source
7
8 $(BUILD_DIR)/.customize:
9 rm -f $(BUILD_DIR)/series
10 (cd $(CUST_DIR); \
11 /bin/ls -d * > $(BUILD_DIR)/series || \
12 touch $(BUILD_DIR)/series )
13 for f in `cat $(BUILD_DIR)/series`; do \
14 cp -af $(CUST_DIR)/$$f $(TARGET_DIR)/$$f; \
15 done
16 rm -f $(BUILD_DIR)/series
17 touch $@
Line 14 doesn't work right if there are any pre-existing
directories in the target directory. In my case it ends up
doing:
cp -af package/custom/source/lib output/target/lib
That results in files ending up in /lib/lib instead of /lib
Shouldn't line 14 specify the bare target_dir (and not
specify a target filename)? Copy a file will still work the
same (since the destination is known to be a directory), and
now copying a directory will work when it didn't used to:
14 cp -af $(CUST_DIR)/$$f $(TARGET_DIR)/; \
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [Bug 849] "customize" package copies files to wrong place in target tree
2010-01-08 18:43 [Buildroot] [Bug 849] New: "customize" package copys files to wrong place in target tree bugzilla at busybox.net
@ 2010-01-08 18:47 ` bugzilla at busybox.net
2010-02-21 18:51 ` bugzilla at busybox.net
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla at busybox.net @ 2010-01-08 18:47 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=849
Grant Edwards <grant.b.edwards@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|"customize" package copys |"customize" package copies
|files to wrong place in |files to wrong place in
|target tree |target tree
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [Bug 849] "customize" package copies files to wrong place in target tree
2010-01-08 18:43 [Buildroot] [Bug 849] New: "customize" package copys files to wrong place in target tree bugzilla at busybox.net
2010-01-08 18:47 ` [Buildroot] [Bug 849] "customize" package copies " bugzilla at busybox.net
@ 2010-02-21 18:51 ` bugzilla at busybox.net
2010-03-12 17:43 ` bugzilla at busybox.net
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla at busybox.net @ 2010-02-21 18:51 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=849
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |2010.02
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [Bug 849] "customize" package copies files to wrong place in target tree
2010-01-08 18:43 [Buildroot] [Bug 849] New: "customize" package copys files to wrong place in target tree bugzilla at busybox.net
2010-01-08 18:47 ` [Buildroot] [Bug 849] "customize" package copies " bugzilla at busybox.net
2010-02-21 18:51 ` bugzilla at busybox.net
@ 2010-03-12 17:43 ` bugzilla at busybox.net
2010-03-12 18:21 ` bugzilla at busybox.net
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla at busybox.net @ 2010-03-12 17:43 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=849
Paulius Zaleckas <paulius.zaleckas@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paulius.zaleckas at gmail.com
--- Comment #1 from Paulius Zaleckas <paulius.zaleckas@gmail.com> 2010-03-12 17:43:31 UTC ---
Wrong. Then it will copy wrongly files that needs new directory to be created.
I think we should use install instead of cp.
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [Bug 849] "customize" package copies files to wrong place in target tree
2010-01-08 18:43 [Buildroot] [Bug 849] New: "customize" package copys files to wrong place in target tree bugzilla at busybox.net
` (2 preceding siblings ...)
2010-03-12 17:43 ` bugzilla at busybox.net
@ 2010-03-12 18:21 ` bugzilla at busybox.net
2010-04-09 14:54 ` bugzilla at busybox.net
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla at busybox.net @ 2010-03-12 18:21 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=849
--- Comment #2 from Grant Edwards <grant.b.edwards@gmail.com> 2010-03-12 18:21:03 UTC ---
(In reply to comment #1)
> Wrong. Then it will copy wrongly files that needs new directory to be
> created. I think we should use install instead of cp.
Can you provide an example where it fails?
I tested the patch pretty extensively and it worked fine for me - when
new directories needed to be created.
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [Bug 849] "customize" package copies files to wrong place in target tree
2010-01-08 18:43 [Buildroot] [Bug 849] New: "customize" package copys files to wrong place in target tree bugzilla at busybox.net
` (3 preceding siblings ...)
2010-03-12 18:21 ` bugzilla at busybox.net
@ 2010-04-09 14:54 ` bugzilla at busybox.net
2010-04-09 14:55 ` bugzilla at busybox.net
2010-05-06 21:29 ` bugzilla at busybox.net
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla at busybox.net @ 2010-04-09 14:54 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=849
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|2010.02 |2010.05
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [Bug 849] "customize" package copies files to wrong place in target tree
2010-01-08 18:43 [Buildroot] [Bug 849] New: "customize" package copys files to wrong place in target tree bugzilla at busybox.net
` (4 preceding siblings ...)
2010-04-09 14:54 ` bugzilla at busybox.net
@ 2010-04-09 14:55 ` bugzilla at busybox.net
2010-04-09 15:23 ` Jens
2010-05-06 21:29 ` bugzilla at busybox.net
6 siblings, 1 reply; 9+ messages in thread
From: bugzilla at busybox.net @ 2010-04-09 14:55 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=849
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |serj.kalichev at gmail.com
--- Comment #3 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 2010-04-09 14:55:00 UTC ---
*** Bug 1135 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [Bug 849] "customize" package copies files to wrong place in target tree
2010-04-09 14:55 ` bugzilla at busybox.net
@ 2010-04-09 15:23 ` Jens
0 siblings, 0 replies; 9+ messages in thread
From: Jens @ 2010-04-09 15:23 UTC (permalink / raw)
To: buildroot
Hi,
that simple patch works fine for me (just using cp with 'r' option):
BR,
Jens
diff -Nur --exclude=config buildroot.orig/package/customize/customize.mk
buildroot/package/customize/customize.mk
--- buildroot.orig/package/customize/customize.mk 2010-02-26
15:52:48.000000000 +0100
+++ buildroot/package/customize/customize.mk 2010-04-05
00:59:40.000000000 +0200
@@ -6,14 +6,8 @@
CUST_DIR:=package/customize/source
$(BUILD_DIR)/.customize:
- rm -f $(BUILD_DIR)/series
- (cd $(CUST_DIR); \
- /bin/ls -d * > $(BUILD_DIR)/series || \
- touch $(BUILD_DIR)/series )
- for f in `cat $(BUILD_DIR)/series`; do \
- cp -af $(CUST_DIR)/$$f $(TARGET_DIR)/$$f; \
- done
- rm -f $(BUILD_DIR)/series
+ cp -arf $(CUST_DIR)/* $(TARGET_DIR)/
+# rm -f $(BUILD_DIR)/series
touch $@
customize: $(BUILD_DIR)/.customize
> https://bugs.busybox.net/show_bug.cgi?id=849
>
> --- Comment #3 from Thomas Petazzoni <thomas.petazzoni@free-electrons.com> 2010-04-09 14:55:00 UTC ---
> *** Bug 1135 has been marked as a duplicate of this bug. ***
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [Bug 849] "customize" package copies files to wrong place in target tree
2010-01-08 18:43 [Buildroot] [Bug 849] New: "customize" package copys files to wrong place in target tree bugzilla at busybox.net
` (5 preceding siblings ...)
2010-04-09 14:55 ` bugzilla at busybox.net
@ 2010-05-06 21:29 ` bugzilla at busybox.net
6 siblings, 0 replies; 9+ messages in thread
From: bugzilla at busybox.net @ 2010-05-06 21:29 UTC (permalink / raw)
To: buildroot
https://bugs.busybox.net/show_bug.cgi?id=849
Peter Korsgaard <jacmet@uclibc.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #4 from Peter Korsgaard <jacmet@uclibc.org> ---
Fixed in git (ea0695ff5ed) - Thanks, and sorry for the slow response.
--
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-05-06 21:29 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-08 18:43 [Buildroot] [Bug 849] New: "customize" package copys files to wrong place in target tree bugzilla at busybox.net
2010-01-08 18:47 ` [Buildroot] [Bug 849] "customize" package copies " bugzilla at busybox.net
2010-02-21 18:51 ` bugzilla at busybox.net
2010-03-12 17:43 ` bugzilla at busybox.net
2010-03-12 18:21 ` bugzilla at busybox.net
2010-04-09 14:54 ` bugzilla at busybox.net
2010-04-09 14:55 ` bugzilla at busybox.net
2010-04-09 15:23 ` Jens
2010-05-06 21:29 ` bugzilla at busybox.net
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.