[Bug 87738] Please add Image support

[Bug 87738] Please add Image support

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1908 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

            Bug ID: 87738
           Summary: Please add Image support
           Product: DRI
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: enhancement
          Priority: medium
         Component: DRM/Radeon
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: mercen45@gmail.com

Hi,

Image support is required by darktable (RAW photos processing) as can be seen
in the following output, from runnind darktable -d opencl:

[opencl_init] opencl related configuration options:
[opencl_init] 
[opencl_init] opencl: 0
[opencl_init] opencl_library: ''
[opencl_init] opencl_memory_requirement: 768
[opencl_init] opencl_memory_headroom: 300
[opencl_init] opencl_device_priority: '*/!0,*/*/*'
[opencl_init] opencl_size_roundup: 16
[opencl_init] opencl_async_pixelpipe: 0
[opencl_init] opencl_synch_cache: 0
[opencl_init] opencl_number_event_handles: 25
[opencl_init] opencl_micro_nap: 1000
[opencl_init] opencl_use_pinned_memory: 0
[opencl_init] opencl_use_cpu_devices: 0
[opencl_init] opencl_avoid_atomics: 0
[opencl_init] opencl_omit_whitebalance: 0
[opencl_init] 
[opencl_init] trying to load opencl library: '<system default>'
[opencl_init] opencl library 'libOpenCL' found on your system and loaded
[opencl_init] found 1 platform
[opencl_init] found 1 device
[opencl_init] discarding device 0 `AMD OLAND' due to missing image support.
[opencl_init] no suitable devices found.
[opencl_init] FINALLY: opencl is NOT AVAILABLE on this system.
[opencl_init] initial status of opencl enabled flag is OFF.

Not sure if anything else is needed to get OpenCL to work in darktable but it
would be very sweet to be able to get that with open source drivers.

Thanks,
Thomas

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3118 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 634 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|DRM/Radeon                  |Drivers/Gallium/radeonsi
            Version|unspecified                 |git
            Product|DRI                         |Mesa
            Summary|Please add Image support    |[OpenCL] Please add Image
                   |                            |support

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1633 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 513 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

Vedran Miletić <vedran@miletic.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |99553


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=99553
[Bug 99553] Tracker bug for runnning OpenCL applications on Clover
-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1558 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 544 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

--- Comment #1 from Antonio Ospite <ao2@ao2.it> ---
Hi, I still get this when running darktable with mesa 17:

[opencl_init] discarding device 0 `AMD REDWOOD (DRM 2.48.0 / 4.9.0-2-amd64,
LLVM 4.0.0)' due to missing image support.

Is it the driver that lack support for that functionality or is it rather a
limitation of the device itself?

My device is an "ATI Radeon HD 5670".

Thanks,
   Antonio

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1296 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 330 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

--- Comment #2 from Vedran Miletić <vedran@miletic.net> ---
In case anyone works on it, I have saved Zoltan Gillian's patches here:
https://github.com/vedranmiletic/mesa/tree/r600-image-support

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1157 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 393 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

--- Comment #3 from Vedran Miletić <vedran@miletic.net> ---
funfunctor has also worked on it a bit:
https://cgit.freedesktop.org/~funfunctor/mesa/log/?h=clover-image-support
https://cgit.freedesktop.org/~funfunctor/mesa/log/?h=clover-image-support-enabled

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1328 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 494 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

Jan Vesely <jan.vesely@rutgers.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |74974


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=74974
[Bug 74974] [radeonsi] x264 OpenCL does not work
-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1520 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 496 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

Jan Vesely <jan.vesely@rutgers.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |82717


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=82717
[Bug 82717] OpenCL support for mandelbulber-opencl
-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1524 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

Jan Vesely <jan.vesely@rutgers.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |107115


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=107115
[Bug 107115] Make darktable OpenCL support work on Clover and RadeonSI
-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1565 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 496 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

--- Comment #4 from Vasilis LIaskovitis <vliaskovitis@suse.com> ---
I see there are clover patches for image support already upstream e.g.

f2c52e392 clover: Implement CL1.2 clCreateImage().
2518645f6 clover: Implement clCreateImage?D w/ clCreateImage.

What is missing? Driver-specific patches for radeonsi / r600? Any
pointers/guidance would be welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1254 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 87738] [OpenCL] Please add Image support

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 527 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=87738

Timothy Arceri <t_arceri@yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Drivers/Gallium/radeonsi    |Gallium/StateTracker/Clover
           Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
                   |.org                        |org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1322 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel