[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 2076 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

            Bug ID: 89148
           Summary: r300g: Kernel rejected CS in Wine d3d multisample test
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r300
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: stefandoesinger@gmx.at
        QA Contact: dri-devel@lists.freedesktop.org

When running Wine's d3d8 and d3d9 tests in r300g an invalid command stream is
sent to the kernel:

[  916.508352] [drm:radeon_cs_packet_parse] *ERROR* Unknown packet type 1 at
2451 !
[  916.508358] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
[  916.508902] [drm:radeon_cs_packet_parse] *ERROR* Unknown packet type 1 at 69
!
[  916.508905] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream !

The user space driver notices the error and writes a message to stderr. The
test that triggered the invalid command subsequently fails.

The failing line in the tests is
http://source.winehq.org/git/wine.git/blob/f75d1b0c2f77d8c85f7c2a9bcc3545f14e271a86:/dlls/d3d8/tests/visual.c#l3704
. The test performs a copy from a multisampled color buffer to system memory.
Wined3d first resolves the multisampled renderbuffer to a non-multisampled
texture and calls glGetTexImage. Interestingly it is the glGetTexImage step
that fails. The texture has format GL_BGRA, type GL_UNSIGNED_INT_8_8_8_8_REV
and internal format GL_SRGB8_ALPHA8.

We call glGetTexImage in plenty of places in this configuration, and this is
the only case where this fails. I'll try to pin this down a bit further.

The bug can be reproduced by running make visual.ok in dlls/d3d8/tests in a
Wine build tree.

System information:
Wine commit ID: f75d1b0c2f77d8c85f7c2a9bcc3545f14e271a86
Mesa commit ID: e333035c47a6a4cc88f0f9ca2bced500538bebae
Kernel: 3.19
libdrm: 2.4.59
X server: 1.16.3
Distribution: Gentoo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3512 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 523 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #1 from Stefan Dösinger <stefandoesinger@gmx.at> ---
Note that the texture is never used as a source or destination in a regular
draw. It is specified with glTexImage2D, but the data pointer is NULL, and
glTexSubImage2D is never used. It is only filled with data through the FBO_blit
call that resolves the multisampled renderbuffer. As far as I can see no PBO is
used.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1325 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 397 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #2 from Alex Deucher <alexdeucher@gmail.com> ---
Type 1 packets shouldn't be emitted at all and none of the user mode drivers
emit them.  I suspect either the command stream is getting corrupted somewhere
or there is a prior packet count getting set wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1174 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 445 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #3 from Stefan Dösinger <stefandoesinger@gmx.at> ---
My semi-educated guess would be that the multisample resolve blit sets the size
wrong. That would explain why out of the many glGetTexImage calls we're doing
this is the only one that fails.

Time to write a stand-alone test case I guess.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1247 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 3074 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #4 from Stefan Dösinger <stefandoesinger@gmx.at> ---
Created attachment 113562
  --> https://bugs.freedesktop.org/attachment.cgi?id=113562&action=edit
Test program

This program reproduces the result. As a 32 bit binary it generates the same
type 1 command that is rejected. As a 64 bit program it crashes with the
following backtrace:

(gdb) bt
#0  0x00007ffff75c8c90 in ?? () from /lib64/libc.so.6
#1  0x00007ffff2e0bcd3 in memcpy (__len=32, __src=<optimized out>,
__dest=<optimized out>) at /usr/include/bits/string3.h:51
#2  r300_emit_blend_state (r300=<optimized out>, size=8, state=<optimized out>)
at r300_emit.c:57
#3  0x00007ffff2e0f150 in r300_emit_dirty_state (r300=r300@entry=0x649950) at
r300_emit.c:1450
#4  0x00007ffff2e12018 in r300_emit_states (instance_id=-1, index_bias=0,
buffer_offset=0, index_buffer=0x0, flags=<optimized out>, r300=0x649950) at
r300_render.c:259
#5  r300_prepare_for_rendering (r300=r300@entry=0x649950, flags=<optimized
out>, flags@entry=PREP_EMIT_STATES, index_buffer=index_buffer@entry=0x0,
cs_dwords=cs_dwords@entry=21, buffer_offset=buffer_offset@entry=0,
index_bias=index_bias@entry=0, 
    instance_id=instance_id@entry=-1) at r300_render.c:311
#6  0x00007ffff2e13258 in r300_blitter_draw_rectangle (blitter=<optimized out>,
x1=0, y1=0, x2=256, y2=256, depth=0, type=UTIL_BLITTER_ATTRIB_NONE, attrib=0x0)
at r300_render.c:1141
#7  0x00007ffff2d7d3df in util_blitter_custom_color (blitter=0x61c7f0,
dstsurf=dstsurf@entry=0x79e030, custom_blend=custom_blend@entry=0x0) at
util/u_blitter.c:2146
#8  0x00007ffff2e06b91 in r300_simple_msaa_resolve (pipe=pipe@entry=0x649950,
dst=dst@entry=0x79dcd0, dst_level=dst_level@entry=0,
dst_layer=dst_layer@entry=0, src=<optimized out>,
format=PIPE_FORMAT_B8G8R8A8_SRGB) at r300_blit.c:737
#9  0x00007ffff2e08396 in r300_msaa_resolve (info=0x7ffffffbdc70,
pipe=0x649950) at r300_blit.c:783
#10 r300_blit (pipe=0x649950, blit=<optimized out>) at r300_blit.c:809
#11 0x00007ffff2c2ad97 in st_BlitFramebuffer (ctx=<optimized out>,
readFB=0x796f30, drawFB=0x79d6b0, srcX0=<optimized out>, srcY0=<optimized out>,
srcX1=<optimized out>, srcY1=256, dstX0=0, dstY0=0, dstX1=256, dstY1=256,
mask=16384, filter=9728)
    at state_tracker/st_cb_blit.c:263
#12 0x00007ffff2af2ff2 in _mesa_BlitFramebuffer (srcX0=<optimized out>,
srcY0=0, srcX1=<optimized out>, srcY1=256, dstX0=<optimized out>,
dstY0=<optimized out>, dstX1=256, dstY1=256, mask=16384, filter=9728) at
main/blit.c:509
#13 0x000000000040132f in init ()
#14 0x000000000040148a in main ()

Further testing shows that the GL_SRGB8_ALPHA8 internal format of the
destination texture is the problem. Replacing this with GL_RGBA8 makes the test
work fine. Note that when GL_EXT_sRGB_decode is available Wine always creates
sRGB textures and sets GL_TEXTURE_SRGB_DECODE_EXT to GL_SKIP_DECODE_EXT to get
d3d-style sRGB read correction toggling.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 4150 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 404 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #5 from Alex Deucher <alexdeucher@gmail.com> ---
Created attachment 113620
  --> https://bugs.freedesktop.org/attachment.cgi?id=113620&action=edit
add some debugging output

Can you apply this kernel patch and attach your kernel log output when you hit
the error?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1409 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 382 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #6 from Marek Olšák <maraeo@gmail.com> ---
Created attachment 113719
  --> https://bugs.freedesktop.org/attachment.cgi?id=113719&action=edit
workaround

Can you test this patch? Note that GL_ARB_framebuffer_sRGB is unsupported.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1372 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 308 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #7 from Stefan Dösinger <stefandoesinger@gmx.at> ---
I'll try it in the next two days. If the workaround doesn't work I'll try to
get the log Alex asked for.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1110 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 392 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #8 from Marek Olšák <maraeo@gmail.com> ---
I'm pretty sure the CS parser errors were caused by random garbage emitted by
r300g. The driver doesn't expect an sRGB format in the framebuffer, which only
seems to happen with glBlitFramebuffer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1185 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 539 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #9 from Stefan Dösinger <stefandoesinger@gmx.at> ---
No more segfaults, but it still has a rejected CS:

[129870.605179] [drm:r100_cs_track_check] *ERROR* [drm] Buffer too small for
color buffer 0 (need 8387584 have 524288) !
[129870.605186] [drm:r100_cs_track_check] *ERROR* [drm] color buffer 0 (16382 2
0 256)
[129870.605189] [drm:radeon_cs_ioctl] *ERROR* Invalid command stream !

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1341 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 611 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #113719|0                           |1
        is obsolete|                            |

--- Comment #10 from Marek Olšák <maraeo@gmail.com> ---
Created attachment 113802
  --> https://bugs.freedesktop.org/attachment.cgi?id=113802&action=edit
fix

This patch should fix it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2112 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1068 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #11 from Stefan Dösinger <stefandoesinger@gmx.at> ---
Attachment 113802 fixes the invalid CS / crash and my test program now reads a
color. However, sRGB color correction seems to be applied at some stage. Note
that the test program is not using GL_ARB_framebuffer_sRGB (which isn't
supported on r500 anyway), and that GL_TEXTURE_SRGB_DECODE_EXT is set to
GL_SKIP_DECODE_EXT.

It seems that the correction is applied during blitting. If I clear the 2D
texture directly the expected result (0x0000ff80) is returned. If I use the
renderbuffer and blit I get 0x0000ff37.

(Wine expects that glBlitFramebuffer never applies sRGB correction when
blitting from an sRGB texture, but this codepath is only used if
GL_EXT_sRGB_decode is not supported. In this case we load two copies of the
texture, one sRGB and one RGB, and use glBlitFramebuffer to blit between them
if the application toggles sRGB on and off.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2042 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 322 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #12 from Marek Olšák <maraeo@gmail.com> ---
r300g doesn't do sRGB conversion for MSAA resolves. It always interprets the
textures as linear and only averages the samples.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1116 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 434 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

--- Comment #13 from Stefan Dösinger <stefandoesinger@gmx.at> ---
The thing that seems to trigger the sRGB correction is the fact that the
destination texture has an sRGB internal. If I change it to GL_RGBA8 I get the
expected result.

The format of the source RB doesn't seem to matter here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1237 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 89148] r300g: Kernel rejected CS in Wine d3d multisample test

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 682 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=89148

Stefan Dösinger <stefandoesinger@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Stefan Dösinger <stefandoesinger@gmx.at> ---
Fixed by 9953586af2254f83a610d4cd284f52f37fa18b98 and
c939231e7223510408a446400ad23b8b5ce2922e. My test program returns the correct
color and the Wine test passes. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2216 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel