[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1361 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

            Bug ID: 90056
           Summary: Unigine Valley regression since radeon/llvm: Run
                    LLVM's instruction combining pass
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: adf.lists@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

R9270X

Since 

commit c6d79ed289a75f13c65f011be870f7e43a0fedc7
Author: Tom Stellard <thomas.stellard@amd.com>
Date:   Fri Apr 10 17:07:16 2015 +0000

    radeon/llvm: Run LLVM's instruction combining pass

    This should improve code quality in general and will help with some
    future changes to how we emit kill instructions.

    shader-db shows a few regressions, but these don't seem to be the result
    of deficiencies in instcombine.  They're mostly caused by the scheduler
    making different decisions than before.

Unigine Valley quits saying -

Unhandled loop condition!
UNREACHABLE executed at SIAnnotateControlFlow.cpp:267!

Only tried my normal settings on valley which are

quality ultra + 8x AA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2734 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 283 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #1 from Tom Stellard <tstellar@gmail.com> ---
Could you run the program with the environment variable R600_DEBUG=ps,vs,gs and
post the output.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1113 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 317 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #2 from Andy Furniss <adf.lists@gmail.com> ---
Created attachment 115136
  --> https://bugs.freedesktop.org/attachment.cgi?id=115136&action=edit
valley with R600_DEBUG=ps,vs,gs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1303 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 290 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #3 from Grigori Goronzy <greg@chown.ath.cx> ---
Control flow annotation seems to choke on a predecessor with "undef" incoming
value, for some reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1132 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 436 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #4 from Grigori Goronzy <greg@chown.ath.cx> ---
Created attachment 115333
  --> https://bugs.freedesktop.org/attachment.cgi?id=115333&action=edit
Reduced test case

Here's a reduced testcase. I'm not sure how undef branch conditions are
supposed to be handled, make someone else can take a look?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1480 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 280 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #5 from Michel Dänzer <michel@daenzer.net> ---
If this can't be fixed soon, maybe the bisected change should be reverted for
now?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1132 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 379 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #6 from Grigori Goronzy <greg@chown.ath.cx> ---
Created attachment 115401
  --> https://bugs.freedesktop.org/attachment.cgi?id=115401&action=edit
Possible fix

How about this? Not tested yet, I don't have access to a radeon GPU right now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1413 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 406 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #7 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Grigori Goronzy from comment #6)
> Created attachment 115401 [details] [review]
> Possible fix
> 
> How about this? Not tested yet, I don't have access to a radeon GPU right
> now.

It doesn't help valley.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1583 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 289 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #8 from Tom Stellard <tstellar@gmail.com> ---
Does this patch help:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150202/257738.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1214 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 598 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #9 from Grigori Goronzy <greg@chown.ath.cx> ---
Created attachment 115409
  --> https://bugs.freedesktop.org/attachment.cgi?id=115409&action=edit
Full shader

That does not help either. Seems to break the SSA somehow. Full shader that
triggers the bug attached.

The patch I posted earlier help with the the reduced testcase, but not with the
full shader. Both undef incoming values in phi nodes and undef branch
conditions cause problems in different ways.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1630 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 939 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #10 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Grigori Goronzy from comment #9)
> Created attachment 115409 [details] [review]
> Full shader
> 
> That does not help either. Seems to break the SSA somehow. Full shader that
> triggers the bug attached.
> 
> The patch I posted earlier help with the the reduced testcase, but not with
> the full shader. Both undef incoming values in phi nodes and undef branch
> conditions cause problems in different ways.

With the second patch + valley I get -

valley_x64: LiveVariables.cpp:114: void
llvm::LiveVariables::MarkVirtRegAliveInBlock(llvm::LiveVariables::VarInfo &,
llvm::MachineBasicBlock *, llvm::MachineBasicBlock *,
std::vector<MachineBasicBlock *> &): Assertion `MBB != &MF->front() && "Can't
find reaching def for virtreg"' failed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2166 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 303 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #11 from Tom Stellard <tstellar@gmail.com> ---
Created attachment 115423
  --> https://bugs.freedesktop.org/attachment.cgi?id=115423&action=edit
Reduced test case

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1346 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1108 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #12 from Tom Stellard <tstellar@gmail.com> ---
(In reply to Andy Furniss from comment #10)
> (In reply to Grigori Goronzy from comment #9)
> > Created attachment 115409 [details] [review] [review]
> > Full shader
> > 
> > That does not help either. Seems to break the SSA somehow. Full shader that
> > triggers the bug attached.
> > 
> > The patch I posted earlier help with the the reduced testcase, but not with
> > the full shader. Both undef incoming values in phi nodes and undef branch
> > conditions cause problems in different ways.
> 
> With the second patch + valley I get -
> 
> valley_x64: LiveVariables.cpp:114: void
> llvm::LiveVariables::MarkVirtRegAliveInBlock(llvm::LiveVariables::VarInfo &,
> llvm::MachineBasicBlock *, llvm::MachineBasicBlock *,
> std::vector<MachineBasicBlock *> &): Assertion `MBB != &MF->front() &&
> "Can't find reaching def for virtreg"' failed.

Did test with only the patch from comment #8 or did you test with both patches?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2467 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1265 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #13 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Tom Stellard from comment #12)
> (In reply to Andy Furniss from comment #10)
> > (In reply to Grigori Goronzy from comment #9)
> > > Created attachment 115409 [details] [review] [review] [review]
> > > Full shader
> > > 
> > > That does not help either. Seems to break the SSA somehow. Full shader that
> > > triggers the bug attached.
> > > 
> > > The patch I posted earlier help with the the reduced testcase, but not with
> > > the full shader. Both undef incoming values in phi nodes and undef branch
> > > conditions cause problems in different ways.
> > 
> > With the second patch + valley I get -
> > 
> > valley_x64: LiveVariables.cpp:114: void
> > llvm::LiveVariables::MarkVirtRegAliveInBlock(llvm::LiveVariables::VarInfo &,
> > llvm::MachineBasicBlock *, llvm::MachineBasicBlock *,
> > std::vector<MachineBasicBlock *> &): Assertion `MBB != &MF->front() &&
> > "Can't find reaching def for virtreg"' failed.
> 
> Did test with only the patch from comment #8 or did you test with both
> patches?

Just #8 but I just tried with both and get the same fail.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2731 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 405 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

Tom Stellard <tstellar@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #115423|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1101 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 342 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #14 from Tom Stellard <tstellar@gmail.com> ---
Created attachment 115488
  --> https://bugs.freedesktop.org/attachment.cgi?id=115488&action=edit
Possible fix

Can you try this applying this patch only?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1375 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 358 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #15 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Tom Stellard from comment #14)
> Created attachment 115488 [details] [review]
> Possible fix
> 
> Can you try this applying this patch only?

This fixes it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1534 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 500 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

Tom Stellard <tstellar@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Tom Stellard <tstellar@gmail.com> ---
Fixed in llvm: r236306

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2061 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 714 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #17 from falaca@gmail.com ---
Since mesa 10.6 is going RC soon, what's going to happen with this feature? If
it remains enabled, and the fix isn't backported to llvm 3.6, this bug will end
up being present in a stable release (unless llvm 3.7 is also going to be
released soon).

Fez is also affected by the same bug (I tested and verified that it is fixed by
the same patch), so there may be many more games affected:

Good (mesa 10.5): https://www.dropbox.com/s/h7qtlgln1xlnxrk/fez_good.png?dl=0
Bad (mesa 10.6): https://www.dropbox.com/s/f5yqqx2l6pz284z/fez_bad.png?dl=0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1719 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 90056] Unigine Valley regression since radeon/llvm: Run LLVM's instruction combining pass

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 840 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90056

--- Comment #18 from Tom Stellard <tstellar@gmail.com> ---
(In reply to Furkan from comment #17)
> Since mesa 10.6 is going RC soon, what's going to happen with this feature?
> If it remains enabled, and the fix isn't backported to llvm 3.6, this bug
> will end up being present in a stable release (unless llvm 3.7 is also going
> to be released soon).
> 
> Fez is also affected by the same bug (I tested and verified that it is fixed
> by the same patch), so there may be many more games affected:
> 
> Good (mesa 10.5): https://www.dropbox.com/s/h7qtlgln1xlnxrk/fez_good.png?dl=0
> Bad (mesa 10.6): https://www.dropbox.com/s/f5yqqx2l6pz284z/fez_bad.png?dl=0

This bug will be fixed in the LLVM 3.6.1 release.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1968 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel