[Bug 90888] New: A trivial fix for a potential crash

[Bug 90888] New: A trivial fix for a potential crash

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1033 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90888

            Bug ID: 90888
           Summary: A trivial fix for a potential crash
           Product: Mesa
           Version: git
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: medium
         Component: Drivers/DRI/nouveau
          Assignee: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
          Reporter: j-r-BGeptl67XyCzQB+pC5nmwQ@public.gmane.org
        QA Contact: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org

Created attachment 116340
  --> https://bugs.freedesktop.org/attachment.cgi?id=116340&action=edit
Candidate patch

OP_JOIN are static casted to FlowInstruction, but handleTXL creates OP_JOIN
that is no FlowInstruction.

It probably doesn't matter outside debug builds, since only the IR printer
seems to access the additional FlowInstruction fields.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2376 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 90888] A trivial fix for a potential crash

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 666 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90888

--- Comment #1 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
Great patch. Please mail it out to nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, these things
are usually just done over email when there's no real bug to keep track of. One
small thing is I normally use "nv50/ir" prefix when modifying stuff in codegen.

I'm away from computers where I can check this out for another week or so, but
I'll be able to take a detailed look then. [And your other bug too.]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1436 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 90888] A trivial fix for a potential crash

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 957 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=90888

Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
Hrmph.... one small difference is that mkOp() appears to set the instruction
with ->fixed = 1. I'm adding that in just in case it mattered in this case...
Converter::insertConvergenceOps seems to do this too. Now pushed. In the
future, you can just mail patches to nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org and/or
mesa-dev-PD4FTy7X32lNgt0PjOBp9xlNPtJONSTn@public.gmane.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2410 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau