[Bug 93178] Textures are filled with garbage

[Bug 93178] Textures are filled with garbage

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1445 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93178

            Bug ID: 93178
           Summary: Textures are filled with garbage
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: joseph.kucia@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 120218
  --> https://bugs.freedesktop.org/attachment.cgi?id=120218&action=edit
Frame 1 rendered on Radeonsi

The following apitrace renders garbage (see the attached screenshot) when
replayed on radeonsi. The same apitrace is rendered correctly on nouveau and
nvidia. The cause of the problem seems to be textures filled with garbage.

apitrace: https://drive.google.com/file/d/0Bz0HXJUyjAh3Z0Z2SW9tNUJ3bXM/view

OpenGL vendor string: X.Org
OpenGL renderer string: Gallium 0.4 on AMD CAPE VERDE (DRM 2.43.0, LLVM 3.8.0)
OpenGL core profile version string: 4.1 (Core Profile) Mesa
11.2.0-devel (git-2571a76)
OpenGL core profile shading language version string: 4.10
OpenGL core profile context flags: (none)

AMD Radeon R9 M375

04:00.0 Display controller: Advanced Micro Devices, Inc. [AMD/ATI]
Venus XTX [Radeon HD 8890M / R9 M275X/M375X] (rev ff)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2958 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93178] Textures are filled with garbage

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 414 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93178

Ilia Mirkin <imirkin@alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #120218|text/plain                  |image/png
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1047 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93178] Textures are filled with garbage

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 369 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93178

--- Comment #1 from Józef Kucia <joseph.kucia@gmail.com> ---
Created attachment 120219
  --> https://bugs.freedesktop.org/attachment.cgi?id=120219&action=edit
The expected image to be rendered for frame 1 in the attached apitrace

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1355 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93178] Textures are filled with garbage

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 967 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93178

--- Comment #2 from Michel Dänzer <michel@daenzer.net> ---
Replaying the trace on radeonsi generates lots of GL API errors:

Mesa: User error: GL_INVALID_FRAMEBUFFER_OPERATION in glClear(incomplete
framebuffer)
Mesa: User error: GL_INVALID_FRAMEBUFFER_OPERATION in glDrawArrays(incomplete
framebuffer)
Mesa: 1 similar GL_INVALID_FRAMEBUFFER_OPERATION errors
(repeated several times)

Mesa: User error: GL_INVALID_ENUM in
glRenderbufferStorage(internalFormat=GL_SLUMINANCE8)
Mesa: User error: GL_INVALID_ENUM in
glRenderbufferStorage(internalFormat=GL_SLUMINANCE8_ALPHA8)

(the first three lines repeated several times again)

I think those errors could explain the incorrect rendering. Which driver was
the apitrace captured with? Does the same problem occur when running the
application with radeonsi directly?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1719 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93178] Textures are filled with garbage

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 854 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93178

--- Comment #3 from Józef Kucia <joseph.kucia@gmail.com> ---
(In reply to Michel Dänzer from comment #2)
> Replaying the trace on radeonsi generates lots of GL API errors:
>
> I think those errors could explain the incorrect rendering. Which driver was
> the apitrace captured with? Does the same problem occur when running the
> application with radeonsi directly?

The GL errors should not be related. Those are generated by format support
detection code.

This particular apitrace was captured with nouveau. The application generates
different GL errors in this part of code when run with radeonsi. However, it
exhibits exactly the same problem when run directly. I'll upload another
apitrace later.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1718 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93178] Textures are filled with garbage

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 409 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93178

--- Comment #4 from Józef Kucia <joseph.kucia@gmail.com> ---
https://drive.google.com/file/d/0Bz0HXJUyjAh3ZkFEOHdNVnAyWWM/view

This apitrace was captured with radeonsi. It is not trimmed. The problem
appears at 935th frame. The previous frames are rendered correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1243 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93178] Textures are filled with garbage

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 445 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93178

Józef Kucia <joseph.kucia@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|Other                       |x86-64 (AMD64)
                 OS|All                         |Linux (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1235 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93178] Textures are filled with garbage

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1788 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93178

Nicolai Hähnle <nhaehnle@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTOURBUG
             Status|NEW                         |RESOLVED

--- Comment #5 from Nicolai Hähnle <nhaehnle@gmail.com> ---
This is a game bug.

The game tries to be clever by uploading some of its textures from a different
OpenGL context, but never uses any kind of synchronization between the texture
upload and the main context, so the texture upload never actually happens. This
is a serious programming mistake, and it is merely by chance that this works on
other drivers.

For your own purposes, you can work around the game bug in the driver by
applying the following patch:

---- SNIP ----
--- a/src/gallium/drivers/radeon/r600_texture.c
+++ b/src/gallium/drivers/radeon/r600_texture.c
@@ -105,6 +105,7 @@ static void r600_copy_from_staging_texture(struct
pipe_context *ctx, struct r600
        rctx->dma_copy(ctx, dst, transfer->level,
                       transfer->box.x, transfer->box.y, transfer->box.z,
                       src, 0, &sbox);
+       rctx->b.flush(&rctx->b, NULL, 0);
 }

 static unsigned r600_texture_get_offset(struct r600_texture *rtex, unsigned
level,
---- SNIP ----

However, doing this seriously hurts the performance of games that are
programmed properly. I encourage you to forward this message to the developers,
telling them they should take a look at Section 5.3.1 of the OpenGL 4.5
(Compatibility Profile) specification, specifically the part about using Finish
or FenceSync/WaitSync.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3259 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 93178] Textures are filled with garbage

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 708 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93178

Józef Kucia <joseph.kucia@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Józef Kucia <joseph.kucia@gmail.com> ---
(In reply to Nicolai Hähnle from comment #5)
> This is a game bug.

Thanks for debugging this. I am sorry for reporting invalid bug. This is
actually a bug in Wine. For now the workaround is to enable StrictDrawOrdering.
I will do more investigation before reporting a bug next time.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2093 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel