All of lore.kernel.org
 help / color / mirror / Atom feed
* [Bug 93761] A conditional discard in a fragment shader causes no depth writing at all
@ 2016-01-18 18:08 bugzilla-daemon
  2016-01-19 16:02 ` bugzilla-daemon
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: bugzilla-daemon @ 2016-01-18 18:08 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 1575 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93761

            Bug ID: 93761
           Summary: A conditional discard in a fragment shader causes no
                    depth writing at all
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: jlegg@feralinteractive.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 121116
  --> https://bugs.freedesktop.org/attachment.cgi?id=121116&action=edit
Test case

When rendering to an FBO with only a GL_DEPTH_COMPONENT16 depth buffer, with
depth testing enabled, if a fragment shader has a conditional discard, nothing
is written to the depth buffer for pixels which should not be discarded.

Platform: Fedora 22 x86_64
Mesa version: tested both git eaf7ec9 (from griever-mesa-git copr) and 10.6.9
(the default mesa package with Fedora 22). The bug occurred on both.
GL Renderer string: Gallium 0.4 on AMD PITCAIRN (DRM 2.43.0, LLVM 3.7.1)
GPU: AMD R9 270 with 2GB VRAM

Workaround: If you write to gl_FragDepth, only the intentionally discarded
pixels are discarded.

I've attached a test case demonstrating the problem. It will fail an assertion
on the machine with this bug. It should draw only on the even columns of pixels
in the depth buffer, but nothing is drawn.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2991 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug 93761] A conditional discard in a fragment shader causes no depth writing at all
  2016-01-18 18:08 [Bug 93761] A conditional discard in a fragment shader causes no depth writing at all bugzilla-daemon
@ 2016-01-19 16:02 ` bugzilla-daemon
  2016-01-19 20:21 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2016-01-19 16:02 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 337 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93761

--- Comment #1 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Hi James, bug reports with attached test cases are awesome :)
I can confirm the problem with latest Mesa and LLVM master and am going to
investigate.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1151 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug 93761] A conditional discard in a fragment shader causes no depth writing at all
  2016-01-18 18:08 [Bug 93761] A conditional discard in a fragment shader causes no depth writing at all bugzilla-daemon
  2016-01-19 16:02 ` bugzilla-daemon
@ 2016-01-19 20:21 ` bugzilla-daemon
  2016-02-25 11:54 ` bugzilla-daemon
  2016-02-25 14:11 ` bugzilla-daemon
  3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2016-01-19 20:21 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 247 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93761

--- Comment #2 from Nicolai Hähnle <nhaehnle@gmail.com> ---
Here's a fix: http://patchwork.freedesktop.org/patch/71068/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1121 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug 93761] A conditional discard in a fragment shader causes no depth writing at all
  2016-01-18 18:08 [Bug 93761] A conditional discard in a fragment shader causes no depth writing at all bugzilla-daemon
  2016-01-19 16:02 ` bugzilla-daemon
  2016-01-19 20:21 ` bugzilla-daemon
@ 2016-02-25 11:54 ` bugzilla-daemon
  2016-02-25 14:11 ` bugzilla-daemon
  3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2016-02-25 11:54 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 586 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93761

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Marek Olšák <maraeo@gmail.com> ---
Fixed by this commit:
https://cgit.freedesktop.org/mesa/mesa/commit/?id=8667a1aea2ac3fee9b1b663132dc1bea8ec21cda

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2222 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug 93761] A conditional discard in a fragment shader causes no depth writing at all
  2016-01-18 18:08 [Bug 93761] A conditional discard in a fragment shader causes no depth writing at all bugzilla-daemon
                   ` (2 preceding siblings ...)
  2016-02-25 11:54 ` bugzilla-daemon
@ 2016-02-25 14:11 ` bugzilla-daemon
  3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2016-02-25 14:11 UTC (permalink / raw)
  To: dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 367 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=93761

James Legg <jlegg@feralinteractive.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1098 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-02-25 14:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-18 18:08 [Bug 93761] A conditional discard in a fragment shader causes no depth writing at all bugzilla-daemon
2016-01-19 16:02 ` bugzilla-daemon
2016-01-19 20:21 ` bugzilla-daemon
2016-02-25 11:54 ` bugzilla-daemon
2016-02-25 14:11 ` bugzilla-daemon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.