[Bug 96835] "gallium: Force blend color to 16-byte alignment" crash with "-march=native -O3" causes some 32bit games to crash

[Bug 96835] "gallium: Force blend color to 16-byte alignment" crash with "-march=native -O3" causes some 32bit games to crash

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1312 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96835

            Bug ID: 96835
           Summary: "gallium: Force blend color to 16-byte alignment"
                    crash with "-march=native -O3" causes some 32bit games
                    to crash
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: raffarti@zoho.com
        QA Contact: dri-devel@lists.freedesktop.org

Building mesa with "-march=native -O3" causes some 32 bit games to crash at
start since "gallium: Force blend color to 16-byte alignment" patch
(d8d6091a846ac2a40a011d512d6d57f6c8442e6a). This happens using both opengl or
nine. Everything works as expected using "-march=native -O2".
tested games are:
Native:
The Talos Princible (32 bit) -- Always crash
The Talos Princible (64 bit) -- Works
Wine (32bit):
League of Legends -- Always crash
World of Warcraft 1.21 -- Always crash
World of Warcraft 2.4.3 -- Sometimes crashes
World of Warcraft 3.3.5 -- Most times works

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2778 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96835] "gallium: Force blend color to 16-byte alignment" crash with "-march=native -O3" causes some 32bit games to crash

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 495 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96835

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chuck.atkins@kitware.com

--- Comment #1 from Michel Dänzer <michel@daenzer.net> ---
Please attach a gdb backtrace of a crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2074 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96835] "gallium: Force blend color to 16-byte alignment" crash with "-march=native -O3" causes some 32bit games to crash

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 327 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96835

--- Comment #2 from raffarti@zoho.com ---
Created attachment 124940
  --> https://bugs.freedesktop.org/attachment.cgi?id=124940&action=edit
steam gdb backtrace

Steam crashes (it's 32 bit)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1382 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96835] "gallium: Force blend color to 16-byte alignment" crash with "-march=native -O3" causes some 32bit games to crash

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 410 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96835

--- Comment #3 from Nicolai Hähnle <nhaehnle@gmail.com> ---
The backtrace looks completely unrelated to the commit you cite. Why do you
think that this particular commit is at fault?

Just to be sure, could you please provide a backtrace with debug symbols
enabled (-g)?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1361 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96835] "gallium: Force blend color to 16-byte alignment" crash with "-march=native -O3" causes some 32bit games to crash

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 335 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96835

--- Comment #4 from raffarti@zoho.com ---
The previous commit does just fine, this one does not.
I've found the traces to be different with and without the gallium hud, so I'm
attaching both traces.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1260 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96835] "gallium: Force blend color to 16-byte alignment" crash with "-march=native -O3" causes some 32bit games to crash

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 330 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96835

--- Comment #5 from raffarti@zoho.com ---
Created attachment 124947
  --> https://bugs.freedesktop.org/attachment.cgi?id=124947&action=edit
steam gdb stack trace with gallium hud and mesa debug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1453 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96835] "gallium: Force blend color to 16-byte alignment" crash with "-march=native -O3" causes some 32bit games to crash

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 333 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96835

--- Comment #6 from raffarti@zoho.com ---
Created attachment 124948
  --> https://bugs.freedesktop.org/attachment.cgi?id=124948&action=edit
steam gdb stack trace without gallium hud and mesa debug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1462 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96835] "gallium: Force blend color to 16-byte alignment" crash with "-march=native -O3" causes some 32bit games to crash

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 663 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96835

--- Comment #7 from Roland Scheidegger <sroland@vmware.com> ---
On second look, I am actually wondering if that commit really is doing the
right thing. Shouldn't we try to set the alignment on the struct itself
instead? And regardless, if someone uses an ordinary malloc for it it's not
going to be aligned anyway (meaning if it's passed to drivers somewhere and the
called functions are relying on this to be aligned they might be in for some
surprise).

(That said I have no idea if this is really related to this bug.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1617 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 96835] "gallium: Force blend color to 16-byte alignment" crash with "-march=native -O3" causes some 32bit games to crash

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1264 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=96835

Nicolai Hähnle <nhaehnle@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
                   |.org                        |org
          Component|Drivers/Gallium/radeonsi    |Mesa core
           Assignee|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
                   |.org                        |org

--- Comment #8 from Nicolai Hähnle <nhaehnle@gmail.com> ---
(The Gallium HUD crash is "benign": you enabled more graphs than there are
pre-defined colors. Annoying, but unrelated to the problem at hand.)

My understanding is that malloc should return pointers with the largest
alignment requirement possible for the size that it allocates. Although,
perhaps that's less than 16 bytes on 32 bits?

Actually, I think that's it: the backtrace shows ctx=0x569cbfc8, i.e. ctx is
only 8-byte aligned even though it contains a pipe_blend_color structure.

Moving to Mesa core since it's not really radeonsi-specific.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3053 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel