[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1454 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

            Bug ID: 97029
           Summary: cik_sdma_copy_texture broken on Carrizo (mesa 12)
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: darktjm@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 125240
  --> https://bugs.freedesktop.org/attachment.cgi?id=125240&action=edit
xwd output with bug

Mesa 12 corrupts large image displays in X on my hardware, using
xf86-video-amdgpu 1.1.0 (glamor).  To reproduce, xwd | xwud.  The xwd capture
is garbled (see attached), and xwud sprays the garbled mess in disconnected
chunks to its right.  I noticed this in pre-12 git as well, but didn't report
because I have limited net access and limited machine availability and hoped
someone better equipped would discover and deal with it.  The commit which
caused this is 70934de00eb42ba6fc43d104875962dfb260a1b3.  Removing the call to
cik_sdma_copy_texture "fixes" it.  This was observed on two different machines,
but similar hardware (A10 Carrizo).  Verfied still broken as of
4f89cf4941db0a5cd8a85b943121840000cf8e4f.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2968 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 346 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

--- Comment #1 from Nicolai Hähnle <nhaehnle@gmail.com> ---
This could be related to the GPUVM faults discussed in this mailing list
thread: https://lists.freedesktop.org/archives/amd-gfx/2016-June/000047.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1212 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 325 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

--- Comment #2 from Franklin Titus <cygnix@openmailbox.org> ---
Created attachment 125260
  --> https://bugs.freedesktop.org/attachment.cgi?id=125260&action=edit
distorted screenshot image

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1255 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 303 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

--- Comment #3 from Franklin Titus <cygnix@openmailbox.org> ---
I have similar issue since upgrading to Mesa 12 on the same AMD hardware (A10
Carrizo). See attachment.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1089 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1036 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

--- Comment #4 from Thomas J. Moore <darktjm@gmail.com> ---
Created attachment 125266
  --> https://bugs.freedesktop.org/attachment.cgi?id=125266&action=edit
xwud results

Sorry for the poor quality, late posting, and the reflections in the image. 
This is what the xwud output looks like.  Notice the perfectly fine rxvt on the
left (except for the blue crap in it; that was caused by xwud).  The window in
the middle is where xwud is supposed to put its output.  Instead, it lays wide
stripes to its right (far enough to reach around back to the left).  Looks a
lot like the stride and offset are wrong, but it also corrupts pixels in the
top button bar.  Also, I wanted to make it clear that this affects xv,
ImageMagick-display, xpdf, and many other apps, not just some ancient screen
capture program.  The only thing keeping this from being a "major" issue is
that it's easy to cure.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1944 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 570 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |johannes.hirte@datenkhaos.d
                   |                            |e

--- Comment #5 from Michel Dänzer <michel@daenzer.net> ---
*** Bug 97119 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2041 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 591 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

--- Comment #6 from Johannes Hirte <johannes.hirte@datenkhaos.de> ---
Additional info here, as 97119 is a duplicate of this. The flickering happens
even with R600_DEBUG=nodma. I don't even need to put the video to fullscreen.
This time flickering was just starting with the video. I've seen similar
flickering on a kabini system. Don't know, if this could be related. I've never
seen this on r600 systems (cedar, sumo), so I don't think it's a KDE bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1383 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 310 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

--- Comment #7 from Marek Olšák <maraeo@gmail.com> ---
Do you have the latest amdgpu firmware from
http://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1175 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1455 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

Thomas J. Moore <darktjm@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #8 from Thomas J. Moore <darktjm@gmail.com> ---
(In reply to Marek Olšák from comment #7)
> Do you have the latest amdgpu firmware from
> http://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git ?

Do you know of a specific change to a carrizo firmware image that fixes this
bug?  Because if not, I will not spend effort updating it.  A check against the
current git head shows that I am not running the latest carrizo_vce.bin, but
all others are up-to-date (including the ones suspiciously containing "sdma" in
the name).  Unless you can verify that the vce image will magically fix this, I
won't try it until it gets included in an official gentoo linux-firmware
update.  Even if it is a firmware revision issue, there should be barrier code
in the function to prevent old firmware from screwing up.

In the mean time, I strongly suggest disabling this function call entirely
before releasing yet another broken Mesa.  Having random memory copies spray
bytes all over the place based on size and alignment is completely
unacceptable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2936 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 357 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

--- Comment #9 from Marek Olšák <maraeo@gmail.com> ---
If I had known about the issue, we wouldn't have committed the change.

Right now the plan is to disable SDMA texture copying for Carrizo on master and
Mesa 12.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1136 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 539 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

--- Comment #10 from Thomas J. Moore <darktjm@gmail.com> ---
(In reply to Marek Olšák from comment #9)
> Right now the plan is to disable SDMA texture copying for Carrizo on master
> and Mesa 12.0.

Fine by me.  Just wanted to make sure it was taken care of before the next Mesa
release, in case you decide to wait more than a month to respond again, given
approx. 2 months between Mesa releases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1395 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 473 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

--- Comment #11 from Michel Dänzer <michel@daenzer.net> ---
(In reply to Johannes Hirte from comment #6)
> The flickering happens even with R600_DEBUG=nodma.

The flickering should be tracked separately from this report then. Feel free to
re-open bug 97119 for that, but you'll need to provide more information about
the flickering.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1521 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97029] cik_sdma_copy_texture broken on Carrizo (mesa 12)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 591 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97029

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Marek Olšák <maraeo@gmail.com> ---
SDMA texture copying was disabled on Carrizo by:
3ff0b67e1b6b492d5793c1580f4be0c6f58a1bc2

Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2084 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel