[Bug 97504] Enabling SDMA on CIK (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes corruption on a mobile Bonaire with AMDGPU DDX / video desktop recording

[Bug 97504] Enabling SDMA on CIK (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes corruption on a mobile Bonaire with AMDGPU DDX / video desktop recording

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1516 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97504

            Bug ID: 97504
           Summary: Enabling SDMA on CIK
                    (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes
                    corruption on a mobile Bonaire with AMDGPU DDX / video
                    desktop recording
           Product: DRI
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: shawn.starr@rogers.com

With latest agd5f drm-fixes-4.8 / drm-next-4.9-wip + Linus master kernel:

Latest git mesa master with SDMA enabled on CIK patch:

1) AMDGPU DDX shows squared corruption, X locks up
2) Using vlc desktop recording / vokoscreen desktop recording get corrupted
video recording

Kernel spits out GPUVPM faults:

[ 6612.359198] amdgpu 0000:01:00.0: GPU fault detected: 146 0x0248770c
[ 6612.359199] amdgpu 0000:01:00.0:   VM_CONTEXT1_PROTECTION_FAULT_ADDR  
0x0010C836
[ 6612.359199] amdgpu 0000:01:00.0:   VM_CONTEXT1_PROTECTION_FAULT_STATUS
0x0807700C
[ 6612.359200] VM fault (0x0c, vmid 4) at page 1099830, read from 'SDM0'
(0x53444d30) (119)

  Revert "radeonsi: enable SDMA on CIK"

    This reverts commit 0241d8300f66ee2c6c2c55fe64ac88d76440c591.


When reverted problems go away.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2854 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97504] Enabling SDMA on CIK (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes corruption on a mobile Bonaire with AMDGPU DDX / video desktop recording

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 632 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97504

Shawn Starr <shawn.starr@rogers.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |dri-devel@lists.freedesktop
                   |                            |.org
            Version|unspecified                 |git
            Product|DRI                         |Mesa
          Component|DRM/AMDgpu                  |Drivers/Gallium/radeonsi

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1739 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97504] Enabling SDMA on CIK (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes corruption on a mobile Bonaire with AMDGPU DDX / video desktop recording

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 303 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97504

--- Comment #1 from Vedran Miletić <vedran@miletic.net> ---
It's a long shot, but does
https://lists.freedesktop.org/archives/mesa-dev/2016-August/127318.html fix it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1360 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97504] Enabling SDMA on CIK (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes corruption on a mobile Bonaire with AMDGPU DDX / video desktop recording

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 547 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97504

--- Comment #2 from Luke A. Guest <laguest@archeia.com> ---
(In reply to Vedran Miletić from comment #1)
> It's a long shot, but does
> https://lists.freedesktop.org/archives/mesa-dev/2016-August/127318.html fix
> it?

I can confirm on R9 390, this patch stops the GPU page faults in dmesg log, but
I'm still getting major corruption when recording the screen in obs or ffmeg
https://youtu.be/pFqhIGYLbDM

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1722 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97504] Enabling SDMA on CIK (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes corruption on a mobile Bonaire with AMDGPU DDX / video desktop recording

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 367 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97504

--- Comment #3 from Shawn Starr <shawn.starr@rogers.com> ---
Revert this patch to fix VDPAU corruption:

"radeonsi: increase performance for DRI PRIME offloading if 2nd GPU is CIK or
VI"
5ee3cac1380fec6971e9d25267589a586da0ecd8.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1348 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97504] Enabling SDMA on CIK (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes corruption on a mobile Bonaire with AMDGPU DDX / video desktop recording

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 670 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97504

--- Comment #4 from Luke A. Guest <laguest@archeia.com> ---
(In reply to Shawn Starr from comment #3)
> Revert this patch to fix VDPAU corruption:
> 
> "radeonsi: increase performance for DRI PRIME offloading if 2nd GPU is CIK
> or VI"
> 5ee3cac1380fec6971e9d25267589a586da0ecd8.

I reverted this, rebuilt mesa, ran the ffmpeg command, played it back, the
first 4 seconds is corrupt in the same way as before, then it's fine.

Rebuilt obs-studio, the window now shows an uncorrupted screen! REbuilt ffmpeg
and no corruption.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1732 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97504] Enabling SDMA on CIK (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes corruption on a mobile Bonaire with AMDGPU DDX / video desktop recording

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 276 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97504

--- Comment #5 from Luke A. Guest <laguest@archeia.com> ---
I can also confirm that the pagefaults above are back with this patch
reversion.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1246 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97504] Enabling SDMA on CIK (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes corruption on a mobile Bonaire with AMDGPU DDX / video desktop recording

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 517 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97504

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kai@dev.carbon-project.org

--- Comment #6 from Michel Dänzer <michel@daenzer.net> ---
*** Bug 97610 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2340 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97504] Enabling SDMA on CIK (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes corruption on a mobile Bonaire with AMDGPU DDX / video desktop recording

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1121 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97504

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Michel Dänzer <michel@daenzer.net> ---
This issue wasn't limited to mobile Bonaire. One interesting hint from bug
97610 is that it works fine with the radeon kernel driver, so maybe it's
related to addrlib or the amdgpu winsys.

Anyway, fixed for now in Git master. Note that you need to start X with the
fixed Mesa, because it affects glamor as well.

Module: Mesa
Branch: master
Commit: 93f3d8e10d712336b86ebe17dafaee0aac7ec429
URL:   
http://cgit.freedesktop.org/mesa/mesa/commit/?id=93f3d8e10d712336b86ebe17dafaee0aac7ec429

Author: Marek Olšák <marek.olsak@amd.com>
Date:   Thu Sep  8 18:21:04 2016 +0200

Revert "radeonsi: enable SDMA on CIK"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3070 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97504] Enabling SDMA on CIK (0241d8300f66ee2c6c2c55fe64ac88d76440c591) causes corruption on a mobile Bonaire with AMDGPU DDX / video desktop recording

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1544 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97504

Kai <kai@dev.carbon-project.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

--- Comment #8 from Kai <kai@dev.carbon-project.org> ---
(In reply to Michel Dänzer from comment #7)
> This issue wasn't limited to mobile Bonaire. One interesting hint from bug
> 97610 is that it works fine with the radeon kernel driver, so maybe it's
> related to addrlib or the amdgpu winsys.
> 
> Anyway, fixed for now in Git master. Note that you need to start X with the
> fixed Mesa, because it affects glamor as well.
> 
> Module: Mesa
> Branch: master
> Commit: 93f3d8e10d712336b86ebe17dafaee0aac7ec429
> URL: <http://cgit.freedesktop.org/mesa/mesa/commit/?id=93f3d8e10d712336b86ebe17dafaee0aac7ec429>
> 
> Author: Marek Olšák <marek.olsak@amd.com>
> Date:   Thu Sep  8 18:21:04 2016 +0200
> 
> Revert "radeonsi: enable SDMA on CIK"

I can confirm this fixes the corruption I've reported in bug 97610.

Since Marek mentioned in the commit message of the revert, that it's maybe some
tile configuration issue, I was wondering if Tom was correct in bug 97610,
comment #1? Should I do the test – obviously with the revert undone – with the
tiling configurations copied from radeon (bug 97610, comment #2)? Or is this
something else?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 4184 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel