[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1319 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

            Bug ID: 97590
           Summary: Fury X (Fiji) LEDs do not reflect GPU load
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: boltronics@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Under Catalyst (fglrx) on Ubuntu 14.04, LEDs on Fury X graphics cards would
reflect the GPU load. This behaviour matches Windows. ie. Stand-by mode would
utilize a single green LED, low power would use one red LED, max power would
light up all 8 LEDs, etc. You can see this behaviour here:
https://www.youtube.com/watch?v=Evkk4HmjHOw

This helps give a nice immediate visual feedback showing what the cards are
actually doing, and can improve PC build aesthetics.

Since upgrading to AMDGPU + Mesa, all LEDs are permanently on, implying full
load (or maximum power draw?) at all times. Hopefully this is not what is
actually happening.

FWIW, the AMDGPU Pro stack also has this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2744 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 379 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #1 from John Bridgman <john.bridgman@amd.com> ---
There was a Phoronix article recently celebrating the addition of an LED driver
to the Nouveau driver... guessing that something similar will need to be done
for amdgpu eventually.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1149 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 314 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #2 from Adam Bolte <boltronics@gmail.com> ---
Ah yep. Found the article you were referring to.

http://www.phoronix.com/scan.php?page=news_item&px=Nouveau-LED-Driver

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1172 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 835 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #3 from Adam Bolte <abolte@systemsaviour.com> ---
Is it possible the driver code for the LED controller used by fglrx can be
released to get the ball rolling on this? Someone I should get in contact with
perhaps? Or is this actually being worked on (or at least scheduled to be
worked on) internally at AMD?

It's been almost six months since this regression was initially reported (I am
told the free software stack is the AMD-recommended upgrade path for consumers,
so I feel justified in calling it a regression from that perspective). I know
the AMD devs are busy people, but it would be great to see some progress on
this before the cards I purchased are eventually retired.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1605 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 333 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #4 from Alex Deucher <alexdeucher@gmail.com> ---
Created attachment 129828
  --> https://bugs.freedesktop.org/attachment.cgi?id=129828&action=edit
possible fix

Does this patch work?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1303 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 358 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #5 from Adam Bolte <abolte@systemsaviour.com> ---
Wow Alex - I wasn't expecting anything for months, let alone hours! Thanks!

I'll certainly be trying this out tonight and will report back as soon as I
know.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1128 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 638 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

Alex Deucher <alexdeucher@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #129828|0                           |1
        is obsolete|                            |

--- Comment #6 from Alex Deucher <alexdeucher@gmail.com> ---
Created attachment 129851
  --> https://bugs.freedesktop.org/attachment.cgi?id=129851&action=edit
possible fix

This should apply cleanly to upstream.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2120 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 374 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #7 from network723@rkmail.ru ---
AFAIK, Sapphire RX480/470 Nitro boards also have LEDs that change colors
depending on GPU Load / temperature (displaying mode can be switched with
hardware button). Would it work for them too?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1123 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 589 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #8 from Alex Deucher <alexdeucher@gmail.com> ---
(In reply to network723 from comment #7)
> AFAIK, Sapphire RX480/470 Nitro boards also have LEDs that change colors
> depending on GPU Load / temperature (displaying mode can be switched with
> hardware button). Would it work for them too?

No.  I don't see any relevant code for polaris.  Those may be some OEM specific
implementation handled independently of the driver.  Do they work?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1434 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1719 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #9 from Adam Bolte <abolte@systemsaviour.com> ---
I'm very excited to say that this patch is working great. Huge thanks! I know
it's crazy but there's something very satisfying about having the LEDs show
what the cards are doing. :)

I noticed attachment 129828 applies cleanly to 4.10 so I ended up using that. I
tried to test attachment 129851 but wasn't sure which repo/branch I was
supposed to apply it to. I tried
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git (master
branch) and git://people.freedesktop.org/~airlied/linux (drm-next branch) but
I'm clearly looking in the wrong place. Happy to re-test if you point me in the
right direction of the correct kernel source code to use.

Many games were tested (including a number under Wine with Gallium on Nine and
d3d9 patches). I only tested this against the free software stack so far. I
tested the Talos Principle (to test Vulkan), a bunch of Feral ports, etc. At
all times the first Fury X LEDs on the primary card would flicker in the same
way as they do under Windows, which is terrific.

The only difference between this patch and the Windows behaviour is with the
second card at idle - Windows will display only a single green LED which I
believe indicates the card is in its lowest power mode. I was unable to
reproduce that same status with your patch. However I'm guessing this means
Windows puts the unused card in to a lower power state than AMDGPU is currently
able, and the LEDs are actually doing the right thing. No big deal either way.

Thanks again Alex.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3048 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 665 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #10 from Adam Bolte <abolte@systemsaviour.com> ---
I found the repo (git://people.freedesktop.org/~agd5f/linux and the
drm-next-4.12-wip branch with the commit already applied), so I built that for
testing but didn't have any luck. The primary GPU LEDs were stuck on maximum,
the second was a single blue LED (as before), and I lost signal multiple times
when trying to log in through my display manager.

Probably some unrelated regression is affecting that branch, preventing my
testing of your revised patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1436 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 371 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #11 from Alex Deucher <alexdeucher@gmail.com> ---
Use whichever patch applies to your tree.  They are identical other than some
fuzz related to other changes in the same file depending on what kernel version
you are using.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1141 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 390 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #12 from Adam Bolte <abolte@systemsaviour.com> ---
Good to know it doesn't matter for testing purposes. In that case, I'm happy
for this to be marked as fixed - unless the policy on doing that is to wait
until the patch is accepted upstream?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1161 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 290 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #13 from Alex Deucher <alexdeucher@gmail.com> ---
I've queued the patch for upstream.  I'll close it once the patch makes it into
Linus' tree.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1060 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 772 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #14 from Vedran Miletić <vedran@miletic.net> ---
(In reply to Adam Bolte from comment #9)
> The only difference between this patch and the Windows behaviour is with the
> second card at idle - Windows will display only a single green LED which I
> believe indicates the card is in its lowest power mode. I was unable to
> reproduce that same status with your patch. However I'm guessing this means
> Windows puts the unused card in to a lower power state than AMDGPU is
> currently able, and the LEDs are actually doing the right thing. No big deal
> either way.

Alex, can you comment on this? Is it a known issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1630 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 955 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #15 from Alex Deucher <alexdeucher@gmail.com> ---
(In reply to Vedran Miletić from comment #14)
> (In reply to Adam Bolte from comment #9)
> > The only difference between this patch and the Windows behaviour is with the
> > second card at idle - Windows will display only a single green LED which I
> > believe indicates the card is in its lowest power mode. I was unable to
> > reproduce that same status with your patch. However I'm guessing this means
> > Windows puts the unused card in to a lower power state than AMDGPU is
> > currently able, and the LEDs are actually doing the right thing. No big deal
> > either way.
> 
> Alex, can you comment on this? Is it a known issue?

Windows powers down dGPUs when they are not in use.  This is not supported yet
in Linux outside of PX systems.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1883 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 271 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

--- Comment #16 from Adam Bolte <abolte@systemsaviour.com> ---
Looks like this patch has found its way into 4.12-rc1. Thanks again Alex.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1042 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97590] Fury X (Fiji) LEDs do not reflect GPU load

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 529 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97590

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #17 from Michel Dänzer <michel@daenzer.net> ---
Thanks for the report and testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2007 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel