[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 902 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97594

            Bug ID: 97594
           Summary: [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various
                    SI functions" breaks amdgpu support for SI
           Product: DRI
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: arek.rusi@gmail.com

Created attachment 126204
  --> https://bugs.freedesktop.org/attachment.cgi?id=126204&action=edit
dmesg for first bad commit

With this commit displays off during loading amdgpu, sysrq don't work, boot is
stopped. 
When i reverted it, amdgpu works as always.

dmesg is silent

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2389 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 319 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97594

--- Comment #1 from Arek Ruśniak <arek.rusi@gmail.com> ---
Created attachment 126205
  --> https://bugs.freedesktop.org/attachment.cgi?id=126205&action=edit
commit: deca1d1 reverted

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1355 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 489 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97594

--- Comment #2 from Arek Ruśniak <arek.rusi@gmail.com> ---
sorry for lack of description

It's Alex's drm-next-4.9-wip branch.

First bad commit: 
commit  deca1d1f16eebfa0d070eed50a221e01cf716ee0
author  Tom St Denis <tom.stdenis@amd.com>

drm/amd/amdgpu: Add GRBM lock to various SI functions
Add missing lock around SE/SH/INSTANCE selections.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1440 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 651 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97594

--- Comment #3 from Konstantin A. Lepikhov <lakostis@altlinux.org> ---
(In reply to Arek Ruśniak from comment #0)
> Created attachment 126204 [details]
> dmesg for first bad commit
> 
> With this commit displays off during loading amdgpu, sysrq don't work, boot
> is stopped. 
> When i reverted it, amdgpu works as always.
> 
> dmesg is silent

Same behavior but on PREEMPT kernel even without mentioned patch. Just to
clarify that it could be more general problem than locking in this particular
place.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1856 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 560 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97594

--- Comment #4 from Arek Ruśniak <arek.rusi@gmail.com> ---
Could you share config and patchset for your preempt kernel. If I will have
some time I could build it. I'm just curious.

I know nothing about what preempt is. I think I should rather call my kernel -
"generic" but "uname -a" gives me:
Linux darkfruit 4.8.0-rc1-20160904 #10 SMP PREEMPT Tue Sep 6 23:01:48 CEST 2016
x86_64 GNU/Linux
So I'm confused about it

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1476 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 464 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97594

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tom.stdenis@amd.com

--- Comment #5 from Michel Dänzer <michel@daenzer.net> ---
Tom, any ideas?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1962 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 470 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97594

--- Comment #6 from Tom St Denis <tom.stdenis@amd.com> ---
The problem is a double lock.  The grbm_idx_mutex lock is taken in
gfx_v6_0_get_cu_info() which then calls gfx_v6_0_get_cu_active_bitmap() which
also takes the lock.

The fix is to remove the lock and the select from the parent function.  I'll
attach a patch momentarily.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1365 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 470 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97594

--- Comment #7 from Tom St Denis <tom.stdenis@amd.com> ---
The problem is a double lock.  The grbm_idx_mutex lock is taken in
gfx_v6_0_get_cu_info() which then calls gfx_v6_0_get_cu_active_bitmap() which
also takes the lock.

The fix is to remove the lock and the select from the parent function.  I'll
attach a patch momentarily.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1365 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 427 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97594

--- Comment #8 from Tom St Denis <tom.stdenis@amd.com> ---
Created attachment 126274
  --> https://bugs.freedesktop.org/attachment.cgi?id=126274&action=edit
Patch to remove double lock

This removes the double lock.  It's actually patch #9 in my yet to be RB'ed
series of SI cleanups ...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1553 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 218 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97594

--- Comment #9 from Arek Ruśniak <arek.rusi@gmail.com> ---
Thx, works good for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1114 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97594] [amdgpu SI] "drm/amd/amdgpu: Add GRBM lock to various SI functions" breaks amdgpu support for SI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 436 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97594

Christian König <deathsimple@vodafone.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1327 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel