[Bug 97993] amdgpu_query_gpu_info () segfaults when user does not have permission to open /dev/dri/card*

[Bug 97993] amdgpu_query_gpu_info () segfaults when user does not have permission to open /dev/dri/card*

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 3984 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97993

            Bug ID: 97993
           Summary: amdgpu_query_gpu_info () segfaults when user does not
                    have permission to open /dev/dri/card*
           Product: DRI
           Version: unspecified
          Hardware: All
                OS: Linux (All)
            Status: NEW
          Severity: critical
          Priority: medium
         Component: DRM/AMDgpu-pro
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: vedran@miletic.net

$ gdb clinfo
GNU gdb (Ubuntu 7.11.1-0ubuntu1~16.04) 7.11.1
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from clinfo...(no debugging symbols found)...done.
(gdb) run
Starting program: /usr/bin/clinfo 
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff061bd22 in amdgpu_query_gpu_info () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libdrm_amdgpu.so.1
(gdb) backtrace
#0  0x00007ffff061bd22 in amdgpu_query_gpu_info () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libdrm_amdgpu.so.1
#1  0x00007ffff39d7fae in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#2  0x00007ffff39d861b in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#3  0x00007ffff39daceb in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#4  0x00007ffff39ca848 in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#5  0x00007ffff36bcf0b in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#6  0x00007ffff363e2d9 in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#7  0x00007ffff363e337 in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#8  0x00007ffff363f0c9 in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#9  0x00007ffff3605d48 in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#10 0x00007ffff36071e7 in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#11 0x00007ffff3607376 in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#12 0x00007ffff35c5300 in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#13 0x00007ffff35e0947 in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#14 0x00007ffff35aea03 in clIcdGetPlatformIDsKHR () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libamdocl64.so
#15 0x00007ffff74bd76e in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libOpenCL.so.1
#16 0x00007ffff74bf647 in ?? () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libOpenCL.so.1
#17 0x00007ffff7096ad9 in __pthread_once_slow (once_control=0x7ffff76c13d8,
init_routine=0x7ffff74bf4a0) at pthread_once.c:116
#18 0x00007ffff74bdd31 in clGetPlatformIDs () from
/usr/lib/x86_64-linux-gnu/amdgpu-pro/libOpenCL.so.1
#19 0x000000000040f4c7 in ?? ()
#20 0x0000000000407bb2 in ?? ()
#21 0x00007ffff6cdf830 in __libc_start_main (main=0x407b00, argc=1,
argv=0x7fffffffe4a8, init=<optimized out>, fini=<optimized out>,
rtld_fini=<optimized out>, stack_end=0x7fffffffe498) at ../csu/libc-start.c:291
#22 0x000000000040e5f1 in ?? ()

It should fail without segfault.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 5579 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97993] amdgpu_query_gpu_info () segfaults when user does not have permission to open /dev/dri/card*

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 386 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97993

--- Comment #1 from Vedran Miletić <vedran@miletic.net> ---
Still occurs with 16.40.

Simple test:

$ ls -la /dev/dri/* # verify that other does not have rwx
$ sudo chgrp root /dev/dri/* # or any group which the user is not a member of
$ clinfo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1255 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97993] amdgpu_query_gpu_info () segfaults when user does not have permission to open /dev/dri/card*

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 425 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97993

--- Comment #2 from Alex Deucher <alexdeucher@gmail.com> ---
Created attachment 127593
  --> https://bugs.freedesktop.org/attachment.cgi?id=127593&action=edit
possible fix

The patch should fix the acute problem, but may not fix the actual root cause
which is likely in the OCL driver.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97993] amdgpu_query_gpu_info () segfaults when user does not have permission to open /dev/dri/card*

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 489 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97993

--- Comment #3 from Vedran Miletić <vedran@miletic.net> ---
(In reply to Alex Deucher from comment #2)
> Created attachment 127593 [details] [review]
> possible fix
> 
> The patch should fix the acute problem, but may not fix the actual root
> cause which is likely in the OCL driver.

Thanks. I don't have time to test it now, but it looks good.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1704 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 97993] amdgpu_query_gpu_info () segfaults when user does not have permission to open /dev/dri/card*

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 430 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=97993

Alex Deucher <alexdeucher@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1301 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel