[Bug 98016] [bisected] Fury fails to boot since vce3: add support for third vce ring

[Bug 98016] [bisected] Fury fails to boot since vce3: add support for third vce ring

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1235 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

            Bug ID: 98016
           Summary: [bisected] Fury fails to boot since vce3: add support
                    for third vce ring
           Product: DRI
           Version: DRI git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: ernstp@gmail.com

Haven't been able to boot agd5f kernels for a while, did a big bisect today.
It came up with this commit:

commit 6f0359ff73076483902de0c17f9649bf55651e2a
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Wed Aug 24 17:15:33 2016 -0400

    drm/amdgpu/vce3: add support for third vce ring

    Not of much use at the moment (we don't really use
    the second ring either), but may be useful later.

    Reviewed-by: JimQu <Jim.Qu@amd.com>
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

[    16.822] (--) AMDGPU(0): Chipset: "FIJI" (ChipID = 0x7300)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2776 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot since vce3: add support for third vce ring

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 278 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #1 from Ernst Sjöstrand <ernstp@gmail.com> ---
The patch reverts cleanly on drm-next-4.9-wip and makes that branch bootable
also.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1106 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot since vce3: add support for third vce ring

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 413 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #2 from Ernst Sjöstrand <ernstp@gmail.com> ---
Wait, now I'm not so sure about the bisect.
Could there be a could/warm boot thing playing tricks with me?
Now I couldn't boot even with the patch reverted. But if I reboot from
a stable kernel quickly I can boot...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1241 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 787 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

Ernst Sjöstrand <ernstp@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[bisected] Fury fails to    |[bisected] Fury fails to
                   |boot since vce3: add        |boot on drm-next-4.9
                   |support for third vce ring  |

--- Comment #3 from Ernst Sjöstrand <ernstp@gmail.com> ---
This seems to be very hard to reproduce. Perhaps it's related to the kernel I'm
rebooting from or some complex combination.
Pretty hard to debug when the computer simply stops responding without any text
etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2051 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 716 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #4 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Ernst Sjöstrand from comment #3)
> This seems to be very hard to reproduce. Perhaps it's related to the kernel
> I'm rebooting from or some complex combination.
> Pretty hard to debug when the computer simply stops responding without any
> text etc.

Yea, it's tricky sometimes.

For my (I guess different) tonga start up issue I had to power down "properly"
between bisect steps. By properly I mean shutdown/halt then cut the power to
the PSU and wait a couple of minutes before powering up again.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1578 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 574 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #5 from Andy Furniss <adf.lists@gmail.com> ---
Also the way 4.9-wip changes and things get merged may not make bisecting a
long way back that easy compared to something like mesa.

I notice it's changed again 17 hours ago - it may even work now without you
being able to see any sign od a revert or fix in the history.

Maybe testing other branches (after power off of course) would give you a
better idea where you are.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1347 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 320 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #6 from Ernst Sjöstrand <ernstp@gmail.com> ---
Do you think I can get both false positives and false negatives?
Have tested a bit more but still behaving in a silly way...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1094 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 867 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #7 from Andy Furniss <adf.lists@gmail.com> ---
(In reply to Ernst Sjöstrand from comment #6)
> Do you think I can get both false positives and false negatives?
> Have tested a bit more but still behaving in a silly way...

I guess your issue not as clear cut as mine then.

If you find that you can sometimes boot and sometimes not on the same kernel
after power off, then that's going to be quite a pain and time consuming to
find.

It's not really normal to have to power off - I haven't needed to for ages,
just that with my recent boot up issue I knew I did need to as when I first
built it it worked from a reboot, but not the next day from off. I though your
issue may be similar, but apparently not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1713 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 464 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #8 from Ernst Sjöstrand <ernstp@gmail.com> ---
I have never been able to reproduce the problem with self-compiled 4.8-rc8 from
that workspace so I think my local builds are working at least.
drm/amd/amdgpu: enable clockgating only after late init
sounded like it could be similar to my problem but it didn't help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1238 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 408 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #9 from Ernst Sjöstrand <ernstp@gmail.com> ---
I know what may have been fooling me.
I run sudo make install on Ubuntu. It adds a .old entry in grub.
However that .old entry doesn't have a .old initrd, where the amdgpu kernel
module lives, it shares initrd.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1182 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 323 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #10 from Ernst Sjöstrand <ernstp@gmail.com> ---
Created attachment 127299
  --> https://bugs.freedesktop.org/attachment.cgi?id=127299&action=edit
Patch that fixes the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1329 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 820 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #11 from Alex Deucher <alexdeucher@gmail.com> ---
Odd.  We haven't seen any failures internally with Fiji and 3 VCE rings
enabled.  Can you provide a log of the failure?  Try manually loading amdgpu
after boot.  E.g., append modprobe.blacklist=amdgpu to the kernel command line
and boot to a non-X runlevel, then manually modprobe amdgpu and capture the
dmesg output. Please attach the dmesg output from a successful boot as well.  
If you have remote access via ssh, that would make it easier.  What VCE
firmware are you using?  Can you try the latest version from git and see if
that helps:
https://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1683 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 369 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #12 from Ernst Sjöstrand <ernstp@gmail.com> ---
Couldn't get anything after modprobe, the computer really dies.
However updating the firmware fixed it.

Should there be some kind of check or do you consider this fixed?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1144 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 282 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #13 from Ernst Sjöstrand <ernstp@gmail.com> ---
I was running the Ubuntu firmware from Xenial, the firmware bundled in Wily
fixed it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1057 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 472 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #14 from Alex Deucher <alexdeucher@gmail.com> ---
(In reply to Ernst Sjöstrand from comment #12)
> Couldn't get anything after modprobe, the computer really dies.
> However updating the firmware fixed it.
> 
> Should there be some kind of check or do you consider this fixed?

I'll add a check.  Thanks for confirming.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1328 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

--- Comment #15 from Alex Deucher <alexdeucher@gmail.com> ---
Created attachment 127542
  --> https://bugs.freedesktop.org/attachment.cgi?id=127542&action=edit
possible fix

Does this patch fix the issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1320 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98016] [bisected] Fury fails to boot on drm-next-4.9

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 429 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98016

Ernst Sjöstrand <ernstp@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1252 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel