[Bug 98518] [r600g, bisected] regression: NI/Turks MSAA texture corruption with FreeCAD and Wine games

[Bug 98518] [r600g, bisected] regression: NI/Turks MSAA texture corruption with FreeCAD and Wine games

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1462 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98518

            Bug ID: 98518
           Summary: [r600g, bisected] regression: NI/Turks MSAA texture
                    corruption with FreeCAD and Wine games
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r600
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: Dieter@nuetzel-hh.de
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 127646
  --> https://bugs.freedesktop.org/attachment.cgi?id=127646&action=edit
FreeCAD-MSAA-8x-Texure-Bug.png

It show up as texture corruption with FreeCAD (MSAA 8x context)
and under LS2015 (wine-1.9.21~gallium_nine+staging / MSAA 2+).

/opt/mesa> git bisect good
81a95946dab730c1cfcf04ac1373cea5f7908f65 is the first bad commit
commit 81a95946dab730c1cfcf04ac1373cea5f7908f65
Author: Marek Olšák <marek.olsak@amd.com>
Date:   Thu Oct 20 22:57:03 2016 +0200

    gallium/radeon: fold radeon_winsys::surface_best into radeon/winsys

    Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>

:040000 040000 2f6cc85574d5748ddd083215bca3a47496d58f3d
097994b4a81f267d45346adea94746745bb0085f M src

git revert 81a9594

will NOT work.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3125 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98518] [r600g, bisected] regression: NI/Turks MSAA texture corruption with FreeCAD and Wine games

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 337 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98518

--- Comment #1 from Dieter Nützel <Dieter@nuetzel-hh.de> ---
Created attachment 127647
  --> https://bugs.freedesktop.org/attachment.cgi?id=127647&action=edit
LS2015-Wine-nine-MSAA-2x+-Texure-Bug.png

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1375 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98518] [r600g, bisected] regression: NI/Turks MSAA texture corruption with FreeCAD and Wine games

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 692 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98518

--- Comment #2 from Dieter Nützel <Dieter@nuetzel-hh.de> ---
Fix is underway.

Have a look at Mesa-dev:
https://lists.freedesktop.org/archives/mesa-dev/2016-November/134137.html

src/gallium/winsys/radeon/drm/radeon_drm_surface.c

-    if (!(surf_ws->flags & RADEON_SURF_IMPORTED)) {
+    if (!(flags & (RADEON_SURF_IMPORTED | RADEON_SURF_FMASK))) {

A combination of Marek's idea plus Michel's patch
[Mesa-dev] [PATCH 3/4] gallium/radeon: Use flags parameter in
radeon_winsys_surface_init

SOLVED

both (FreeCAD and LS2015 on Wine) for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1657 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98518] [r600g, bisected] regression: NI/Turks MSAA texture corruption with FreeCAD and Wine games

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 280 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98518

--- Comment #3 from Marek Olšák <maraeo@gmail.com> ---
The fix has been pushed to master. Please test and close the bug if it's fixed.
Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1141 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98518] [r600g, bisected] regression: NI/Turks MSAA texture corruption with FreeCAD and Wine games

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 555 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98518

Dieter Nützel <Dieter@nuetzel-hh.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Dieter Nützel <Dieter@nuetzel-hh.de> ---
Fixed by git commit in master.
Closing.

Thanks Marek!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2180 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98518] [r600g, bisected] regression: NI/Turks MSAA texture corruption with FreeCAD and Wine games

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 373 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98518

Dieter Nützel <Dieter@nuetzel-hh.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1131 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel