* [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-24 17:33 ` Lee Jones
0 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Jonathan Cameron, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (25):
HID: intel-ish-hid: Remove unused variable 'err'
HID: ishtp-hid-client: Move variable to where it's actually used
HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
HID: intel-ish: Supply some missing param descriptions
HID: intel-ish: Fix a naming disparity and a formatting error
HID: usbhid: Repair a formatting issue in a struct description
HID: intel-ish-hid: Fix a little doc-rot
HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
HID: hid-alps: Correct struct misnaming
HID: intel-ish-hid: Fix potential copy/paste error
HID: hid-core: Fix incorrect function name in header
HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
header
HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
HID: hid-picolcd_core: Remove unused variable 'ret'
HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
abuses
HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
HID: hid-uclogic-params: Ensure function names are present and correct
in kernel-doc headers
HID: hid-sensor-custom: Remove unused variable 'ret'
HID: wacom_sys: Demote kernel-doc abuse
HID: hid-sensor-hub: Remove unused struct member 'quirks'
HID: hid-sensor-hub: Move 'hsdev' description to correct struct
definition
HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
drivers/hid/hid-alps.c | 2 +-
drivers/hid/hid-core.c | 2 +-
drivers/hid/hid-kye.c | 2 +-
drivers/hid/hid-logitech-hidpp.c | 7 +--
drivers/hid/hid-picolcd_core.c | 5 +--
drivers/hid/hid-sensor-custom.c | 5 +--
drivers/hid/hid-sensor-hub.c | 4 +-
drivers/hid/hid-thrustmaster.c | 24 +++++------
drivers/hid/hid-uclogic-params.c | 8 ++--
drivers/hid/hid-uclogic-rdesc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
drivers/hid/usbhid/hid-pidff.c | 4 +-
drivers/hid/usbhid/usbkbd.c | 2 +-
drivers/hid/wacom_sys.c | 2 +-
include/linux/intel-ish-client-if.h | 8 +++-
24 files changed, 90 insertions(+), 81 deletions(-)
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Anssi Hannula <anssi.hannula@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Drubin <daniel.drubin@intel.com>
Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-usb@vger.kernel.org
Cc: Lopez Casado <nlopezcasad@logitech.com>
Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
Cc: Masaki Ota <masaki.ota@jp.alps.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: message to <vojtech@ucw.cz>
Cc: Michael Haboustak <mike-@cinci.rr.com>
Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Cc: Zhang Lixu <lixu.zhang@intel.com>
--
2.27.0
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-24 17:33 ` Lee Jones
0 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Jonathan Cameron, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (25):
HID: intel-ish-hid: Remove unused variable 'err'
HID: ishtp-hid-client: Move variable to where it's actually used
HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
HID: intel-ish: Supply some missing param descriptions
HID: intel-ish: Fix a naming disparity and a formatting error
HID: usbhid: Repair a formatting issue in a struct description
HID: intel-ish-hid: Fix a little doc-rot
HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
HID: hid-alps: Correct struct misnaming
HID: intel-ish-hid: Fix potential copy/paste error
HID: hid-core: Fix incorrect function name in header
HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
header
HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
HID: hid-picolcd_core: Remove unused variable 'ret'
HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
abuses
HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
HID: hid-uclogic-params: Ensure function names are present and correct
in kernel-doc headers
HID: hid-sensor-custom: Remove unused variable 'ret'
HID: wacom_sys: Demote kernel-doc abuse
HID: hid-sensor-hub: Remove unused struct member 'quirks'
HID: hid-sensor-hub: Move 'hsdev' description to correct struct
definition
HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
drivers/hid/hid-alps.c | 2 +-
drivers/hid/hid-core.c | 2 +-
drivers/hid/hid-kye.c | 2 +-
drivers/hid/hid-logitech-hidpp.c | 7 +--
drivers/hid/hid-picolcd_core.c | 5 +--
drivers/hid/hid-sensor-custom.c | 5 +--
drivers/hid/hid-sensor-hub.c | 4 +-
drivers/hid/hid-thrustmaster.c | 24 +++++------
drivers/hid/hid-uclogic-params.c | 8 ++--
drivers/hid/hid-uclogic-rdesc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
drivers/hid/usbhid/hid-pidff.c | 4 +-
drivers/hid/usbhid/usbkbd.c | 2 +-
drivers/hid/wacom_sys.c | 2 +-
include/linux/intel-ish-client-if.h | 8 +++-
24 files changed, 90 insertions(+), 81 deletions(-)
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Anssi Hannula <anssi.hannula@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Drubin <daniel.drubin@intel.com>
Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-usb@vger.kernel.org
Cc: Lopez Casado <nlopezcasad@logitech.com>
Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
Cc: Masaki Ota <masaki.ota@jp.alps.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: message to <vojtech@ucw.cz>
Cc: Michael Haboustak <mike-@cinci.rr.com>
Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Cc: Zhang Lixu <lixu.zhang@intel.com>
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-24 17:33 ` Lee Jones
0 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: Krzysztof Wilczyński, Zhang Lixu, linux-iio,
Alexandre Torgue, dri-devel, Kai-Heng Feng, Anssi Hannula,
Kim Kuparinen, Srinivas Pandruvada, Dario Pagani, linux-stm32,
Henrik Rydberg, Lopez Casado, Rushikesh S Kadam, Masaki Ota,
Bruno Prémont, Vojtech Pavlik, linux-input, linux-media,
Uwe Kleine-König, message to, Jiri Kosina, L. Vinyard, Jr,
linaro-mm-sig, Michael Haboustak, linux-arm-kernel,
Daniel Drubin, linux-usb, linux-kernel, Benjamin Tissoires,
Maxime Coquelin, Christian König, Jonathan Cameron
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (25):
HID: intel-ish-hid: Remove unused variable 'err'
HID: ishtp-hid-client: Move variable to where it's actually used
HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
HID: intel-ish: Supply some missing param descriptions
HID: intel-ish: Fix a naming disparity and a formatting error
HID: usbhid: Repair a formatting issue in a struct description
HID: intel-ish-hid: Fix a little doc-rot
HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
HID: hid-alps: Correct struct misnaming
HID: intel-ish-hid: Fix potential copy/paste error
HID: hid-core: Fix incorrect function name in header
HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
header
HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
HID: hid-picolcd_core: Remove unused variable 'ret'
HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
abuses
HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
HID: hid-uclogic-params: Ensure function names are present and correct
in kernel-doc headers
HID: hid-sensor-custom: Remove unused variable 'ret'
HID: wacom_sys: Demote kernel-doc abuse
HID: hid-sensor-hub: Remove unused struct member 'quirks'
HID: hid-sensor-hub: Move 'hsdev' description to correct struct
definition
HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
drivers/hid/hid-alps.c | 2 +-
drivers/hid/hid-core.c | 2 +-
drivers/hid/hid-kye.c | 2 +-
drivers/hid/hid-logitech-hidpp.c | 7 +--
drivers/hid/hid-picolcd_core.c | 5 +--
drivers/hid/hid-sensor-custom.c | 5 +--
drivers/hid/hid-sensor-hub.c | 4 +-
drivers/hid/hid-thrustmaster.c | 24 +++++------
drivers/hid/hid-uclogic-params.c | 8 ++--
drivers/hid/hid-uclogic-rdesc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
drivers/hid/usbhid/hid-pidff.c | 4 +-
drivers/hid/usbhid/usbkbd.c | 2 +-
drivers/hid/wacom_sys.c | 2 +-
include/linux/intel-ish-client-if.h | 8 +++-
24 files changed, 90 insertions(+), 81 deletions(-)
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Anssi Hannula <anssi.hannula@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Drubin <daniel.drubin@intel.com>
Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-usb@vger.kernel.org
Cc: Lopez Casado <nlopezcasad@logitech.com>
Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
Cc: Masaki Ota <masaki.ota@jp.alps.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: message to <vojtech@ucw.cz>
Cc: Michael Haboustak <mike-@cinci.rr.com>
Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Cc: Zhang Lixu <lixu.zhang@intel.com>
--
2.27.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* [PATCH 01/25] HID: intel-ish-hid: Remove unused variable 'err'
2021-03-24 17:33 ` Lee Jones
(?)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Srinivas Pandruvada, Jiri Kosina,
Benjamin Tissoires, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/intel-ish-hid/ishtp/client.c: In function ‘ishtp_cl_disconnect’:
drivers/hid/intel-ish-hid/ishtp/client.c:266:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable]
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/intel-ish-hid/ishtp/client.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c
index 1cc157126fce7..c81a1f8a92685 100644
--- a/drivers/hid/intel-ish-hid/ishtp/client.c
+++ b/drivers/hid/intel-ish-hid/ishtp/client.c
@@ -263,7 +263,6 @@ EXPORT_SYMBOL(ishtp_cl_unlink);
int ishtp_cl_disconnect(struct ishtp_cl *cl)
{
struct ishtp_device *dev;
- int err;
if (WARN_ON(!cl || !cl->dev))
return -ENODEV;
@@ -283,7 +282,7 @@ int ishtp_cl_disconnect(struct ishtp_cl *cl)
return -ENODEV;
}
- err = wait_event_interruptible_timeout(cl->wait_ctrl_res,
+ wait_event_interruptible_timeout(cl->wait_ctrl_res,
(dev->dev_state != ISHTP_DEV_ENABLED ||
cl->state == ISHTP_CL_DISCONNECTED),
ishtp_secs_to_jiffies(ISHTP_CL_CONNECT_TIMEOUT));
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 02/25] HID: ishtp-hid-client: Move variable to where it's actually used
2021-03-24 17:33 ` Lee Jones
` (2 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Srinivas Pandruvada, Jiri Kosina,
Benjamin Tissoires, Daniel Drubin, linux-input
Fixes the following W=1 kernel build warning(s):
In file included from drivers/hid/intel-ish-hid/ishtp-hid.c:11:
drivers/hid/intel-ish-hid/ishtp-hid.h:24:21: warning: ‘hid_ishtp_guid’ defined but not used [-Wunused-const-variable=]
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Daniel Drubin <daniel.drubin@intel.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 +++++
drivers/hid/intel-ish-hid/ishtp-hid.h | 5 -----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c
index 0f1b5283bab42..24599280105d8 100644
--- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c
+++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c
@@ -11,6 +11,11 @@
#include <linux/sched.h>
#include "ishtp-hid.h"
+/* ISH Transport protocol (ISHTP in short) GUID */
+static const guid_t hid_ishtp_guid =
+ GUID_INIT(0x33AECD58, 0xB679, 0x4E54,
+ 0x9B, 0xD9, 0xA0, 0x4D, 0x34, 0xF0, 0xC2, 0x26);
+
/* Rx ring buffer pool size */
#define HID_CL_RX_RING_SIZE 32
#define HID_CL_TX_RING_SIZE 16
diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.h b/drivers/hid/intel-ish-hid/ishtp-hid.h
index 5ffd0da3cf1fa..e2423f7d2b547 100644
--- a/drivers/hid/intel-ish-hid/ishtp-hid.h
+++ b/drivers/hid/intel-ish-hid/ishtp-hid.h
@@ -20,11 +20,6 @@ extern void (*hid_print_trace)(void *unused, const char *format, ...);
#define hid_ishtp_trace(client, ...) \
(hid_print_trace)(NULL, __VA_ARGS__)
-/* ISH Transport protocol (ISHTP in short) GUID */
-static const guid_t hid_ishtp_guid =
- GUID_INIT(0x33AECD58, 0xB679, 0x4E54,
- 0x9B, 0xD9, 0xA0, 0x4D, 0x34, 0xF0, 0xC2, 0x26);
-
/* ISH HID message structure */
struct hostif_msg_hdr {
uint8_t command; /* Bit 7: is_response */
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 03/25] HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
2021-03-24 17:33 ` Lee Jones
` (3 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Srinivas Pandruvada, Jiri Kosina,
Benjamin Tissoires, Zhang Lixu, Kai-Heng Feng, Daniel Drubin,
linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/intel-ish-hid/ipc/pci-ish.c: In function ‘ish_resume_handler’:
drivers/hid/intel-ish-hid/ipc/pci-ish.c:264:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Zhang Lixu <lixu.zhang@intel.com>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Daniel Drubin <daniel.drubin@intel.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
index 06081cf9b85a2..61efc30ed9afb 100644
--- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
+++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
@@ -261,7 +261,6 @@ static void __maybe_unused ish_resume_handler(struct work_struct *work)
struct pci_dev *pdev = to_pci_dev(ish_resume_device);
struct ishtp_device *dev = pci_get_drvdata(pdev);
uint32_t fwsts = dev->ops->get_fw_status(dev);
- int ret;
if (ish_should_leave_d0i3(pdev) && !dev->suspend_flag
&& IPC_IS_ISH_ILUP(fwsts)) {
@@ -273,7 +272,7 @@ static void __maybe_unused ish_resume_handler(struct work_struct *work)
/* Waiting to get resume response */
if (dev->resume_flag)
- ret = wait_event_interruptible_timeout(dev->resume_wait,
+ wait_event_interruptible_timeout(dev->resume_wait,
!dev->resume_flag,
msecs_to_jiffies(WAIT_FOR_RESUME_ACK_MS));
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 04/25] HID: intel-ish: Supply some missing param descriptions
2021-03-24 17:33 ` Lee Jones
` (4 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Srinivas Pandruvada, Jiri Kosina,
Benjamin Tissoires, Uwe Kleine-König, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/intel-ish-hid/ishtp/bus.c:173: warning: Function parameter or member 'fw_client' not described in 'ishtp_get_fw_client_id'
drivers/hid/intel-ish-hid/ishtp/bus.c:845: warning: Function parameter or member 'device' not described in 'ishtp_device'
drivers/hid/intel-ish-hid/ishtp/bus.c:858: warning: Function parameter or member 'device' not described in 'ishtp_get_pci_device'
drivers/hid/intel-ish-hid/ishtp/bus.c:871: warning: Function parameter or member 'cl_device' not described in 'ishtp_trace_callback'
drivers/hid/intel-ish-hid/ishtp/bus.c:884: warning: Function parameter or member 'dev' not described in 'ish_hw_reset'
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/intel-ish-hid/ishtp/bus.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
index ffc9ce5c86ee6..c1c7d5356208d 100644
--- a/drivers/hid/intel-ish-hid/ishtp/bus.c
+++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
@@ -164,6 +164,7 @@ EXPORT_SYMBOL(ishtp_fw_cl_get_client);
/**
* ishtp_get_fw_client_id() - Get fw client id
+ * @fw_client: firmware client used to fetch the ID
*
* This interface is used to reset HW get FW client id.
*
@@ -835,6 +836,7 @@ int ishtp_use_dma_transfer(void)
/**
* ishtp_device() - Return device pointer
+ * @device: ISH-TP client device instance
*
* This interface is used to return device pointer from ishtp_cl_device
* instance.
@@ -851,6 +853,7 @@ EXPORT_SYMBOL(ishtp_device);
* ishtp_get_pci_device() - Return PCI device dev pointer
* This interface is used to return PCI device pointer
* from ishtp_cl_device instance.
+ * @device: ISH-TP client device instance
*
* Return: device *.
*/
@@ -862,6 +865,7 @@ EXPORT_SYMBOL(ishtp_get_pci_device);
/**
* ishtp_trace_callback() - Return trace callback
+ * @cl_device: ISH-TP client device instance
*
* This interface is used to return trace callback function pointer.
*
@@ -875,6 +879,7 @@ EXPORT_SYMBOL(ishtp_trace_callback);
/**
* ish_hw_reset() - Call HW reset IPC callback
+ * @dev: ISHTP device instance
*
* This interface is used to reset HW in case of error.
*
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 05/25] HID: intel-ish: Fix a naming disparity and a formatting error
2021-03-24 17:33 ` Lee Jones
` (5 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Srinivas Pandruvada, Jiri Kosina,
Benjamin Tissoires, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/intel-ish-hid/ishtp/hbm.c:409: warning: expecting prototype for ishtp_client_disconnect_request(). Prototype was for ishtp_hbm_fw_disconnect_req() instead
drivers/hid/intel-ish-hid/ishtp/hbm.c:433: warning: wrong kernel-doc identifier on line:
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c b/drivers/hid/intel-ish-hid/ishtp/hbm.c
index dbfae60f26216..9c031a06e4c40 100644
--- a/drivers/hid/intel-ish-hid/ishtp/hbm.c
+++ b/drivers/hid/intel-ish-hid/ishtp/hbm.c
@@ -398,7 +398,7 @@ static void ishtp_hbm_cl_connect_res(struct ishtp_device *dev,
}
/**
- * ishtp_client_disconnect_request() - Receive disconnect request
+ * ishtp_hbm_fw_disconnect_req() - Receive disconnect request
* @dev: ISHTP device instance
* @disconnect_req: disconnect request structure
*
@@ -430,7 +430,7 @@ static void ishtp_hbm_fw_disconnect_req(struct ishtp_device *dev,
}
/**
- * ishtp_hbm_dma_xfer_ack(() - Receive transfer ACK
+ * ishtp_hbm_dma_xfer_ack() - Receive transfer ACK
* @dev: ISHTP device instance
* @dma_xfer: HBM transfer message
*
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description
2021-03-24 17:33 ` Lee Jones
` (6 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, message to,
linux-usb, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/usbhid/usbkbd.c:66: warning: bad line: should be on
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: message to <vojtech@ucw.cz>
Cc: linux-usb@vger.kernel.org
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/usbhid/usbkbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
index d5b7a696a68c5..d0c640be8a885 100644
--- a/drivers/hid/usbhid/usbkbd.c
+++ b/drivers/hid/usbhid/usbkbd.c
@@ -63,7 +63,7 @@ static const unsigned char usb_kbd_keycode[256] = {
* new key is pressed or a key that was pressed is released.
* @led: URB for sending LEDs (e.g. numlock, ...)
* @newleds: data that will be sent with the @led URB representing which LEDs
- should be on
+ * should be on
* @name: Name of the keyboard. @dev's name field points to this buffer
* @phys: Physical path of the keyboard. @dev's phys field points to this
* buffer
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 07/25] HID: intel-ish-hid: Fix a little doc-rot
2021-03-24 17:33 ` Lee Jones
` (7 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Srinivas Pandruvada, Jiri Kosina,
Benjamin Tissoires, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/intel-ish-hid/ishtp/client.c:121: warning: Function parameter or member 'cl_device' not described in 'ishtp_cl_allocate'
drivers/hid/intel-ish-hid/ishtp/client.c:121: warning: Excess function parameter 'dev' description in 'ishtp_cl_allocate'
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/intel-ish-hid/ishtp/client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/ishtp/client.c
index c81a1f8a92685..585a5c4066cb3 100644
--- a/drivers/hid/intel-ish-hid/ishtp/client.c
+++ b/drivers/hid/intel-ish-hid/ishtp/client.c
@@ -111,7 +111,7 @@ static void ishtp_cl_init(struct ishtp_cl *cl, struct ishtp_device *dev)
/**
* ishtp_cl_allocate() - allocates client structure and sets it up.
- * @dev: ishtp device
+ * @cl_device: ishtp client device
*
* Allocate memory for new client device and call to initialize each field.
*
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
2021-03-24 17:33 ` Lee Jones
` (8 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Anssi Hannula,
linux-usb, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'dev' not described in 'pidff_playback'
drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'effect_id' not described in 'pidff_playback'
drivers/hid/usbhid/hid-pidff.c:512: warning: Function parameter or member 'value' not described in 'pidff_playback'
drivers/hid/usbhid/hid-pidff.c:512: warning: expecting prototype for value times(). Prototype was for pidff_playback() instead
drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'pidff' not described in 'pidff_find_effects'
drivers/hid/usbhid/hid-pidff.c:1005: warning: Function parameter or member 'dev' not described in 'pidff_find_effects'
drivers/hid/usbhid/hid-pidff.c:1005: warning: expecting prototype for Find the implemented effect types(). Prototype was for pidff_find_effects() instead
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Anssi Hannula <anssi.hannula@gmail.com>
Cc: linux-usb@vger.kernel.org
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/usbhid/hid-pidff.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
index fddac7c72f645..ea126c50acc3b 100644
--- a/drivers/hid/usbhid/hid-pidff.c
+++ b/drivers/hid/usbhid/hid-pidff.c
@@ -505,7 +505,7 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n)
HID_REQ_SET_REPORT);
}
-/**
+/*
* Play the effect with effect id @effect_id for @value times
*/
static int pidff_playback(struct input_dev *dev, int effect_id, int value)
@@ -997,7 +997,7 @@ static int pidff_find_special_fields(struct pidff_device *pidff)
return 0;
}
-/**
+/*
* Find the implemented effect types
*/
static int pidff_find_effects(struct pidff_device *pidff,
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 09/25] HID: hid-alps: Correct struct misnaming
2021-03-24 17:33 ` Lee Jones
` (9 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Henrik Rydberg,
Masaki Ota, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-alps.c:113: warning: expecting prototype for struct u1_data. Prototype was for struct alps_dev instead
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Masaki Ota <masaki.ota@jp.alps.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/hid-alps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index 6b665931147df..2b986d0dbde46 100644
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -74,7 +74,7 @@ enum dev_num {
UNKNOWN,
};
/**
- * struct u1_data
+ * struct alps_dev
*
* @input: pointer to the kernel input device
* @input2: pointer to the kernel input2 device
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 10/25] HID: intel-ish-hid: Fix potential copy/paste error
2021-03-24 17:33 ` Lee Jones
` (10 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Srinivas Pandruvada, Jiri Kosina,
Benjamin Tissoires, linux-input
Fixes the following W=1 kernel build warning(s):
In file included from drivers/hid/intel-ish-hid/ishtp-hid.c:11:
drivers/hid/intel-ish-hid/ishtp-hid.c:263: warning: expecting prototype for ishtp_hid_probe(). Prototype was for ishtp_hid_remove() instead
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.c b/drivers/hid/intel-ish-hid/ishtp-hid.c
index 393bed0abee99..14c271d7d8a94 100644
--- a/drivers/hid/intel-ish-hid/ishtp-hid.c
+++ b/drivers/hid/intel-ish-hid/ishtp-hid.c
@@ -254,7 +254,7 @@ int ishtp_hid_probe(unsigned int cur_hid_dev,
}
/**
- * ishtp_hid_probe() - Remove registered hid device
+ * ishtp_hid_remove() - Remove registered hid device
* @client_data: client data pointer
*
* This function is used to destroy allocatd HID device.
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 11/25] HID: hid-core: Fix incorrect function name in header
2021-03-24 17:33 ` Lee Jones
` (11 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Vojtech Pavlik,
Michael Haboustak, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-core.c:2142: warning: expecting prototype for store_new_id(). Prototype was for new_id_store() instead
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Cc: Michael Haboustak <mike-@cinci.rr.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/hid-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 097cb1ee31268..0ae9f6df59d10 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2129,7 +2129,7 @@ struct hid_dynid {
};
/**
- * store_new_id - add a new HID device ID to this driver and re-probe devices
+ * new_id_store - add a new HID device ID to this driver and re-probe devices
* @drv: target device driver
* @buf: buffer for scanning device ID data
* @count: input size
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 12/25] HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in header
2021-03-24 17:33 ` Lee Jones
` (12 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Srinivas Pandruvada, Jiri Kosina,
Benjamin Tissoires, Zhang Lixu, Krzysztof Wilczyński,
linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/intel-ish-hid/ipc/ipc.c:553: warning: expecting prototype for ish_fw_reset_work_fn(). Prototype was for fw_reset_work_fn() instead
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Zhang Lixu <lixu.zhang@intel.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
index 47bbeb8b492b0..9037816e2bf74 100644
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -544,7 +544,7 @@ static int ish_fw_reset_handler(struct ishtp_device *dev)
#define TIMEOUT_FOR_HW_RDY_MS 300
/**
- * ish_fw_reset_work_fn() - FW reset worker function
+ * fw_reset_work_fn() - FW reset worker function
* @unused: not used
*
* Call ish_fw_reset_handler to complete FW reset
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 13/25] HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
2021-03-24 17:33 ` Lee Jones
` (13 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Srinivas Pandruvada, Jiri Kosina,
Benjamin Tissoires, Daniel Drubin, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/intel-ish-hid/ishtp-hid-client.c:36: warning: expecting prototype for report_bad_packets(). Prototype was for report_bad_packet() instead
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Daniel Drubin <daniel.drubin@intel.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c
index 24599280105d8..042a7091802dd 100644
--- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c
+++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c
@@ -23,7 +23,7 @@ static const guid_t hid_ishtp_guid =
#define cl_data_to_dev(client_data) ishtp_device(client_data->cl_device)
/**
- * report_bad_packets() - Report bad packets
+ * report_bad_packet() - Report bad packets
* @hid_ishtp_cl: Client instance to get stats
* @recv_buf: Raw received host interface message
* @cur_pos: Current position index in payload
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 14/25] HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
2021-03-24 17:33 ` Lee Jones
` (14 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-kye.c:666: warning: expecting prototype for Enable fully(). Prototype was for kye_tablet_enable() instead
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/hid-kye.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c
index c8b40c07eca69..f46616390a984 100644
--- a/drivers/hid/hid-kye.c
+++ b/drivers/hid/hid-kye.c
@@ -655,7 +655,7 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc,
}
/**
- * Enable fully-functional tablet mode by setting a special feature report.
+ * kye_tablet_enable() - Enable fully-functional tablet mode by setting a special feature report.
*
* @hdev: HID device
*
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 15/25] HID: hid-picolcd_core: Remove unused variable 'ret'
2021-03-24 17:33 ` Lee Jones
` (15 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Bruno Prémont, Jiri Kosina,
Benjamin Tissoires, L. Vinyard, Jr, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-picolcd_core.c: In function ‘picolcd_raw_event’:
drivers/hid/hid-picolcd_core.c:332:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/hid-picolcd_core.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-picolcd_core.c b/drivers/hid/hid-picolcd_core.c
index 1b5c63241af05..bbda231a7ce30 100644
--- a/drivers/hid/hid-picolcd_core.c
+++ b/drivers/hid/hid-picolcd_core.c
@@ -329,7 +329,6 @@ static int picolcd_raw_event(struct hid_device *hdev,
{
struct picolcd_data *data = hid_get_drvdata(hdev);
unsigned long flags;
- int ret = 0;
if (!data)
return 1;
@@ -342,9 +341,9 @@ static int picolcd_raw_event(struct hid_device *hdev,
if (report->id == REPORT_KEY_STATE) {
if (data->input_keys)
- ret = picolcd_raw_keypad(data, report, raw_data+1, size-1);
+ picolcd_raw_keypad(data, report, raw_data+1, size-1);
} else if (report->id == REPORT_IR_DATA) {
- ret = picolcd_raw_cir(data, report, raw_data+1, size-1);
+ picolcd_raw_cir(data, report, raw_data+1, size-1);
} else {
spin_lock_irqsave(&data->lock, flags);
/*
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 16/25] HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses
2021-03-24 17:33 ` Lee Jones
` (16 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Henrik Rydberg,
Lopez Casado, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'hidpp' not described in 'hidpp_send_message_sync'
drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'message' not described in 'hidpp_send_message_sync'
drivers/hid/hid-logitech-hidpp.c:275: warning: Function parameter or member 'response' not described in 'hidpp_send_message_sync'
drivers/hid/hid-logitech-hidpp.c:275: warning: expecting prototype for and something else(). Prototype was for hidpp_send_message_sync() instead
drivers/hid/hid-logitech-hidpp.c:427: warning: wrong kernel-doc identifier on line:
drivers/hid/hid-logitech-hidpp.c:470: warning: Function parameter or member 'input_dev' not described in 'hidpp_scroll_counter_handle_scroll'
drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'hidpp' not described in 'hidpp_touchpad_fw_items_set'
drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'feature_index' not described in 'hidpp_touchpad_fw_items_set'
drivers/hid/hid-logitech-hidpp.c:1894: warning: Function parameter or member 'items' not described in 'hidpp_touchpad_fw_items_set'
drivers/hid/hid-logitech-hidpp.c:1894: warning: expecting prototype for send a set state command to the device by reading the current items(). Prototype was for hidpp_touchpad_fw_items_set() instead
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Lopez Casado <nlopezcasad@logitech.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/hid-logitech-hidpp.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index d459e2dbe6474..d598094dadd0c 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -261,7 +261,7 @@ static int __hidpp_send_report(struct hid_device *hdev,
return ret == fields_count ? 0 : -1;
}
-/**
+/*
* hidpp_send_message_sync() returns 0 in case of success, and something else
* in case of a failure.
* - If ' something else' is positive, that means that an error has been raised
@@ -423,7 +423,7 @@ static inline bool hidpp_report_is_connect_event(struct hidpp_device *hidpp,
(report->rap.sub_id == 0x41));
}
-/**
+/*
* hidpp_prefix_name() prefixes the current given name with "Logitech ".
*/
static void hidpp_prefix_name(char **name, int name_length)
@@ -454,6 +454,7 @@ static void hidpp_prefix_name(char **name, int name_length)
* hidpp_scroll_counter_handle_scroll() - Send high- and low-resolution scroll
* events given a high-resolution wheel
* movement.
+ * @input_dev: Pointer to the input device
* @counter: a hid_scroll_counter struct describing the wheel.
* @hi_res_value: the movement of the wheel, in the mouse's high-resolution
* units.
@@ -1884,7 +1885,7 @@ struct hidpp_touchpad_fw_items {
uint8_t persistent;
};
-/**
+/*
* send a set state command to the device by reading the current items->state
* field. items is then filled with the current state.
*/
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 17/25] HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
2021-03-24 17:33 ` Lee Jones
` (17 preceding siblings ...)
(?)
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, linux-input
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-uclogic-rdesc.c:645: warning: wrong kernel-doc identifier on line:
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/hid-uclogic-rdesc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-uclogic-rdesc.c b/drivers/hid/hid-uclogic-rdesc.c
index bf5da6de7bba9..6dd6dcd09c8bc 100644
--- a/drivers/hid/hid-uclogic-rdesc.c
+++ b/drivers/hid/hid-uclogic-rdesc.c
@@ -641,7 +641,7 @@ const __u8 uclogic_rdesc_pen_v2_template_arr[] = {
const size_t uclogic_rdesc_pen_v2_template_size =
sizeof(uclogic_rdesc_pen_v2_template_arr);
-/**
+/*
* Expand to the contents of a generic buttonpad report descriptor.
*
* @_padding: Padding from the end of button bits at bit 44, until
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
2021-03-24 17:33 ` Lee Jones
@ 2021-03-24 17:33 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Maxime Coquelin,
Alexandre Torgue, Dario Pagani, Kim Kuparinen, linux-input,
linux-stm32, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-thrustmaster.c:23: warning: Incorrect use of kernel-doc format: * These interrupts are used to prevent a nasty crash when initializing the
drivers/hid/hid-thrustmaster.c:26: warning: cannot understand function prototype: 'const u8 setup_0[] = '
drivers/hid/hid-thrustmaster.c:49: warning: cannot understand function prototype: 'struct tm_wheel_info '
drivers/hid/hid-thrustmaster.c:62: warning: wrong kernel-doc identifier on line:
drivers/hid/hid-thrustmaster.c:84: warning: cannot understand function prototype: 'struct __packed tm_wheel_response '
drivers/hid/hid-thrustmaster.c:143: warning: wrong kernel-doc identifier on line:
drivers/hid/hid-thrustmaster.c:202: warning: Function parameter or member 'urb' not described in 'thrustmaster_model_handler'
drivers/hid/hid-thrustmaster.c:202: warning: expecting prototype for Called by the USB subsystem when the wheel responses to our request(). Prototype was for thrustmaster_model_handler() instead
drivers/hid/hid-thrustmaster.c:265: warning: wrong kernel-doc identifier on line:
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
Cc: linux-input@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/hid-thrustmaster.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
index bfcd08759ba09..4f9c0642e816b 100644
--- a/drivers/hid/hid-thrustmaster.c
+++ b/drivers/hid/hid-thrustmaster.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
-/**
+/*
* When connected to the machine, the Thrustmaster wheels appear as
* a «generic» hid gamepad called "Thrustmaster FFB Wheel".
*
@@ -19,7 +19,7 @@
#include <linux/slab.h>
#include <linux/module.h>
-/**
+/*
* These interrupts are used to prevent a nasty crash when initializing the
* T300RS. Used in thrustmaster_interrupts().
*/
@@ -36,7 +36,7 @@ static const unsigned int setup_arr_sizes[] = {
ARRAY_SIZE(setup_3),
ARRAY_SIZE(setup_4)
};
-/**
+/*
* This struct contains for each type of
* Thrustmaster wheel
*
@@ -49,7 +49,7 @@ static const unsigned int setup_arr_sizes[] = {
struct tm_wheel_info {
uint16_t wheel_type;
- /**
+ /*
* See when the USB control out packet is prepared...
* @TODO The TMX seems to require multiple control codes to switch.
*/
@@ -58,7 +58,7 @@ struct tm_wheel_info {
char const *const wheel_name;
};
-/**
+/*
* Known wheels.
* Note: TMX does not work as it requires 2 control packets
*/
@@ -72,7 +72,7 @@ static const struct tm_wheel_info tm_wheels_infos[] = {
static const uint8_t tm_wheels_infos_length = 4;
-/**
+/*
* This structs contains (in little endian) the response data
* of the wheel to the request 73
*
@@ -82,7 +82,7 @@ static const uint8_t tm_wheels_infos_length = 4;
*/
struct __packed tm_wheel_response
{
- /**
+ /*
* Seems to be the type of packet
* - 0x0049 if is data.a (15 bytes)
* - 0x0047 if is data.b (7 bytes)
@@ -93,7 +93,7 @@ struct __packed tm_wheel_response
struct __packed {
uint16_t field0;
uint16_t field1;
- /**
+ /*
* Seems to be the model code of the wheel
* Read table thrustmaster_wheels to values
*/
@@ -122,7 +122,7 @@ struct tm_wheel {
struct usb_ctrlrequest *change_request;
};
-/** The control packet to send to wheel */
+/* The control packet to send to wheel */
static const struct usb_ctrlrequest model_request = {
.bRequestType = 0xc1,
.bRequest = 73,
@@ -139,7 +139,7 @@ static const struct usb_ctrlrequest change_request = {
.wLength = 0
};
-/**
+/*
* On some setups initializing the T300RS crashes the kernel,
* these interrupts fix that particular issue. So far they haven't caused any
* adverse effects in other wheels.
@@ -191,7 +191,7 @@ static void thrustmaster_change_handler(struct urb *urb)
hid_warn(hdev, "URB to change wheel mode seems to have failed with error %d\n", urb->status);
}
-/**
+/*
* Called by the USB subsystem when the wheel responses to our request
* to get [what it seems to be] the wheel's model.
*
@@ -261,7 +261,7 @@ static void thrustmaster_remove(struct hid_device *hdev)
hid_hw_stop(hdev);
}
-/**
+/*
* Function called by HID when a hid Thrustmaster FFB wheel is connected to the host.
* This function starts the hid dev, tries to allocate the tm_wheel data structure and
* finally send an USB CONTROL REQUEST to the wheel to get [what it seems to be] its
--
2.27.0
^ permalink raw reply related [flat|nested] 34+ messages in thread
* [PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
@ 2021-03-24 17:33 ` Lee Jones
0 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-24 17:33 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Maxime Coquelin,
Alexandre Torgue, Dario Pagani, Kim Kuparinen, linux-input,
linux-stm32, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-thrustmaster.c:23: warning: Incorrect use of kernel-doc format: * These interrupts are used to prevent a nasty crash when initializing the
drivers/hid/hid-thrustmaster.c:26: warning: cannot understand function prototype: 'const u8 setup_0[] = '
drivers/hid/hid-thrustmaster.c:49: warning: cannot understand function prototype: 'struct tm_wheel_info '
drivers/hid/hid-thrustmaster.c:62: warning: wrong kernel-doc identifier on line:
drivers/hid/hid-thrustmaster.c:84: warning: cannot understand function prototype: 'struct __packed tm_wheel_response '
drivers/hid/hid-thrustmaster.c:143: warning: wrong kernel-doc identifier on line:
drivers/hid/hid-thrustmaster.c:202: warning: Function parameter or member 'urb' not described in 'thrustmaster_model_handler'
drivers/hid/hid-thrustmaster.c:202: warning: expecting prototype for Called by the USB subsystem when the wheel responses to our request(). Prototype was for thrustmaster_model_handler() instead
drivers/hid/hid-thrustmaster.c:265: warning: wrong kernel-doc identifier on line:
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
Cc: linux-input@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/hid-thrustmaster.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
index bfcd08759ba09..4f9c0642e816b 100644
--- a/drivers/hid/hid-thrustmaster.c
+++ b/drivers/hid/hid-thrustmaster.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
-/**
+/*
* When connected to the machine, the Thrustmaster wheels appear as
* a «generic» hid gamepad called "Thrustmaster FFB Wheel".
*
@@ -19,7 +19,7 @@
#include <linux/slab.h>
#include <linux/module.h>
-/**
+/*
* These interrupts are used to prevent a nasty crash when initializing the
* T300RS. Used in thrustmaster_interrupts().
*/
@@ -36,7 +36,7 @@ static const unsigned int setup_arr_sizes[] = {
ARRAY_SIZE(setup_3),
ARRAY_SIZE(setup_4)
};
-/**
+/*
* This struct contains for each type of
* Thrustmaster wheel
*
@@ -49,7 +49,7 @@ static const unsigned int setup_arr_sizes[] = {
struct tm_wheel_info {
uint16_t wheel_type;
- /**
+ /*
* See when the USB control out packet is prepared...
* @TODO The TMX seems to require multiple control codes to switch.
*/
@@ -58,7 +58,7 @@ struct tm_wheel_info {
char const *const wheel_name;
};
-/**
+/*
* Known wheels.
* Note: TMX does not work as it requires 2 control packets
*/
@@ -72,7 +72,7 @@ static const struct tm_wheel_info tm_wheels_infos[] = {
static const uint8_t tm_wheels_infos_length = 4;
-/**
+/*
* This structs contains (in little endian) the response data
* of the wheel to the request 73
*
@@ -82,7 +82,7 @@ static const uint8_t tm_wheels_infos_length = 4;
*/
struct __packed tm_wheel_response
{
- /**
+ /*
* Seems to be the type of packet
* - 0x0049 if is data.a (15 bytes)
* - 0x0047 if is data.b (7 bytes)
@@ -93,7 +93,7 @@ struct __packed tm_wheel_response
struct __packed {
uint16_t field0;
uint16_t field1;
- /**
+ /*
* Seems to be the model code of the wheel
* Read table thrustmaster_wheels to values
*/
@@ -122,7 +122,7 @@ struct tm_wheel {
struct usb_ctrlrequest *change_request;
};
-/** The control packet to send to wheel */
+/* The control packet to send to wheel */
static const struct usb_ctrlrequest model_request = {
.bRequestType = 0xc1,
.bRequest = 73,
@@ -139,7 +139,7 @@ static const struct usb_ctrlrequest change_request = {
.wLength = 0
};
-/**
+/*
* On some setups initializing the T300RS crashes the kernel,
* these interrupts fix that particular issue. So far they haven't caused any
* adverse effects in other wheels.
@@ -191,7 +191,7 @@ static void thrustmaster_change_handler(struct urb *urb)
hid_warn(hdev, "URB to change wheel mode seems to have failed with error %d\n", urb->status);
}
-/**
+/*
* Called by the USB subsystem when the wheel responses to our request
* to get [what it seems to be] the wheel's model.
*
@@ -261,7 +261,7 @@ static void thrustmaster_remove(struct hid_device *hdev)
hid_hw_stop(hdev);
}
-/**
+/*
* Function called by HID when a hid Thrustmaster FFB wheel is connected to the host.
* This function starts the hid dev, tries to allocate the tm_wheel data structure and
* finally send an USB CONTROL REQUEST to the wheel to get [what it seems to be] its
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
2021-03-24 17:33 ` Lee Jones
(?)
@ 2021-03-24 21:27 ` Srinivas Pandruvada
-1 siblings, 0 replies; 34+ messages in thread
From: Srinivas Pandruvada @ 2021-03-24 21:27 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Jonathan Cameron, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam, Sumit Semwal,
Uwe Kleine-König, Vojtech Pavlik, Zhang Lixu
On Wed, 2021-03-24 at 17:33 +0000, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
For changes in drivers/hid/intel-ish-hid folder
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Lee Jones (25):
> HID: intel-ish-hid: Remove unused variable 'err'
> HID: ishtp-hid-client: Move variable to where it's actually used
> HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> HID: intel-ish: Supply some missing param descriptions
> HID: intel-ish: Fix a naming disparity and a formatting error
> HID: usbhid: Repair a formatting issue in a struct description
> HID: intel-ish-hid: Fix a little doc-rot
> HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> HID: hid-alps: Correct struct misnaming
> HID: intel-ish-hid: Fix potential copy/paste error
> HID: hid-core: Fix incorrect function name in header
> HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name
> in
> header
> HID: ishtp-hid-client: Fix incorrect function name
> report_bad_packet()
> HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> HID: hid-picolcd_core: Remove unused variable 'ret'
> HID: hid-logitech-hidpp: Fix conformant kernel-doc header and
> demote
> abuses
> HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> HID: hid-uclogic-params: Ensure function names are present and
> correct
> in kernel-doc headers
> HID: hid-sensor-custom: Remove unused variable 'ret'
> HID: wacom_sys: Demote kernel-doc abuse
> HID: hid-sensor-hub: Remove unused struct member 'quirks'
> HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> definition
> HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting
> issues
> HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler
> warning
>
> drivers/hid/hid-alps.c | 2 +-
> drivers/hid/hid-core.c | 2 +-
> drivers/hid/hid-kye.c | 2 +-
> drivers/hid/hid-logitech-hidpp.c | 7 +--
> drivers/hid/hid-picolcd_core.c | 5 +--
> drivers/hid/hid-sensor-custom.c | 5 +--
> drivers/hid/hid-sensor-hub.c | 4 +-
> drivers/hid/hid-thrustmaster.c | 24 +++++------
> drivers/hid/hid-uclogic-params.c | 8 ++--
> drivers/hid/hid-uclogic-rdesc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
> drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++------
> ----
> drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
> drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
> drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
> drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
> drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
> drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
> drivers/hid/usbhid/hid-pidff.c | 4 +-
> drivers/hid/usbhid/usbkbd.c | 2 +-
> drivers/hid/wacom_sys.c | 2 +-
> include/linux/intel-ish-client-if.h | 8 +++-
> 24 files changed, 90 insertions(+), 81 deletions(-)
>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Anssi Hannula <anssi.hannula@gmail.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Drubin <daniel.drubin@intel.com>
> Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
> Cc: "Krzysztof Wilczyński" <kw@linux.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-iio@vger.kernel.org
> Cc: linux-input@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-usb@vger.kernel.org
> Cc: Lopez Casado <nlopezcasad@logitech.com>
> Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
> Cc: Masaki Ota <masaki.ota@jp.alps.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: message to <vojtech@ucw.cz>
> Cc: Michael Haboustak <mike-@cinci.rr.com>
> Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
> Cc: Vojtech Pavlik <vojtech@suse.cz>
> Cc: Zhang Lixu <lixu.zhang@intel.com>
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-24 21:27 ` Srinivas Pandruvada
0 siblings, 0 replies; 34+ messages in thread
From: Srinivas Pandruvada @ 2021-03-24 21:27 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Jonathan Cameron, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam, Sumit Semwal,
Uwe Kleine-König, Vojtech Pavlik, Zhang Lixu
On Wed, 2021-03-24 at 17:33 +0000, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
For changes in drivers/hid/intel-ish-hid folder
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Lee Jones (25):
> HID: intel-ish-hid: Remove unused variable 'err'
> HID: ishtp-hid-client: Move variable to where it's actually used
> HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> HID: intel-ish: Supply some missing param descriptions
> HID: intel-ish: Fix a naming disparity and a formatting error
> HID: usbhid: Repair a formatting issue in a struct description
> HID: intel-ish-hid: Fix a little doc-rot
> HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> HID: hid-alps: Correct struct misnaming
> HID: intel-ish-hid: Fix potential copy/paste error
> HID: hid-core: Fix incorrect function name in header
> HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name
> in
> header
> HID: ishtp-hid-client: Fix incorrect function name
> report_bad_packet()
> HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> HID: hid-picolcd_core: Remove unused variable 'ret'
> HID: hid-logitech-hidpp: Fix conformant kernel-doc header and
> demote
> abuses
> HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> HID: hid-uclogic-params: Ensure function names are present and
> correct
> in kernel-doc headers
> HID: hid-sensor-custom: Remove unused variable 'ret'
> HID: wacom_sys: Demote kernel-doc abuse
> HID: hid-sensor-hub: Remove unused struct member 'quirks'
> HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> definition
> HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting
> issues
> HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler
> warning
>
> drivers/hid/hid-alps.c | 2 +-
> drivers/hid/hid-core.c | 2 +-
> drivers/hid/hid-kye.c | 2 +-
> drivers/hid/hid-logitech-hidpp.c | 7 +--
> drivers/hid/hid-picolcd_core.c | 5 +--
> drivers/hid/hid-sensor-custom.c | 5 +--
> drivers/hid/hid-sensor-hub.c | 4 +-
> drivers/hid/hid-thrustmaster.c | 24 +++++------
> drivers/hid/hid-uclogic-params.c | 8 ++--
> drivers/hid/hid-uclogic-rdesc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
> drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++------
> ----
> drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
> drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
> drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
> drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
> drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
> drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
> drivers/hid/usbhid/hid-pidff.c | 4 +-
> drivers/hid/usbhid/usbkbd.c | 2 +-
> drivers/hid/wacom_sys.c | 2 +-
> include/linux/intel-ish-client-if.h | 8 +++-
> 24 files changed, 90 insertions(+), 81 deletions(-)
>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Anssi Hannula <anssi.hannula@gmail.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Drubin <daniel.drubin@intel.com>
> Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
> Cc: "Krzysztof Wilczyński" <kw@linux.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-iio@vger.kernel.org
> Cc: linux-input@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-usb@vger.kernel.org
> Cc: Lopez Casado <nlopezcasad@logitech.com>
> Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
> Cc: Masaki Ota <masaki.ota@jp.alps.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: message to <vojtech@ucw.cz>
> Cc: Michael Haboustak <mike-@cinci.rr.com>
> Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
> Cc: Vojtech Pavlik <vojtech@suse.cz>
> Cc: Zhang Lixu <lixu.zhang@intel.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-24 21:27 ` Srinivas Pandruvada
0 siblings, 0 replies; 34+ messages in thread
From: Srinivas Pandruvada @ 2021-03-24 21:27 UTC (permalink / raw)
To: Lee Jones
Cc: Krzysztof Wilczyński, Zhang Lixu, linux-iio,
Alexandre Torgue, dri-devel, Kai-Heng Feng, Anssi Hannula,
Kim Kuparinen, Dario Pagani, linux-stm32, Henrik Rydberg,
Lopez Casado, Rushikesh S Kadam, Masaki Ota, Bruno Prémont,
Vojtech Pavlik, linux-input, linux-media, Uwe Kleine-König,
message to, Jiri Kosina, L. Vinyard, Jr, linaro-mm-sig,
Michael Haboustak, linux-arm-kernel, Daniel Drubin, linux-usb,
linux-kernel, Benjamin Tissoires, Maxime Coquelin,
Christian König, Jonathan Cameron
On Wed, 2021-03-24 at 17:33 +0000, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
For changes in drivers/hid/intel-ish-hid folder
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Lee Jones (25):
> HID: intel-ish-hid: Remove unused variable 'err'
> HID: ishtp-hid-client: Move variable to where it's actually used
> HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> HID: intel-ish: Supply some missing param descriptions
> HID: intel-ish: Fix a naming disparity and a formatting error
> HID: usbhid: Repair a formatting issue in a struct description
> HID: intel-ish-hid: Fix a little doc-rot
> HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> HID: hid-alps: Correct struct misnaming
> HID: intel-ish-hid: Fix potential copy/paste error
> HID: hid-core: Fix incorrect function name in header
> HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name
> in
> header
> HID: ishtp-hid-client: Fix incorrect function name
> report_bad_packet()
> HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> HID: hid-picolcd_core: Remove unused variable 'ret'
> HID: hid-logitech-hidpp: Fix conformant kernel-doc header and
> demote
> abuses
> HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> HID: hid-uclogic-params: Ensure function names are present and
> correct
> in kernel-doc headers
> HID: hid-sensor-custom: Remove unused variable 'ret'
> HID: wacom_sys: Demote kernel-doc abuse
> HID: hid-sensor-hub: Remove unused struct member 'quirks'
> HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> definition
> HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting
> issues
> HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler
> warning
>
> drivers/hid/hid-alps.c | 2 +-
> drivers/hid/hid-core.c | 2 +-
> drivers/hid/hid-kye.c | 2 +-
> drivers/hid/hid-logitech-hidpp.c | 7 +--
> drivers/hid/hid-picolcd_core.c | 5 +--
> drivers/hid/hid-sensor-custom.c | 5 +--
> drivers/hid/hid-sensor-hub.c | 4 +-
> drivers/hid/hid-thrustmaster.c | 24 +++++------
> drivers/hid/hid-uclogic-params.c | 8 ++--
> drivers/hid/hid-uclogic-rdesc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
> drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++------
> ----
> drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
> drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
> drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
> drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
> drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
> drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
> drivers/hid/usbhid/hid-pidff.c | 4 +-
> drivers/hid/usbhid/usbkbd.c | 2 +-
> drivers/hid/wacom_sys.c | 2 +-
> include/linux/intel-ish-client-if.h | 8 +++-
> 24 files changed, 90 insertions(+), 81 deletions(-)
>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Anssi Hannula <anssi.hannula@gmail.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Drubin <daniel.drubin@intel.com>
> Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
> Cc: "Krzysztof Wilczyński" <kw@linux.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-iio@vger.kernel.org
> Cc: linux-input@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-usb@vger.kernel.org
> Cc: Lopez Casado <nlopezcasad@logitech.com>
> Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
> Cc: Masaki Ota <masaki.ota@jp.alps.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: message to <vojtech@ucw.cz>
> Cc: Michael Haboustak <mike-@cinci.rr.com>
> Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
> Cc: Vojtech Pavlik <vojtech@suse.cz>
> Cc: Zhang Lixu <lixu.zhang@intel.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
2021-03-24 17:33 ` Lee Jones
(?)
@ 2021-03-26 11:42 ` Jonathan Cameron
-1 siblings, 0 replies; 34+ messages in thread
From: Jonathan Cameron @ 2021-03-26 11:42 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
On Wed, 24 Mar 2021 17:33:39 +0000
Lee Jones <lee.jones@linaro.org> wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
Lee, it's a bit novel to cc linux-iio on the cover letter but
none of the actual patches.. Or least none of them reached
me or lore.kernel.org
I'm sure they are great :)
Jonathan
>
> Lee Jones (25):
> HID: intel-ish-hid: Remove unused variable 'err'
> HID: ishtp-hid-client: Move variable to where it's actually used
> HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> HID: intel-ish: Supply some missing param descriptions
> HID: intel-ish: Fix a naming disparity and a formatting error
> HID: usbhid: Repair a formatting issue in a struct description
> HID: intel-ish-hid: Fix a little doc-rot
> HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> HID: hid-alps: Correct struct misnaming
> HID: intel-ish-hid: Fix potential copy/paste error
> HID: hid-core: Fix incorrect function name in header
> HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> header
> HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> HID: hid-picolcd_core: Remove unused variable 'ret'
> HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> abuses
> HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> HID: hid-uclogic-params: Ensure function names are present and correct
> in kernel-doc headers
> HID: hid-sensor-custom: Remove unused variable 'ret'
> HID: wacom_sys: Demote kernel-doc abuse
> HID: hid-sensor-hub: Remove unused struct member 'quirks'
> HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> definition
> HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
>
> drivers/hid/hid-alps.c | 2 +-
> drivers/hid/hid-core.c | 2 +-
> drivers/hid/hid-kye.c | 2 +-
> drivers/hid/hid-logitech-hidpp.c | 7 +--
> drivers/hid/hid-picolcd_core.c | 5 +--
> drivers/hid/hid-sensor-custom.c | 5 +--
> drivers/hid/hid-sensor-hub.c | 4 +-
> drivers/hid/hid-thrustmaster.c | 24 +++++------
> drivers/hid/hid-uclogic-params.c | 8 ++--
> drivers/hid/hid-uclogic-rdesc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
> drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
> drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
> drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
> drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
> drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
> drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
> drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
> drivers/hid/usbhid/hid-pidff.c | 4 +-
> drivers/hid/usbhid/usbkbd.c | 2 +-
> drivers/hid/wacom_sys.c | 2 +-
> include/linux/intel-ish-client-if.h | 8 +++-
> 24 files changed, 90 insertions(+), 81 deletions(-)
>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Anssi Hannula <anssi.hannula@gmail.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Drubin <daniel.drubin@intel.com>
> Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
> Cc: "Krzysztof Wilczyński" <kw@linux.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-iio@vger.kernel.org
> Cc: linux-input@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-usb@vger.kernel.org
> Cc: Lopez Casado <nlopezcasad@logitech.com>
> Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
> Cc: Masaki Ota <masaki.ota@jp.alps.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: message to <vojtech@ucw.cz>
> Cc: Michael Haboustak <mike-@cinci.rr.com>
> Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
> Cc: Vojtech Pavlik <vojtech@suse.cz>
> Cc: Zhang Lixu <lixu.zhang@intel.com>
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-26 11:42 ` Jonathan Cameron
0 siblings, 0 replies; 34+ messages in thread
From: Jonathan Cameron @ 2021-03-26 11:42 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
On Wed, 24 Mar 2021 17:33:39 +0000
Lee Jones <lee.jones@linaro.org> wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
Lee, it's a bit novel to cc linux-iio on the cover letter but
none of the actual patches.. Or least none of them reached
me or lore.kernel.org
I'm sure they are great :)
Jonathan
>
> Lee Jones (25):
> HID: intel-ish-hid: Remove unused variable 'err'
> HID: ishtp-hid-client: Move variable to where it's actually used
> HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> HID: intel-ish: Supply some missing param descriptions
> HID: intel-ish: Fix a naming disparity and a formatting error
> HID: usbhid: Repair a formatting issue in a struct description
> HID: intel-ish-hid: Fix a little doc-rot
> HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> HID: hid-alps: Correct struct misnaming
> HID: intel-ish-hid: Fix potential copy/paste error
> HID: hid-core: Fix incorrect function name in header
> HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> header
> HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> HID: hid-picolcd_core: Remove unused variable 'ret'
> HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> abuses
> HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> HID: hid-uclogic-params: Ensure function names are present and correct
> in kernel-doc headers
> HID: hid-sensor-custom: Remove unused variable 'ret'
> HID: wacom_sys: Demote kernel-doc abuse
> HID: hid-sensor-hub: Remove unused struct member 'quirks'
> HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> definition
> HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
>
> drivers/hid/hid-alps.c | 2 +-
> drivers/hid/hid-core.c | 2 +-
> drivers/hid/hid-kye.c | 2 +-
> drivers/hid/hid-logitech-hidpp.c | 7 +--
> drivers/hid/hid-picolcd_core.c | 5 +--
> drivers/hid/hid-sensor-custom.c | 5 +--
> drivers/hid/hid-sensor-hub.c | 4 +-
> drivers/hid/hid-thrustmaster.c | 24 +++++------
> drivers/hid/hid-uclogic-params.c | 8 ++--
> drivers/hid/hid-uclogic-rdesc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
> drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
> drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
> drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
> drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
> drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
> drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
> drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
> drivers/hid/usbhid/hid-pidff.c | 4 +-
> drivers/hid/usbhid/usbkbd.c | 2 +-
> drivers/hid/wacom_sys.c | 2 +-
> include/linux/intel-ish-client-if.h | 8 +++-
> 24 files changed, 90 insertions(+), 81 deletions(-)
>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Anssi Hannula <anssi.hannula@gmail.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Drubin <daniel.drubin@intel.com>
> Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
> Cc: "Krzysztof Wilczyński" <kw@linux.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-iio@vger.kernel.org
> Cc: linux-input@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-usb@vger.kernel.org
> Cc: Lopez Casado <nlopezcasad@logitech.com>
> Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
> Cc: Masaki Ota <masaki.ota@jp.alps.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: message to <vojtech@ucw.cz>
> Cc: Michael Haboustak <mike-@cinci.rr.com>
> Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
> Cc: Vojtech Pavlik <vojtech@suse.cz>
> Cc: Zhang Lixu <lixu.zhang@intel.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-26 11:42 ` Jonathan Cameron
0 siblings, 0 replies; 34+ messages in thread
From: Jonathan Cameron @ 2021-03-26 11:42 UTC (permalink / raw)
To: Lee Jones
Cc: Krzysztof Wilczyński, Zhang Lixu, linux-iio,
Alexandre Torgue, dri-devel, Kai-Heng Feng, Anssi Hannula,
Kim Kuparinen, Srinivas Pandruvada, Dario Pagani, linux-stm32,
Henrik Rydberg, Lopez Casado, Rushikesh S Kadam, Masaki Ota,
Bruno Prémont, Vojtech Pavlik, linux-input, linux-media,
Uwe Kleine-König, message to, Jiri Kosina, L. Vinyard, Jr,
linaro-mm-sig, Michael Haboustak, linux-arm-kernel,
Daniel Drubin, linux-usb, linux-kernel, Benjamin Tissoires,
Maxime Coquelin, Christian König
On Wed, 24 Mar 2021 17:33:39 +0000
Lee Jones <lee.jones@linaro.org> wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
Lee, it's a bit novel to cc linux-iio on the cover letter but
none of the actual patches.. Or least none of them reached
me or lore.kernel.org
I'm sure they are great :)
Jonathan
>
> Lee Jones (25):
> HID: intel-ish-hid: Remove unused variable 'err'
> HID: ishtp-hid-client: Move variable to where it's actually used
> HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> HID: intel-ish: Supply some missing param descriptions
> HID: intel-ish: Fix a naming disparity and a formatting error
> HID: usbhid: Repair a formatting issue in a struct description
> HID: intel-ish-hid: Fix a little doc-rot
> HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> HID: hid-alps: Correct struct misnaming
> HID: intel-ish-hid: Fix potential copy/paste error
> HID: hid-core: Fix incorrect function name in header
> HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> header
> HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> HID: hid-picolcd_core: Remove unused variable 'ret'
> HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> abuses
> HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> HID: hid-uclogic-params: Ensure function names are present and correct
> in kernel-doc headers
> HID: hid-sensor-custom: Remove unused variable 'ret'
> HID: wacom_sys: Demote kernel-doc abuse
> HID: hid-sensor-hub: Remove unused struct member 'quirks'
> HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> definition
> HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
>
> drivers/hid/hid-alps.c | 2 +-
> drivers/hid/hid-core.c | 2 +-
> drivers/hid/hid-kye.c | 2 +-
> drivers/hid/hid-logitech-hidpp.c | 7 +--
> drivers/hid/hid-picolcd_core.c | 5 +--
> drivers/hid/hid-sensor-custom.c | 5 +--
> drivers/hid/hid-sensor-hub.c | 4 +-
> drivers/hid/hid-thrustmaster.c | 24 +++++------
> drivers/hid/hid-uclogic-params.c | 8 ++--
> drivers/hid/hid-uclogic-rdesc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
> drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
> drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
> drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
> drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
> drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
> drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
> drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
> drivers/hid/usbhid/hid-pidff.c | 4 +-
> drivers/hid/usbhid/usbkbd.c | 2 +-
> drivers/hid/wacom_sys.c | 2 +-
> include/linux/intel-ish-client-if.h | 8 +++-
> 24 files changed, 90 insertions(+), 81 deletions(-)
>
> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
> Cc: Anssi Hannula <anssi.hannula@gmail.com>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: Daniel Drubin <daniel.drubin@intel.com>
> Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: Henrik Rydberg <rydberg@bitmath.org>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
> Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
> Cc: "Krzysztof Wilczyński" <kw@linux.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: linaro-mm-sig@lists.linaro.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-iio@vger.kernel.org
> Cc: linux-input@vger.kernel.org
> Cc: linux-media@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-usb@vger.kernel.org
> Cc: Lopez Casado <nlopezcasad@logitech.com>
> Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
> Cc: Masaki Ota <masaki.ota@jp.alps.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: message to <vojtech@ucw.cz>
> Cc: Michael Haboustak <mike-@cinci.rr.com>
> Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
> Cc: Vojtech Pavlik <vojtech@suse.cz>
> Cc: Zhang Lixu <lixu.zhang@intel.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
2021-03-26 11:42 ` Jonathan Cameron
(?)
@ 2021-03-26 14:20 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-26 14:20 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
On Fri, 26 Mar 2021, Jonathan Cameron wrote:
> On Wed, 24 Mar 2021 17:33:39 +0000
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> Lee, it's a bit novel to cc linux-iio on the cover letter but
> none of the actual patches.. Or least none of them reached
> me or lore.kernel.org
Looks like only 18 of the 25 actually made it onto the list.
How odd!
Hold on, I'll submit a [RESEND].
> I'm sure they are great :)
Naturally!
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-26 14:20 ` Lee Jones
0 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-26 14:20 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
On Fri, 26 Mar 2021, Jonathan Cameron wrote:
> On Wed, 24 Mar 2021 17:33:39 +0000
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> Lee, it's a bit novel to cc linux-iio on the cover letter but
> none of the actual patches.. Or least none of them reached
> me or lore.kernel.org
Looks like only 18 of the 25 actually made it onto the list.
How odd!
Hold on, I'll submit a [RESEND].
> I'm sure they are great :)
Naturally!
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-26 14:20 ` Lee Jones
0 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-26 14:20 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Krzysztof Wilczyński, Zhang Lixu, linux-iio,
Alexandre Torgue, dri-devel, Kai-Heng Feng, Anssi Hannula,
Kim Kuparinen, Srinivas Pandruvada, Dario Pagani, linux-stm32,
Henrik Rydberg, Lopez Casado, Rushikesh S Kadam, Masaki Ota,
Bruno Prémont, Vojtech Pavlik, linux-input, linux-media,
Uwe Kleine-König, message to, Jiri Kosina, L. Vinyard, Jr,
linaro-mm-sig, Michael Haboustak, linux-arm-kernel,
Daniel Drubin, linux-usb, linux-kernel, Benjamin Tissoires,
Maxime Coquelin, Christian König
On Fri, 26 Mar 2021, Jonathan Cameron wrote:
> On Wed, 24 Mar 2021 17:33:39 +0000
> Lee Jones <lee.jones@linaro.org> wrote:
>
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
>
> Lee, it's a bit novel to cc linux-iio on the cover letter but
> none of the actual patches.. Or least none of them reached
> me or lore.kernel.org
Looks like only 18 of the 25 actually made it onto the list.
How odd!
Hold on, I'll submit a [RESEND].
> I'm sure they are great :)
Naturally!
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
2021-03-26 14:20 ` Lee Jones
(?)
@ 2021-03-26 14:22 ` Lee Jones
-1 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-26 14:22 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
On Fri, 26 Mar 2021, Lee Jones wrote:
> On Fri, 26 Mar 2021, Jonathan Cameron wrote:
>
> > On Wed, 24 Mar 2021 17:33:39 +0000
> > Lee Jones <lee.jones@linaro.org> wrote:
> >
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> >
> > Lee, it's a bit novel to cc linux-iio on the cover letter but
> > none of the actual patches.. Or least none of them reached
> > me or lore.kernel.org
>
> Looks like only 18 of the 25 actually made it onto the list.
>
> How odd!
Ouch! That's why then:
4.3.0 Temporary System Problem. Try again later (10). p19sm1466367edr.57 - gsmtp
> Hold on, I'll submit a [RESEND].
>
> > I'm sure they are great :)
>
> Naturally!
>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-26 14:22 ` Lee Jones
0 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-26 14:22 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
On Fri, 26 Mar 2021, Lee Jones wrote:
> On Fri, 26 Mar 2021, Jonathan Cameron wrote:
>
> > On Wed, 24 Mar 2021 17:33:39 +0000
> > Lee Jones <lee.jones@linaro.org> wrote:
> >
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> >
> > Lee, it's a bit novel to cc linux-iio on the cover letter but
> > none of the actual patches.. Or least none of them reached
> > me or lore.kernel.org
>
> Looks like only 18 of the 25 actually made it onto the list.
>
> How odd!
Ouch! That's why then:
4.3.0 Temporary System Problem. Try again later (10). p19sm1466367edr.57 - gsmtp
> Hold on, I'll submit a [RESEND].
>
> > I'm sure they are great :)
>
> Naturally!
>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 34+ messages in thread
* Re: [PATCH 00/25] Rid W=1 warnings from HID
@ 2021-03-26 14:22 ` Lee Jones
0 siblings, 0 replies; 34+ messages in thread
From: Lee Jones @ 2021-03-26 14:22 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Krzysztof Wilczyński, Zhang Lixu, linux-iio,
Alexandre Torgue, dri-devel, Kai-Heng Feng, Anssi Hannula,
Kim Kuparinen, Srinivas Pandruvada, Dario Pagani, linux-stm32,
Henrik Rydberg, Lopez Casado, Rushikesh S Kadam, Masaki Ota,
Bruno Prémont, Vojtech Pavlik, linux-input, linux-media,
Uwe Kleine-König, message to, Jiri Kosina, L. Vinyard, Jr,
linaro-mm-sig, Michael Haboustak, linux-arm-kernel,
Daniel Drubin, linux-usb, linux-kernel, Benjamin Tissoires,
Maxime Coquelin, Christian König
On Fri, 26 Mar 2021, Lee Jones wrote:
> On Fri, 26 Mar 2021, Jonathan Cameron wrote:
>
> > On Wed, 24 Mar 2021 17:33:39 +0000
> > Lee Jones <lee.jones@linaro.org> wrote:
> >
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> >
> > Lee, it's a bit novel to cc linux-iio on the cover letter but
> > none of the actual patches.. Or least none of them reached
> > me or lore.kernel.org
>
> Looks like only 18 of the 25 actually made it onto the list.
>
> How odd!
Ouch! That's why then:
4.3.0 Temporary System Problem. Try again later (10). p19sm1466367edr.57 - gsmtp
> Hold on, I'll submit a [RESEND].
>
> > I'm sure they are great :)
>
> Naturally!
>
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 34+ messages in thread
end of thread, other threads:[~2021-03-26 14:24 UTC | newest]
Thread overview: 34+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-24 17:33 [PATCH 00/25] Rid W=1 warnings from HID Lee Jones
2021-03-24 17:33 ` Lee Jones
2021-03-24 17:33 ` Lee Jones
2021-03-24 17:33 ` [PATCH 01/25] HID: intel-ish-hid: Remove unused variable 'err' Lee Jones
2021-03-24 17:33 ` [PATCH 02/25] HID: ishtp-hid-client: Move variable to where it's actually used Lee Jones
2021-03-24 17:33 ` [PATCH 03/25] HID: intel-ish-hid: pci-ish: Remove unused variable 'ret' Lee Jones
2021-03-24 17:33 ` [PATCH 04/25] HID: intel-ish: Supply some missing param descriptions Lee Jones
2021-03-24 17:33 ` [PATCH 05/25] HID: intel-ish: Fix a naming disparity and a formatting error Lee Jones
2021-03-24 17:33 ` [PATCH 06/25] HID: usbhid: Repair a formatting issue in a struct description Lee Jones
2021-03-24 17:33 ` [PATCH 07/25] HID: intel-ish-hid: Fix a little doc-rot Lee Jones
2021-03-24 17:33 ` [PATCH 08/25] HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses Lee Jones
2021-03-24 17:33 ` [PATCH 09/25] HID: hid-alps: Correct struct misnaming Lee Jones
2021-03-24 17:33 ` [PATCH 10/25] HID: intel-ish-hid: Fix potential copy/paste error Lee Jones
2021-03-24 17:33 ` [PATCH 11/25] HID: hid-core: Fix incorrect function name in header Lee Jones
2021-03-24 17:33 ` [PATCH 12/25] HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() " Lee Jones
2021-03-24 17:33 ` [PATCH 13/25] HID: ishtp-hid-client: Fix incorrect function name report_bad_packet() Lee Jones
2021-03-24 17:33 ` [PATCH 14/25] HID: hid-kye: Fix incorrect function name for kye_tablet_enable() Lee Jones
2021-03-24 17:33 ` [PATCH 15/25] HID: hid-picolcd_core: Remove unused variable 'ret' Lee Jones
2021-03-24 17:33 ` [PATCH 16/25] HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote abuses Lee Jones
2021-03-24 17:33 ` [PATCH 17/25] HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs Lee Jones
2021-03-24 17:33 ` [PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses Lee Jones
2021-03-24 17:33 ` Lee Jones
2021-03-24 21:27 ` [PATCH 00/25] Rid W=1 warnings from HID Srinivas Pandruvada
2021-03-24 21:27 ` Srinivas Pandruvada
2021-03-24 21:27 ` Srinivas Pandruvada
2021-03-26 11:42 ` Jonathan Cameron
2021-03-26 11:42 ` Jonathan Cameron
2021-03-26 11:42 ` Jonathan Cameron
2021-03-26 14:20 ` Lee Jones
2021-03-26 14:20 ` Lee Jones
2021-03-26 14:20 ` Lee Jones
2021-03-26 14:22 ` Lee Jones
2021-03-26 14:22 ` Lee Jones
2021-03-26 14:22 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.