From: Randy Dunlap <rdunlap@infradead.org> To: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>, benh@kernel.crashing.org, mpe@ellerman.id.au, gregkh@linuxfoundation.org, arnd@arndb.de Cc: corbet@lwn.net, seroyer@linux.vnet.ibm.com, mrochs@linux.vnet.ibm.com, adreznec@linux.vnet.ibm.com, fbarrat@linux.vnet.ibm.com, davem@davemloft.net, linus.walleij@linaro.org, akpm@linux-foundation.org, mikey@neuling.org, pombredanne@nexb.com, tlfalcon@linux.vnet.ibm.com, msuchanek@suse.de, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v1 1/1] misc: IBM Virtual Management Channel Driver Date: Mon, 23 Apr 2018 11:38:18 -0700 [thread overview] Message-ID: <c07b14b7-8f34-2ba5-536f-85896ff21661@infradead.org> (raw) In-Reply-To: <1524494812-60150-2-git-send-email-bryantly@linux.vnet.ibm.com> On 04/23/18 07:46, Bryant G. Ly wrote: > This driver is a logical device which provides an > interface between the hypervisor and a management > partition. > > This driver is to be used for the POWER Virtual > Management Channel Virtual Adapter on the PowerVM > platform. It provides both request/response and > async message support through the /dev/ibmvmc node. > > Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com> > Reviewed-by: Steven Royer <seroyer@linux.vnet.ibm.com> > Reviewed-by: Adam Reznechek <adreznec@linux.vnet.ibm.com> > Tested-by: Taylor Jakobson <tjakobs@us.ibm.com> > Tested-by: Brad Warrum <bwarrum@us.ibm.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > --- > Documentation/ioctl/ioctl-number.txt | 1 + > Documentation/misc-devices/ibmvmc.txt | 161 +++ > MAINTAINERS | 6 + > arch/powerpc/include/asm/hvcall.h | 1 + > drivers/misc/Kconfig | 14 + > drivers/misc/Makefile | 1 + > drivers/misc/ibmvmc.c | 2415 +++++++++++++++++++++++++++++++++ > drivers/misc/ibmvmc.h | 209 +++ > 8 files changed, 2808 insertions(+) > create mode 100644 Documentation/misc-devices/ibmvmc.txt > create mode 100644 drivers/misc/ibmvmc.c > create mode 100644 drivers/misc/ibmvmc.h > diff --git a/Documentation/misc-devices/ibmvmc.txt b/Documentation/misc-devices/ibmvmc.txt > new file mode 100644 > index 0000000..bae1064 > --- /dev/null > +++ b/Documentation/misc-devices/ibmvmc.txt > @@ -0,0 +1,161 @@ > +Kernel Driver ibmvmc > +==================== > + > +Authors: > + Dave Engebretsen <engebret@us.ibm.com> > + Adam Reznechek <adreznec@linux.vnet.ibm.com> > + Steven Royer <seroyer@linux.vnet.ibm.com> > + Bryant G. Ly <bryantly@linux.vnet.ibm.com> > + > +Description > +=========== > + ... > + > +Virtual Management Channel (VMC) > +A logical device, called the virtual management channel (VMC), is defined > +for communicating between the Novalink application and the hypervisor. > +This device, similar to a VSCSI server device, is presented to a designated > +management partition as a virtual device and is only presented when the > +system is not HMC managed. > +This communication device borrows aspects from both VSCSI and ILLAN devices > +and is implemented using the CRQ and the RDMA interfaces. A three-way > +handshake is defined that must take place to establish that both the > +hypervisor and management partition sides of the channel are running prior > +to sending/receiving any of the protocol messages. > +This driver also utilizes Transport Event CRQs. CRQ messages that are sent Drop "that" ? otherwise the sentence construction is ... odd. > +when the hypervisor detects one of the peer partitions has abnormally > +terminated, or one side has called H_FREE_CRQ to close their CRQ. > +Two new classes of CRQ messages are introduced for the VMC device. VMC > +Administrative messages are used for each partition using the VMC to > +communicate capabilities to their partner. HMC Interface messages are used > +for the actual flow of HMC messages between the management partition and > +the hypervisor. As most HMC messages far exceed the size of a CRQ bugger, what is a bugger? [reads more] oh, buffer? > +a virtual DMA (RMDA) of the HMC message data is done prior to each HMC > +Interface CRQ message. Only the management partition drives RDMA > +operations; hypervisors never directly causes the movement of message data. > + > +Example Management Partition VMC Driver Interface > +================================================= ... Looks pretty good. In general (IMO), it could use more white space (like blank lines after section names.) If you fix those small items (buggers) above, you can add: Reviewed-by: Randy Dunlap <rdunlap@infradead.org> thanks, -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org> To: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>, benh@kernel.crashing.org, mpe@ellerman.id.au, gregkh@linuxfoundation.org, arnd@arndb.de Cc: corbet@lwn.net, seroyer@linux.vnet.ibm.com, mrochs@linux.vnet.ibm.com, adreznec@linux.vnet.ibm.com, fbarrat@linux.vnet.ibm.com, davem@davemloft.net, linus.walleij@linaro.org, akpm@linux-foundation.org, mikey@neuling.org, pombredanne@nexb.com, tlfalcon@linux.vnet.ibm.com, msuchanek@suse.de, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v1 1/1] misc: IBM Virtual Management Channel Driver Date: Mon, 23 Apr 2018 11:38:18 -0700 [thread overview] Message-ID: <c07b14b7-8f34-2ba5-536f-85896ff21661@infradead.org> (raw) In-Reply-To: <1524494812-60150-2-git-send-email-bryantly@linux.vnet.ibm.com> On 04/23/18 07:46, Bryant G. Ly wrote: > This driver is a logical device which provides an > interface between the hypervisor and a management > partition. > > This driver is to be used for the POWER Virtual > Management Channel Virtual Adapter on the PowerVM > platform. It provides both request/response and > async message support through the /dev/ibmvmc node. > > Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com> > Reviewed-by: Steven Royer <seroyer@linux.vnet.ibm.com> > Reviewed-by: Adam Reznechek <adreznec@linux.vnet.ibm.com> > Tested-by: Taylor Jakobson <tjakobs@us.ibm.com> > Tested-by: Brad Warrum <bwarrum@us.ibm.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > --- > Documentation/ioctl/ioctl-number.txt | 1 + > Documentation/misc-devices/ibmvmc.txt | 161 +++ > MAINTAINERS | 6 + > arch/powerpc/include/asm/hvcall.h | 1 + > drivers/misc/Kconfig | 14 + > drivers/misc/Makefile | 1 + > drivers/misc/ibmvmc.c | 2415 +++++++++++++++++++++++++++++++++ > drivers/misc/ibmvmc.h | 209 +++ > 8 files changed, 2808 insertions(+) > create mode 100644 Documentation/misc-devices/ibmvmc.txt > create mode 100644 drivers/misc/ibmvmc.c > create mode 100644 drivers/misc/ibmvmc.h > diff --git a/Documentation/misc-devices/ibmvmc.txt b/Documentation/misc-devices/ibmvmc.txt > new file mode 100644 > index 0000000..bae1064 > --- /dev/null > +++ b/Documentation/misc-devices/ibmvmc.txt > @@ -0,0 +1,161 @@ > +Kernel Driver ibmvmc > +==================== > + > +Authors: > + Dave Engebretsen <engebret@us.ibm.com> > + Adam Reznechek <adreznec@linux.vnet.ibm.com> > + Steven Royer <seroyer@linux.vnet.ibm.com> > + Bryant G. Ly <bryantly@linux.vnet.ibm.com> > + > +Description > +=========== > + ... > + > +Virtual Management Channel (VMC) > +A logical device, called the virtual management channel (VMC), is defined > +for communicating between the Novalink application and the hypervisor. > +This device, similar to a VSCSI server device, is presented to a designated > +management partition as a virtual device and is only presented when the > +system is not HMC managed. > +This communication device borrows aspects from both VSCSI and ILLAN devices > +and is implemented using the CRQ and the RDMA interfaces. A three-way > +handshake is defined that must take place to establish that both the > +hypervisor and management partition sides of the channel are running prior > +to sending/receiving any of the protocol messages. > +This driver also utilizes Transport Event CRQs. CRQ messages that are sent Drop "that" ? otherwise the sentence construction is ... odd. > +when the hypervisor detects one of the peer partitions has abnormally > +terminated, or one side has called H_FREE_CRQ to close their CRQ. > +Two new classes of CRQ messages are introduced for the VMC device. VMC > +Administrative messages are used for each partition using the VMC to > +communicate capabilities to their partner. HMC Interface messages are used > +for the actual flow of HMC messages between the management partition and > +the hypervisor. As most HMC messages far exceed the size of a CRQ bugger, what is a bugger? [reads more] oh, buffer? > +a virtual DMA (RMDA) of the HMC message data is done prior to each HMC > +Interface CRQ message. Only the management partition drives RDMA > +operations; hypervisors never directly causes the movement of message data. > + > +Example Management Partition VMC Driver Interface > +================================================= ... Looks pretty good. In general (IMO), it could use more white space (like blank lines after section names.) If you fix those small items (buggers) above, you can add: Reviewed-by: Randy Dunlap <rdunlap@infradead.org> thanks, -- ~Randy
next prev parent reply other threads:[~2018-04-23 18:38 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-23 14:46 [PATCH v1 0/1] misc: IBM Virtual Management Channel Driver Bryant G. Ly 2018-04-23 14:46 ` Bryant G. Ly 2018-04-23 14:46 ` [PATCH v1 1/1] " Bryant G. Ly 2018-04-23 14:46 ` Bryant G. Ly 2018-04-23 18:38 ` Randy Dunlap [this message] 2018-04-23 18:38 ` Randy Dunlap 2018-04-23 19:53 ` Greg KH 2018-04-23 19:53 ` Greg KH 2018-04-23 21:06 ` Bryant G. Ly 2018-04-23 21:06 ` Bryant G. Ly 2018-04-23 21:17 ` Randy Dunlap 2018-04-23 21:17 ` Randy Dunlap 2018-04-24 14:29 ` Greg KH 2018-04-24 14:29 ` Greg KH 2018-04-24 15:21 ` Randy Dunlap 2018-04-24 15:21 ` Randy Dunlap 2018-04-25 8:29 ` Linus Walleij 2018-04-25 8:29 ` Linus Walleij 2018-04-25 12:00 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c07b14b7-8f34-2ba5-536f-85896ff21661@infradead.org \ --to=rdunlap@infradead.org \ --cc=adreznec@linux.vnet.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=benh@kernel.crashing.org \ --cc=bryantly@linux.vnet.ibm.com \ --cc=corbet@lwn.net \ --cc=davem@davemloft.net \ --cc=fbarrat@linux.vnet.ibm.com \ --cc=gregkh@linuxfoundation.org \ --cc=linus.walleij@linaro.org \ --cc=linux-doc@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mikey@neuling.org \ --cc=mpe@ellerman.id.au \ --cc=mrochs@linux.vnet.ibm.com \ --cc=msuchanek@suse.de \ --cc=pombredanne@nexb.com \ --cc=seroyer@linux.vnet.ibm.com \ --cc=tlfalcon@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.