Re: [OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Thomas Perrot <thomas.perrot@bootlin.com>]

[-- Attachment #1: Type: text/plain, Size: 3876 bytes --]

Hello Alex,

On Wed, 2022-10-05 at 19:09 +0200, Alexander Kanavin wrote:
> > Does core-image-weston have the same problem? If it does, then this
> > certainly needs to go to qemu include in conf/machine/
> > 

Yes, the same issue occurs on core-image-weston, when
NO_RECOMMENDATIONS = "1".

So, instead of adding this rdepends in the sato image, I can add
kernel-module-virtio-input in MACHINE_EXTRA_RDEPENDS in
conf/machine/include/qemu.inc.

In addition, I'm looking to use a built-in virtio-input, as proposed by
	Bruce Ashfield.

Kind regards,
Thomas

> > Alex
> > 
> > On Wed, 5 Oct 2022 at 18:51, Thomas Perrot via
> > lists.openembedded.org
> > <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
> > > > 
> > > > Hello Khem,
> > > > 
> > > > On Wed, 2022-10-05 at 09:19 -0700, Khem Raj wrote:
> > > > > > On Wed, Oct 5, 2022 at 8:01 AM Thomas Perrot via
> > > > > > lists.openembedded.org
> > > > > > <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
> > > > > > > > 
> > > > > > > > Otherwise, it isn't possible to interact with the UI.
> > > > > > 
> > > > > > I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS
> > > > > > in > > > machine
> > > > > > configs, it will help a wide range of users who may be
> > > > > > using
> > > > > > graphical images.
> > > > 
> > > > I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu
> > > > targets.
> > > > 
> > > > Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of
> > > > Qemu
> > > > RISC-V and PPC64, which are not installed when > >
> > > > NO_RECOMMENDATIONS="1"
> > > > 
> > > > Kind regards,
> > > > Thomas
> > > > 
> > > > > > 
> > > > > > > > 
> > > > > > > > Signed-off-by: Thomas Perrot
> > > > > > > > <thomas.perrot@bootlin.com>
> > > > > > > > ---
> > > > > > > >  meta/recipes-sato/images/core-image-sato.bb | 2 ++
> > > > > > > >  1 file changed, 2 insertions(+)
> > > > > > > > 
> > > > > > > > diff --git a/meta/recipes-sato/images/core-image-
> > > > > > > > sato.bb
> > > > > > > > b/meta/recipes-sato/images/core-image-sato.bb
> > > > > > > > index e63a229d1257..0e37c15097b3 100644
> > > > > > > > --- a/meta/recipes-sato/images/core-image-sato.bb
> > > > > > > > +++ b/meta/recipes-sato/images/core-image-sato.bb
> > > > > > > > @@ -12,6 +12,8 @@ inherit core-image
> > > > > > > >  TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool > >
> > > > > > > > > > nativesdk-glib-
> > > > > > > > 2.0"
> > > > > > > >  TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " >
> > > > > > > > > > > nativesdk-
> > > > > > > > intltool nativesdk-glib-2.0"
> > > > > > > > 
> > > > > > > > +IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-
> > > > > > > > input"
> > > > > > > > +
> > > > > > > >  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES",
> > > > > > > > "opengl", > > > > "-m
> > > > > > > > 512", "-m 256", d)}'
> > > > > > > >  QB_MEM:qemuarmv5 = "-m 256"
> > > > > > > >  QB_MEM:qemumips = "-m 256"
> > > > > > > > --
> > > > > > > > 2.37.3
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > 
> > > > --
> > > > Thomas Perrot, Bootlin
> > > > Embedded Linux and kernel engineering
> > > > https://bootlin.com
> > > > 
> > > > 
> > > > 
> > > > 
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#171469): >
> > https://lists.openembedded.org/g/openembedded-core/message/171469
> > Mute This Topic: https://lists.openembedded.org/mt/94137249/5443093
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe:
> > https://lists.openembedded.org/g/openembedded-core/unsub>
> >  [thomas.perrot@bootlin.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> > 

-- 
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 659 bytes --]