Re: [OE-core][PATCH] core-image-sato: install virtio input for Qemu targets

[Bruce Ashfield <bruce.ashfield@gmail.com>]

On Wed, Oct 5, 2022 at 12:51 PM Thomas Perrot via
lists.openembedded.org
<thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
>
> Hello Khem,
>
> On Wed, 2022-10-05 at 09:19 -0700, Khem Raj wrote:
> > On Wed, Oct 5, 2022 at 8:01 AM Thomas Perrot via
> > lists.openembedded.org
> > <thomas.perrot=bootlin.com@lists.openembedded.org> wrote:
> > >
> > > Otherwise, it isn't possible to interact with the UI.
> >
> > I wonder if it should be in the MACHINE_EXTRA_RRECOMMENDS in machine
> > configs, it will help a wide range of users who may be using
> > graphical images.
>
> I hesitated to put it in MACHINE_EXTRA_RDEPENDS for Qemu targets.
>
> Currently, kernel-modules are in MACHINE_EXTRA_RRECOMMENDS of Qemu
> RISC-V and PPC64, which are not installed when NO_RECOMMENDATIONS="1"
>

We don't control the kernel configuration to the point where we can
guarantee that something is built as a module or not.

Have you tried assembling the image with that option built-in, versus
a module ? Last I checked, a kernel-module* dependency won't be
provided by the built-ins, and this will trigger an error.

With that option appended, it isn't something that can be overridden
easily, and the qemu* + core images are used as a starting point for
demos, etc (whether or not that is a good idea is also debatable). If
a non-core kernel provider and qemu are used in a scenario like that
.. they can trigger the error.

Bruce

> Kind regards,
> Thomas
>
> >
> > >
> > > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> > > ---
> > >  meta/recipes-sato/images/core-image-sato.bb | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/meta/recipes-sato/images/core-image-sato.bb
> > > b/meta/recipes-sato/images/core-image-sato.bb
> > > index e63a229d1257..0e37c15097b3 100644
> > > --- a/meta/recipes-sato/images/core-image-sato.bb
> > > +++ b/meta/recipes-sato/images/core-image-sato.bb
> > > @@ -12,6 +12,8 @@ inherit core-image
> > >  TOOLCHAIN_HOST_TASK:append = " nativesdk-intltool nativesdk-glib-
> > > 2.0"
> > >  TOOLCHAIN_HOST_TASK:remove:task-populate-sdk-ext = " nativesdk-
> > > intltool nativesdk-glib-2.0"
> > >
> > > +IMAGE_INSTALL:append:qemuall = " kernel-module-virtio-input"
> > > +
> > >  QB_MEM = '${@bb.utils.contains("DISTRO_FEATURES", "opengl", "-m
> > > 512", "-m 256", d)}'
> > >  QB_MEM:qemuarmv5 = "-m 256"
> > >  QB_MEM:qemumips = "-m 256"
> > > --
> > > 2.37.3
> > >
> > >
> > >
> > >
>
> --
> Thomas Perrot, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#171468): https://lists.openembedded.org/g/openembedded-core/message/171468
> Mute This Topic: https://lists.openembedded.org/mt/94137249/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II