* [PATCH] Makefile: Remove version from /usr/share/makedumpfile
@ 2022-10-21 10:24 Leonidas Spyropoulos
2022-10-24 2:25 ` HAGIO KAZUHITO(萩尾 一仁)
0 siblings, 1 reply; 3+ messages in thread
From: Leonidas Spyropoulos @ 2022-10-21 10:24 UTC (permalink / raw)
To: kexec; +Cc: Leonidas Spyropoulos
Version specific paths doesn't make sense at
/usr/share/makedumpfile. This assumes you will have only one version
installed which on a normal system it makes sense and devs can always
specify different DESTDIR per versions.
Fixes: #10
Signed-off-by: Leonidas Spyropoulos <artafinde@archlinux.org>
---
Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 548e5b7..f6ecbe2 100644
--- a/Makefile
+++ b/Makefile
@@ -130,6 +130,6 @@ install:
install -m 755 -t ${DESTDIR}/usr/sbin makedumpfile $(VPATH)makedumpfile-R.pl
install -m 644 -t ${DESTDIR}/usr/share/man/man8 makedumpfile.8
install -m 644 -t ${DESTDIR}/usr/share/man/man5 makedumpfile.conf.5
- mkdir -p ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts
- install -m 644 -D $(VPATH)makedumpfile.conf ${DESTDIR}/usr/share/makedumpfile-${VERSION}/makedumpfile.conf.sample
- install -m 644 -t ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts/ $(VPATH)eppic_scripts/*
+ mkdir -p ${DESTDIR}/usr/share/makedumpfile/eppic_scripts
+ install -m 644 -D $(VPATH)makedumpfile.conf ${DESTDIR}/usr/share/makedumpfile/makedumpfile.conf.sample
+ install -m 644 -t ${DESTDIR}/usr/share/makedumpfile/eppic_scripts/ $(VPATH)eppic_scripts/*
--
2.38.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: Remove version from /usr/share/makedumpfile
2022-10-21 10:24 [PATCH] Makefile: Remove version from /usr/share/makedumpfile Leonidas Spyropoulos
@ 2022-10-24 2:25 ` HAGIO KAZUHITO(萩尾 一仁)
2022-10-27 0:40 ` HAGIO KAZUHITO(萩尾 一仁)
0 siblings, 1 reply; 3+ messages in thread
From: HAGIO KAZUHITO(萩尾 一仁) @ 2022-10-24 2:25 UTC (permalink / raw)
To: Leonidas Spyropoulos, kexec
On 2022/10/21 19:24, Leonidas Spyropoulos wrote:
> Version specific paths doesn't make sense at
> /usr/share/makedumpfile. This assumes you will have only one version
> installed which on a normal system it makes sense and devs can always
> specify different DESTDIR per versions.
>
> Fixes: #10
>
> Signed-off-by: Leonidas Spyropoulos <artafinde@archlinux.org>
Thanks for the patch.
I agree.
The patch [1] introduced the directory with ${VERSION}, but makedumpfile
has backward compatibility and the directory does not have any data that
has version restraint, so I don't see any reason. Also I didn't find any
discussion in the list archive.
I will merge this a few days later if no objection.
Thanks,
Kazu
[1] https://github.com/makedumpfile/makedumpfile/commit/41e1ccfcd57736047a5c52d8096fbcaa255146ec
> ---
> Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 548e5b7..f6ecbe2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -130,6 +130,6 @@ install:
> install -m 755 -t ${DESTDIR}/usr/sbin makedumpfile $(VPATH)makedumpfile-R.pl
> install -m 644 -t ${DESTDIR}/usr/share/man/man8 makedumpfile.8
> install -m 644 -t ${DESTDIR}/usr/share/man/man5 makedumpfile.conf.5
> - mkdir -p ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts
> - install -m 644 -D $(VPATH)makedumpfile.conf ${DESTDIR}/usr/share/makedumpfile-${VERSION}/makedumpfile.conf.sample
> - install -m 644 -t ${DESTDIR}/usr/share/makedumpfile-${VERSION}/eppic_scripts/ $(VPATH)eppic_scripts/*
> + mkdir -p ${DESTDIR}/usr/share/makedumpfile/eppic_scripts
> + install -m 644 -D $(VPATH)makedumpfile.conf ${DESTDIR}/usr/share/makedumpfile/makedumpfile.conf.sample
> + install -m 644 -t ${DESTDIR}/usr/share/makedumpfile/eppic_scripts/ $(VPATH)eppic_scripts/*
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: Remove version from /usr/share/makedumpfile
2022-10-24 2:25 ` HAGIO KAZUHITO(萩尾 一仁)
@ 2022-10-27 0:40 ` HAGIO KAZUHITO(萩尾 一仁)
0 siblings, 0 replies; 3+ messages in thread
From: HAGIO KAZUHITO(萩尾 一仁) @ 2022-10-27 0:40 UTC (permalink / raw)
To: Leonidas Spyropoulos, kexec
On 2022/10/24 11:25, HAGIO KAZUHITO(萩尾 一仁) wrote:
> On 2022/10/21 19:24, Leonidas Spyropoulos wrote:
>> Version specific paths doesn't make sense at
>> /usr/share/makedumpfile. This assumes you will have only one version
>> installed which on a normal system it makes sense and devs can always
>> specify different DESTDIR per versions.
>>
>> Fixes: #10
>>
>> Signed-off-by: Leonidas Spyropoulos <artafinde@archlinux.org>
>
> Thanks for the patch.
>
> I agree.
>
> The patch [1] introduced the directory with ${VERSION}, but makedumpfile
> has backward compatibility and the directory does not have any data that
> has version restraint, so I don't see any reason. Also I didn't find any
> discussion in the list archive.
>
> I will merge this a few days later if no objection.
Applied.
https://github.com/makedumpfile/makedumpfile/commit/f1d84a5d69d81bc7a89aefae504be88df1e50693
Thanks,
Kazu
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-27 0:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-21 10:24 [PATCH] Makefile: Remove version from /usr/share/makedumpfile Leonidas Spyropoulos
2022-10-24 2:25 ` HAGIO KAZUHITO(萩尾 一仁)
2022-10-27 0:40 ` HAGIO KAZUHITO(萩尾 一仁)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.