[PATCH] perf.bb: Fix dependency while building kernel using externalsrc

[PATCH] perf.bb: Fix dependency while building kernel using externalsrc

[Manjukumar Matha]

Having dependency on do_patch will fail while building kernel using
externalsrc. Depend on do_configure instead of do_patch to bypass the
compilation error.

Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
---
 meta/classes/kernelsrc.bbclass   | 2 +-
 meta/recipes-kernel/perf/perf.bb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/kernelsrc.bbclass b/meta/classes/kernelsrc.bbclass
index 675d40e..35cf49e 100644
--- a/meta/classes/kernelsrc.bbclass
+++ b/meta/classes/kernelsrc.bbclass
@@ -1,7 +1,7 @@
 S = "${STAGING_KERNEL_DIR}"
 deltask do_fetch
 deltask do_unpack
-do_patch[depends] += "virtual/kernel:do_patch"
+do_patch[depends] += "virtual/kernel:do_configure"
 do_patch[noexec] = "1"
 do_package[depends] += "virtual/kernel:do_populate_sysroot"
 KERNEL_VERSION = "${@get_kernelversion_file("${STAGING_KERNEL_BUILDDIR}")}"
diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index ffaa5f6..b13f8e4 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -45,7 +45,7 @@ export PYTHON_SITEPACKAGES_DIR
 #kernel 3.1+ supports WERROR to disable warnings as errors
 export WERROR = "0"
 
-do_populate_lic[depends] += "virtual/kernel:do_patch"
+do_populate_lic[depends] += "virtual/kernel:do_configure"
 
 # needed for building the tools/perf Perl binding
 inherit perlnative cpan-base
-- 
2.7.4

Re: [PATCH] perf.bb: Fix dependency while building kernel using externalsrc

[Andre McCurdy]

On Thu, Mar 2, 2017 at 11:59 PM, Manjukumar Matha
<manjukumar.harthikote-matha@xilinx.com> wrote:
> Having dependency on do_patch will fail while building kernel using
> externalsrc. Depend on do_configure instead of do_patch to bypass the
> compilation error.

I think the change to kernelsrc.bbclass is perhaps more significant
than the change to perf.bb, so the commit message prefix should
probably be kernelsrc.bbclass: rather than perf:

Maybe even spilt into two commits.

> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
> ---
>  meta/classes/kernelsrc.bbclass   | 2 +-
>  meta/recipes-kernel/perf/perf.bb | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/kernelsrc.bbclass b/meta/classes/kernelsrc.bbclass
> index 675d40e..35cf49e 100644
> --- a/meta/classes/kernelsrc.bbclass
> +++ b/meta/classes/kernelsrc.bbclass
> @@ -1,7 +1,7 @@
>  S = "${STAGING_KERNEL_DIR}"
>  deltask do_fetch
>  deltask do_unpack
> -do_patch[depends] += "virtual/kernel:do_patch"
> +do_patch[depends] += "virtual/kernel:do_configure"
>  do_patch[noexec] = "1"
>  do_package[depends] += "virtual/kernel:do_populate_sysroot"
>  KERNEL_VERSION = "${@get_kernelversion_file("${STAGING_KERNEL_BUILDDIR}")}"
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index ffaa5f6..b13f8e4 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -45,7 +45,7 @@ export PYTHON_SITEPACKAGES_DIR
>  #kernel 3.1+ supports WERROR to disable warnings as errors
>  export WERROR = "0"
>
> -do_populate_lic[depends] += "virtual/kernel:do_patch"
> +do_populate_lic[depends] += "virtual/kernel:do_configure"
>
>  # needed for building the tools/perf Perl binding
>  inherit perlnative cpan-base
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] perf.bb: Fix dependency while building kernel using externalsrc

[Manjukumar Harthikote Matha]

Hi Andre,

On 03/08/2017 12:23 PM, Andre McCurdy wrote:
> On Thu, Mar 2, 2017 at 11:59 PM, Manjukumar Matha
> <manjukumar.harthikote-matha@xilinx.com> wrote:
>> Having dependency on do_patch will fail while building kernel using
>> externalsrc. Depend on do_configure instead of do_patch to bypass the
>> compilation error.
>
> I think the change to kernelsrc.bbclass is perhaps more significant
> than the change to perf.bb, so the commit message prefix should
> probably be kernelsrc.bbclass: rather than perf:
>
> Maybe even spilt into two commits.
>
Sure will send a v2

Thanks
Manju

>> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.com>
>> ---
>>  meta/classes/kernelsrc.bbclass   | 2 +-
>>  meta/recipes-kernel/perf/perf.bb | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/kernelsrc.bbclass b/meta/classes/kernelsrc.bbclass
>> index 675d40e..35cf49e 100644
>> --- a/meta/classes/kernelsrc.bbclass
>> +++ b/meta/classes/kernelsrc.bbclass
>> @@ -1,7 +1,7 @@
>>  S = "${STAGING_KERNEL_DIR}"
>>  deltask do_fetch
>>  deltask do_unpack
>> -do_patch[depends] += "virtual/kernel:do_patch"
>> +do_patch[depends] += "virtual/kernel:do_configure"
>>  do_patch[noexec] = "1"
>>  do_package[depends] += "virtual/kernel:do_populate_sysroot"
>>  KERNEL_VERSION = "${@get_kernelversion_file("${STAGING_KERNEL_BUILDDIR}")}"
>> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
>> index ffaa5f6..b13f8e4 100644
>> --- a/meta/recipes-kernel/perf/perf.bb
>> +++ b/meta/recipes-kernel/perf/perf.bb
>> @@ -45,7 +45,7 @@ export PYTHON_SITEPACKAGES_DIR
>>  #kernel 3.1+ supports WERROR to disable warnings as errors
>>  export WERROR = "0"
>>
>> -do_populate_lic[depends] += "virtual/kernel:do_patch"
>> +do_populate_lic[depends] += "virtual/kernel:do_configure"
>>
>>  # needed for building the tools/perf Perl binding
>>  inherit perlnative cpan-base
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core