[PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Ivan T. Ivanov]

Add missing clock required by RPiVid video decoder and provide more
reliable and accurate source for HDMI pixel and video encoder clocks.

Changes since v3
- Put back support for VEC clock, which was actually one of
  reasons for this patch-set [1]. I mixed "HEVC" vs. "VEC", sorry.

  [1] https://bugzilla.suse.com/show_bug.cgi?id=1198942

Changes since v2
- Added Acks from Maxime Ripard and Dave Stevenson

Changes since v1
- Drop RPI_FIRMWARE_VEC_CLK_ID clock it doesn't seems to be used.
- Rework downstream changes on top of recent Maxime changes.

Dom Cobley (1):
  clk: bcm: rpi: Add support for VEC clock

Ivan T. Ivanov (2):
  clk: bcm: rpi: Add support HEVC clock
  clk: bcm: rpi: Handle pixel clock in firmware

 drivers/clk/bcm/clk-raspberrypi.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

-- 
2.34.1

[PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Ivan T. Ivanov]

Add missing clock required by RPiVid video decoder and provide more
reliable and accurate source for HDMI pixel and video encoder clocks.

Changes since v3
- Put back support for VEC clock, which was actually one of
  reasons for this patch-set [1]. I mixed "HEVC" vs. "VEC", sorry.

  [1] https://bugzilla.suse.com/show_bug.cgi?id=1198942

Changes since v2
- Added Acks from Maxime Ripard and Dave Stevenson

Changes since v1
- Drop RPI_FIRMWARE_VEC_CLK_ID clock it doesn't seems to be used.
- Rework downstream changes on top of recent Maxime changes.

Dom Cobley (1):
  clk: bcm: rpi: Add support for VEC clock

Ivan T. Ivanov (2):
  clk: bcm: rpi: Add support HEVC clock
  clk: bcm: rpi: Handle pixel clock in firmware

 drivers/clk/bcm/clk-raspberrypi.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v4 1/3] clk: bcm: rpi: Add support HEVC clock

[Ivan T. Ivanov]

Export clock required for RPiVid video decoder hardware.

Cc: Dom Cobley <popcornmix@gmail.com>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
 drivers/clk/bcm/clk-raspberrypi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 9d09621549b9..2e2491d85835 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_V3D_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_HEVC_CLK_ID] = {
+		.export = true,
+	},
 	[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = {
 		.export = true,
 	},
-- 
2.34.1

[PATCH v4 1/3] clk: bcm: rpi: Add support HEVC clock

[Ivan T. Ivanov]

Export clock required for RPiVid video decoder hardware.

Cc: Dom Cobley <popcornmix@gmail.com>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
 drivers/clk/bcm/clk-raspberrypi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 9d09621549b9..2e2491d85835 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_V3D_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_HEVC_CLK_ID] = {
+		.export = true,
+	},
 	[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = {
 		.export = true,
 	},
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v4 2/3] clk: bcm: rpi: Handle pixel clock in firmware

[Ivan T. Ivanov]

The clk-bcm2835 handling of the pixel clock does not function
correctly when the HDMI power domain is disabled.

The firmware supports it correctly, so add it to the
firmware clock driver.

Acked-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
 drivers/clk/bcm/clk-raspberrypi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 2e2491d85835..530820d13104 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_V3D_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_PIXEL_CLK_ID] = {
+		.export = true,
+	},
 	[RPI_FIRMWARE_HEVC_CLK_ID] = {
 		.export = true,
 	},
-- 
2.34.1

[PATCH v4 2/3] clk: bcm: rpi: Handle pixel clock in firmware

[Ivan T. Ivanov]

The clk-bcm2835 handling of the pixel clock does not function
correctly when the HDMI power domain is disabled.

The firmware supports it correctly, so add it to the
firmware clock driver.

Acked-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
 drivers/clk/bcm/clk-raspberrypi.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 2e2491d85835..530820d13104 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -129,6 +129,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_V3D_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_PIXEL_CLK_ID] = {
+		.export = true,
+	},
 	[RPI_FIRMWARE_HEVC_CLK_ID] = {
 		.export = true,
 	},
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v4 3/3] clk: bcm: rpi: Add support for VEC clock

[Ivan T. Ivanov]

From: Dom Cobley <popcornmix@gmail.com>

Platform driver clk-bcm2835 gets an inaccurate clock for VEC (107MHz).
Export VEC clock trough clk-raspberrypi which uses the right PLL to
get an accurate 108MHz.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
[iivanov: Adapted on top of v5.17-rc6]
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
 drivers/clk/bcm/clk-raspberrypi.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 530820d13104..d1dd01580573 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -33,6 +33,7 @@ enum rpi_firmware_clk_id {
 	RPI_FIRMWARE_EMMC2_CLK_ID,
 	RPI_FIRMWARE_M2MC_CLK_ID,
 	RPI_FIRMWARE_PIXEL_BVB_CLK_ID,
+	RPI_FIRMWARE_VEC_CLK_ID,
 	RPI_FIRMWARE_NUM_CLK_ID,
 };
 
@@ -51,6 +52,7 @@ static char *rpi_firmware_clk_names[] = {
 	[RPI_FIRMWARE_EMMC2_CLK_ID]	= "emmc2",
 	[RPI_FIRMWARE_M2MC_CLK_ID]	= "m2mc",
 	[RPI_FIRMWARE_PIXEL_BVB_CLK_ID]	= "pixel-bvb",
+	[RPI_FIRMWARE_VEC_CLK_ID]	= "vec",
 };
 
 #define RPI_FIRMWARE_STATE_ENABLE_BIT	BIT(0)
@@ -138,6 +140,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_VEC_CLK_ID] = {
+		.export = true,
+	},
 };
 
 /*
-- 
2.34.1

[PATCH v4 3/3] clk: bcm: rpi: Add support for VEC clock

[Ivan T. Ivanov]

From: Dom Cobley <popcornmix@gmail.com>

Platform driver clk-bcm2835 gets an inaccurate clock for VEC (107MHz).
Export VEC clock trough clk-raspberrypi which uses the right PLL to
get an accurate 108MHz.

Signed-off-by: Dom Cobley <popcornmix@gmail.com>
[iivanov: Adapted on top of v5.17-rc6]
Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>
---
 drivers/clk/bcm/clk-raspberrypi.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
index 530820d13104..d1dd01580573 100644
--- a/drivers/clk/bcm/clk-raspberrypi.c
+++ b/drivers/clk/bcm/clk-raspberrypi.c
@@ -33,6 +33,7 @@ enum rpi_firmware_clk_id {
 	RPI_FIRMWARE_EMMC2_CLK_ID,
 	RPI_FIRMWARE_M2MC_CLK_ID,
 	RPI_FIRMWARE_PIXEL_BVB_CLK_ID,
+	RPI_FIRMWARE_VEC_CLK_ID,
 	RPI_FIRMWARE_NUM_CLK_ID,
 };
 
@@ -51,6 +52,7 @@ static char *rpi_firmware_clk_names[] = {
 	[RPI_FIRMWARE_EMMC2_CLK_ID]	= "emmc2",
 	[RPI_FIRMWARE_M2MC_CLK_ID]	= "m2mc",
 	[RPI_FIRMWARE_PIXEL_BVB_CLK_ID]	= "pixel-bvb",
+	[RPI_FIRMWARE_VEC_CLK_ID]	= "vec",
 };
 
 #define RPI_FIRMWARE_STATE_ENABLE_BIT	BIT(0)
@@ -138,6 +140,9 @@ raspberrypi_clk_variants[RPI_FIRMWARE_NUM_CLK_ID] = {
 	[RPI_FIRMWARE_PIXEL_BVB_CLK_ID] = {
 		.export = true,
 	},
+	[RPI_FIRMWARE_VEC_CLK_ID] = {
+		.export = true,
+	},
 };
 
 /*
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 3/3] clk: bcm: rpi: Add support for VEC clock

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

On Thu, Apr 28, 2022 at 09:57:43AM +0300, Ivan T. Ivanov wrote:
> From: Dom Cobley <popcornmix@gmail.com>
> 
> Platform driver clk-bcm2835 gets an inaccurate clock for VEC (107MHz).
> Export VEC clock trough clk-raspberrypi which uses the right PLL to
> get an accurate 108MHz.
> 
> Signed-off-by: Dom Cobley <popcornmix@gmail.com>
> [iivanov: Adapted on top of v5.17-rc6]
> Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>

Acked-by: Maxime Ripard <maxime@cerno.tech>

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 3/3] clk: bcm: rpi: Add support for VEC clock

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 490 bytes --]

On Thu, Apr 28, 2022 at 09:57:43AM +0300, Ivan T. Ivanov wrote:
> From: Dom Cobley <popcornmix@gmail.com>
> 
> Platform driver clk-bcm2835 gets an inaccurate clock for VEC (107MHz).
> Export VEC clock trough clk-raspberrypi which uses the right PLL to
> get an accurate 108MHz.
> 
> Signed-off-by: Dom Cobley <popcornmix@gmail.com>
> [iivanov: Adapted on top of v5.17-rc6]
> Signed-off-by: Ivan T. Ivanov <iivanov@suse.de>

Acked-by: Maxime Ripard <maxime@cerno.tech>

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Guillaume Gardet]

Hi,

May I ask what's the status/plan of  this patch series?

It seems it has not been merged yet, and I know we are a bit late in the 5.18 schedule, but I think this is a good fix for 5.18. 
And, this looks like to be a good candidate for a backport to stable kernels.

Thanks,
Guillaume


> -----Original Message-----
> From: Ivan T. Ivanov <iivanov@suse.de>
> Sent: 28 April 2022 08:58
> To: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd
> <sboyd@kernel.org>; Nicolas Saenz Julienne <nsaenz@kernel.org>
> Cc: Maxime Ripard <maxime@cerno.tech>; Dave Stevenson
> <dave.stevenson@raspberrypi.com>; Guillaume Gardet
> <Guillaume.Gardet@arm.com>; bcm-kernel-feedback-list@broadcom.com;
> linux-clk@vger.kernel.org; linux-rpi-kernel@lists.infradead.org; linux-arm-
> kernel@lists.infradead.org; Ivan T. Ivanov <iivanov@suse.de>
> Subject: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks
> 
> Add missing clock required by RPiVid video decoder and provide more reliable
> and accurate source for HDMI pixel and video encoder clocks.
> 
> Changes since v3
> - Put back support for VEC clock, which was actually one of
>   reasons for this patch-set [1]. I mixed "HEVC" vs. "VEC", sorry.
> 
>   [1] https://bugzilla.suse.com/show_bug.cgi?id=1198942
> 
> Changes since v2
> - Added Acks from Maxime Ripard and Dave Stevenson
> 
> Changes since v1
> - Drop RPI_FIRMWARE_VEC_CLK_ID clock it doesn't seems to be used.
> - Rework downstream changes on top of recent Maxime changes.
> 
> Dom Cobley (1):
>   clk: bcm: rpi: Add support for VEC clock
> 
> Ivan T. Ivanov (2):
>   clk: bcm: rpi: Add support HEVC clock
>   clk: bcm: rpi: Handle pixel clock in firmware
> 
>  drivers/clk/bcm/clk-raspberrypi.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> --
> 2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Guillaume Gardet]

Hi,

May I ask what's the status/plan of  this patch series?

It seems it has not been merged yet, and I know we are a bit late in the 5.18 schedule, but I think this is a good fix for 5.18. 
And, this looks like to be a good candidate for a backport to stable kernels.

Thanks,
Guillaume


> -----Original Message-----
> From: Ivan T. Ivanov <iivanov@suse.de>
> Sent: 28 April 2022 08:58
> To: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd
> <sboyd@kernel.org>; Nicolas Saenz Julienne <nsaenz@kernel.org>
> Cc: Maxime Ripard <maxime@cerno.tech>; Dave Stevenson
> <dave.stevenson@raspberrypi.com>; Guillaume Gardet
> <Guillaume.Gardet@arm.com>; bcm-kernel-feedback-list@broadcom.com;
> linux-clk@vger.kernel.org; linux-rpi-kernel@lists.infradead.org; linux-arm-
> kernel@lists.infradead.org; Ivan T. Ivanov <iivanov@suse.de>
> Subject: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks
> 
> Add missing clock required by RPiVid video decoder and provide more reliable
> and accurate source for HDMI pixel and video encoder clocks.
> 
> Changes since v3
> - Put back support for VEC clock, which was actually one of
>   reasons for this patch-set [1]. I mixed "HEVC" vs. "VEC", sorry.
> 
>   [1] https://bugzilla.suse.com/show_bug.cgi?id=1198942
> 
> Changes since v2
> - Added Acks from Maxime Ripard and Dave Stevenson
> 
> Changes since v1
> - Drop RPI_FIRMWARE_VEC_CLK_ID clock it doesn't seems to be used.
> - Rework downstream changes on top of recent Maxime changes.
> 
> Dom Cobley (1):
>   clk: bcm: rpi: Add support for VEC clock
> 
> Ivan T. Ivanov (2):
>   clk: bcm: rpi: Add support HEVC clock
>   clk: bcm: rpi: Handle pixel clock in firmware
> 
>  drivers/clk/bcm/clk-raspberrypi.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> --
> 2.34.1

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 556 bytes --]

Hi,

On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
> May I ask what's the status/plan of  this patch series?

As far as I know it hasn't been merged yet.

> It seems it has not been merged yet, and I know we are a bit late in
> the 5.18 schedule, but I think this is a good fix for 5.18.

Fix for what? I don't think this series fix any bug?

> And, this looks like to be a good candidate for a backport to stable
> kernels.

This is not going to be trivial to backmerge, it depends on 12c90f3f27bb
that isn't marked for stable

maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

Hi,

On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
> May I ask what's the status/plan of  this patch series?

As far as I know it hasn't been merged yet.

> It seems it has not been merged yet, and I know we are a bit late in
> the 5.18 schedule, but I think this is a good fix for 5.18.

Fix for what? I don't think this series fix any bug?

> And, this looks like to be a good candidate for a backport to stable
> kernels.

This is not going to be trivial to backmerge, it depends on 12c90f3f27bb
that isn't marked for stable

maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Stefan Wahren]

Am 10.05.22 um 15:30 schrieb Maxime Ripard:
> Hi,
>
> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
>> May I ask what's the status/plan of  this patch series?
> As far as I know it hasn't been merged yet.
>
>> It seems it has not been merged yet, and I know we are a bit late in
>> the 5.18 schedule, but I think this is a good fix for 5.18.
> Fix for what? I don't think this series fix any bug?
This seems to be a "fix" for the Frankenstone scenario: mainline kernel 
+ vendor DT
>> And, this looks like to be a good candidate for a backport to stable
>> kernels.
> This is not going to be trivial to backmerge, it depends on 12c90f3f27bb
> that isn't marked for stable

I don't think this is a good idea to backmerge these changes.

Best regards

>
> maxime
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Stefan Wahren]

Am 10.05.22 um 15:30 schrieb Maxime Ripard:
> Hi,
>
> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
>> May I ask what's the status/plan of  this patch series?
> As far as I know it hasn't been merged yet.
>
>> It seems it has not been merged yet, and I know we are a bit late in
>> the 5.18 schedule, but I think this is a good fix for 5.18.
> Fix for what? I don't think this series fix any bug?
This seems to be a "fix" for the Frankenstone scenario: mainline kernel 
+ vendor DT
>> And, this looks like to be a good candidate for a backport to stable
>> kernels.
> This is not going to be trivial to backmerge, it depends on 12c90f3f27bb
> that isn't marked for stable

I don't think this is a good idea to backmerge these changes.

Best regards

>
> maxime
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

On Wed, May 11, 2022 at 08:10:50AM +0200, Stefan Wahren wrote:
> Am 10.05.22 um 15:30 schrieb Maxime Ripard:
> > Hi,
> > 
> > On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
> > > May I ask what's the status/plan of  this patch series?
> > As far as I know it hasn't been merged yet.
> > 
> > > It seems it has not been merged yet, and I know we are a bit late in
> > > the 5.18 schedule, but I think this is a good fix for 5.18.
> > Fix for what? I don't think this series fix any bug?
>
> This seems to be a "fix" for the Frankenstone scenario: mainline kernel +
> vendor DT

Did we ever support this?

I don't think we did, so even though it can be nice to improve that
situation, I don't think it's worth sending this to stable

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 779 bytes --]

On Wed, May 11, 2022 at 08:10:50AM +0200, Stefan Wahren wrote:
> Am 10.05.22 um 15:30 schrieb Maxime Ripard:
> > Hi,
> > 
> > On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
> > > May I ask what's the status/plan of  this patch series?
> > As far as I know it hasn't been merged yet.
> > 
> > > It seems it has not been merged yet, and I know we are a bit late in
> > > the 5.18 schedule, but I think this is a good fix for 5.18.
> > Fix for what? I don't think this series fix any bug?
>
> This seems to be a "fix" for the Frankenstone scenario: mainline kernel +
> vendor DT

Did we ever support this?

I don't think we did, so even though it can be nice to improve that
situation, I don't think it's worth sending this to stable

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Ivan Ivanov]

Hi,

> On 12 May 2022, at 10:57, Maxime Ripard <maxime@cerno.tech> wrote:
> 
> On Wed, May 11, 2022 at 08:10:50AM +0200, Stefan Wahren wrote:
>> Am 10.05.22 um 15:30 schrieb Maxime Ripard:
>>> Hi,
>>> 
>>> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
>>>> May I ask what's the status/plan of  this patch series?
>>> As far as I know it hasn't been merged yet.
>>> 
>>>> It seems it has not been merged yet, and I know we are a bit late in
>>>> the 5.18 schedule, but I think this is a good fix for 5.18.
>>> Fix for what? I don't think this series fix any bug?
>> 
>> This seems to be a "fix" for the Frankenstone scenario: mainline kernel +
>> vendor DT
> 
> Did we ever support this?
> 
> I don't think we did, so even though it can be nice to improve that
> situation, I don't think it's worth sending this to stable

Yes, maybe not stable material, but considering support for devices
which are shipped with upstream Linux and vendor device tree blobs,
saved somewhere on them, should be pretty normal to expect, right?

Regards,
Ivan

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

On Thu, May 12, 2022 at 11:10:00AM +0300, Ivan Ivanov wrote:
> Hi,
> 
> > On 12 May 2022, at 10:57, Maxime Ripard <maxime@cerno.tech> wrote:
> > 
> > On Wed, May 11, 2022 at 08:10:50AM +0200, Stefan Wahren wrote:
> >> Am 10.05.22 um 15:30 schrieb Maxime Ripard:
> >>> Hi,
> >>> 
> >>> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
> >>>> May I ask what's the status/plan of  this patch series?
> >>> As far as I know it hasn't been merged yet.
> >>> 
> >>>> It seems it has not been merged yet, and I know we are a bit late in
> >>>> the 5.18 schedule, but I think this is a good fix for 5.18.
> >>> Fix for what? I don't think this series fix any bug?
> >> 
> >> This seems to be a "fix" for the Frankenstone scenario: mainline kernel +
> >> vendor DT
> > 
> > Did we ever support this?
> > 
> > I don't think we did, so even though it can be nice to improve that
> > situation, I don't think it's worth sending this to stable
> 
> Yes, maybe not stable material, but considering support for devices
> which are shipped with upstream Linux and vendor device tree blobs,
> saved somewhere on them, should be pretty normal to expect, right?

Not really?

If the vendor in question uses a binding that has never been reviewed,
accepted, and supported by upstream, then I don't see what upstream
should be doing to accommodate for that situation?

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Maxime Ripard]

[-- Attachment #1.1: Type: text/plain, Size: 1408 bytes --]

On Thu, May 12, 2022 at 11:10:00AM +0300, Ivan Ivanov wrote:
> Hi,
> 
> > On 12 May 2022, at 10:57, Maxime Ripard <maxime@cerno.tech> wrote:
> > 
> > On Wed, May 11, 2022 at 08:10:50AM +0200, Stefan Wahren wrote:
> >> Am 10.05.22 um 15:30 schrieb Maxime Ripard:
> >>> Hi,
> >>> 
> >>> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
> >>>> May I ask what's the status/plan of  this patch series?
> >>> As far as I know it hasn't been merged yet.
> >>> 
> >>>> It seems it has not been merged yet, and I know we are a bit late in
> >>>> the 5.18 schedule, but I think this is a good fix for 5.18.
> >>> Fix for what? I don't think this series fix any bug?
> >> 
> >> This seems to be a "fix" for the Frankenstone scenario: mainline kernel +
> >> vendor DT
> > 
> > Did we ever support this?
> > 
> > I don't think we did, so even though it can be nice to improve that
> > situation, I don't think it's worth sending this to stable
> 
> Yes, maybe not stable material, but considering support for devices
> which are shipped with upstream Linux and vendor device tree blobs,
> saved somewhere on them, should be pretty normal to expect, right?

Not really?

If the vendor in question uses a binding that has never been reviewed,
accepted, and supported by upstream, then I don't see what upstream
should be doing to accommodate for that situation?

Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Ivan Ivanov]

Hi,

> On 12 May 2022, at 11:53, Maxime Ripard <maxime@cerno.tech> wrote:
> 
> On Thu, May 12, 2022 at 11:10:00AM +0300, Ivan Ivanov wrote:
>> Hi,
>> 
>>> On 12 May 2022, at 10:57, Maxime Ripard <maxime@cerno.tech> wrote:
>>> 
>>> On Wed, May 11, 2022 at 08:10:50AM +0200, Stefan Wahren wrote:
>>>> Am 10.05.22 um 15:30 schrieb Maxime Ripard:
>>>>> Hi,
>>>>> 
>>>>> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
>>>>>> May I ask what's the status/plan of  this patch series?
>>>>> As far as I know it hasn't been merged yet.
>>>>> 
>>>>>> It seems it has not been merged yet, and I know we are a bit late in
>>>>>> the 5.18 schedule, but I think this is a good fix for 5.18.
>>>>> Fix for what? I don't think this series fix any bug?
>>>> 
>>>> This seems to be a "fix" for the Frankenstone scenario: mainline kernel +
>>>> vendor DT
>>> 
>>> Did we ever support this?
>>> 
>>> I don't think we did, so even though it can be nice to improve that
>>> situation, I don't think it's worth sending this to stable
>> 
>> Yes, maybe not stable material, but considering support for devices
>> which are shipped with upstream Linux and vendor device tree blobs,
>> saved somewhere on them, should be pretty normal to expect, right?
> 
> Not really?
> 
> If the vendor in question uses a binding that has never been reviewed,
> accepted, and supported by upstream, then I don't see what upstream
> should be doing to accommodate for that situation?


Ok, let do not generalise this discussion too much :-)

I bringed above as example that some times device tree could not
be changed and it is provided by board supplier, not by Linux OS
supplier.

In this particular case vendor device tree blob is using standard 
clock bindings. Just upstream Linux clock driver don’t have support
for some of the clocks. This is what these patches fix.

Regards,
Ivan 

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Ivan T. Ivanov]

On 04-28 09:57, Ivan T. Ivanov wrote:
> Date: Thu, 28 Apr 2022 09:57:40 +0300
> From: "Ivan T. Ivanov" <iivanov@suse.de>
> To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
>  <sboyd@kernel.org>, Nicolas Saenz Julienne <nsaenz@kernel.org>
> Cc: Maxime Ripard <maxime@cerno.tech>, Dave Stevenson
>  <dave.stevenson@raspberrypi.com>, Guillaume GARDET
>  <guillaume.gardet@arm.com>, bcm-kernel-feedback-list@broadcom.com,
>  linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
>  linux-arm-kernel@lists.infradead.org, "Ivan T. Ivanov" <iivanov@suse.de>
> Subject: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks
> Message-Id: <20220428065743.94967-1-iivanov@suse.de>
> 
> Add missing clock required by RPiVid video decoder and provide more
> reliable and accurate source for HDMI pixel and video encoder clocks.
> 

Hi Stephen, Michael. What is the plan for this series of patches?

Regards,
Ivan

> Changes since v3
> - Put back support for VEC clock, which was actually one of
>   reasons for this patch-set [1]. I mixed "HEVC" vs. "VEC", sorry.
> 
>   [1] https://bugzilla.suse.com/show_bug.cgi?id=1198942
> 
> Changes since v2
> - Added Acks from Maxime Ripard and Dave Stevenson
> 
> Changes since v1
> - Drop RPI_FIRMWARE_VEC_CLK_ID clock it doesn't seems to be used.
> - Rework downstream changes on top of recent Maxime changes.
> 
> Dom Cobley (1):
>   clk: bcm: rpi: Add support for VEC clock
> 
> Ivan T. Ivanov (2):
>   clk: bcm: rpi: Add support HEVC clock
>   clk: bcm: rpi: Handle pixel clock in firmware
> 
>  drivers/clk/bcm/clk-raspberrypi.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> -- 
> 2.34.1
> 

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Ivan T. Ivanov]

On 04-28 09:57, Ivan T. Ivanov wrote:
> Date: Thu, 28 Apr 2022 09:57:40 +0300
> From: "Ivan T. Ivanov" <iivanov@suse.de>
> To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
>  <sboyd@kernel.org>, Nicolas Saenz Julienne <nsaenz@kernel.org>
> Cc: Maxime Ripard <maxime@cerno.tech>, Dave Stevenson
>  <dave.stevenson@raspberrypi.com>, Guillaume GARDET
>  <guillaume.gardet@arm.com>, bcm-kernel-feedback-list@broadcom.com,
>  linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
>  linux-arm-kernel@lists.infradead.org, "Ivan T. Ivanov" <iivanov@suse.de>
> Subject: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks
> Message-Id: <20220428065743.94967-1-iivanov@suse.de>
> 
> Add missing clock required by RPiVid video decoder and provide more
> reliable and accurate source for HDMI pixel and video encoder clocks.
> 

Hi Stephen, Michael. What is the plan for this series of patches?

Regards,
Ivan

> Changes since v3
> - Put back support for VEC clock, which was actually one of
>   reasons for this patch-set [1]. I mixed "HEVC" vs. "VEC", sorry.
> 
>   [1] https://bugzilla.suse.com/show_bug.cgi?id=1198942
> 
> Changes since v2
> - Added Acks from Maxime Ripard and Dave Stevenson
> 
> Changes since v1
> - Drop RPI_FIRMWARE_VEC_CLK_ID clock it doesn't seems to be used.
> - Rework downstream changes on top of recent Maxime changes.
> 
> Dom Cobley (1):
>   clk: bcm: rpi: Add support for VEC clock
> 
> Ivan T. Ivanov (2):
>   clk: bcm: rpi: Add support HEVC clock
>   clk: bcm: rpi: Handle pixel clock in firmware
> 
>  drivers/clk/bcm/clk-raspberrypi.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> -- 
> 2.34.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Florian Fainelli]

On 5/26/2022 4:36 AM, Ivan T. Ivanov wrote:
> On 04-28 09:57, Ivan T. Ivanov wrote:
>> Date: Thu, 28 Apr 2022 09:57:40 +0300
>> From: "Ivan T. Ivanov" <iivanov@suse.de>
>> To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
>>   <sboyd@kernel.org>, Nicolas Saenz Julienne <nsaenz@kernel.org>
>> Cc: Maxime Ripard <maxime@cerno.tech>, Dave Stevenson
>>   <dave.stevenson@raspberrypi.com>, Guillaume GARDET
>>   <guillaume.gardet@arm.com>, bcm-kernel-feedback-list@broadcom.com,
>>   linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
>>   linux-arm-kernel@lists.infradead.org, "Ivan T. Ivanov" <iivanov@suse.de>
>> Subject: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks
>> Message-Id: <20220428065743.94967-1-iivanov@suse.de>
>>
>> Add missing clock required by RPiVid video decoder and provide more
>> reliable and accurate source for HDMI pixel and video encoder clocks.
>>
> 
> Hi Stephen, Michael. What is the plan for this series of patches?

Ping?
-- 
Florian

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Florian Fainelli]

On 5/26/2022 4:36 AM, Ivan T. Ivanov wrote:
> On 04-28 09:57, Ivan T. Ivanov wrote:
>> Date: Thu, 28 Apr 2022 09:57:40 +0300
>> From: "Ivan T. Ivanov" <iivanov@suse.de>
>> To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
>>   <sboyd@kernel.org>, Nicolas Saenz Julienne <nsaenz@kernel.org>
>> Cc: Maxime Ripard <maxime@cerno.tech>, Dave Stevenson
>>   <dave.stevenson@raspberrypi.com>, Guillaume GARDET
>>   <guillaume.gardet@arm.com>, bcm-kernel-feedback-list@broadcom.com,
>>   linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
>>   linux-arm-kernel@lists.infradead.org, "Ivan T. Ivanov" <iivanov@suse.de>
>> Subject: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks
>> Message-Id: <20220428065743.94967-1-iivanov@suse.de>
>>
>> Add missing clock required by RPiVid video decoder and provide more
>> reliable and accurate source for HDMI pixel and video encoder clocks.
>>
> 
> Hi Stephen, Michael. What is the plan for this series of patches?

Ping?
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Stefan Wahren]

Hi,

Am 10.05.22 um 15:30 schrieb Maxime Ripard:
> Hi,
>
> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
>> May I ask what's the status/plan of  this patch series?
> As far as I know it hasn't been merged yet.
>
>> It seems it has not been merged yet, and I know we are a bit late in
>> the 5.18 schedule, but I think this is a good fix for 5.18.
> Fix for what? I don't think this series fix any bug?

i think this series (or at least parts of it) is a workaround for this 
issue [1].

We better fix the root cause of the potential out of bounds access in 
clk-raspberrypi properly. I will send a patch soon.

[1] - https://github.com/raspberrypi/firmware/issues/1688

>
>> And, this looks like to be a good candidate for a backport to stable
>> kernels.
> This is not going to be trivial to backmerge, it depends on 12c90f3f27bb
> that isn't marked for stable
>
> maxime
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Stefan Wahren]

Hi,

Am 10.05.22 um 15:30 schrieb Maxime Ripard:
> Hi,
>
> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
>> May I ask what's the status/plan of  this patch series?
> As far as I know it hasn't been merged yet.
>
>> It seems it has not been merged yet, and I know we are a bit late in
>> the 5.18 schedule, but I think this is a good fix for 5.18.
> Fix for what? I don't think this series fix any bug?

i think this series (or at least parts of it) is a workaround for this 
issue [1].

We better fix the root cause of the potential out of bounds access in 
clk-raspberrypi properly. I will send a patch soon.

[1] - https://github.com/raspberrypi/firmware/issues/1688

>
>> And, this looks like to be a good candidate for a backport to stable
>> kernels.
> This is not going to be trivial to backmerge, it depends on 12c90f3f27bb
> that isn't marked for stable
>
> maxime
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Ivan T. Ivanov]

Hi,

On 2022-07-10 14:12, Stefan Wahren wrote:
> Hi,
> 
> Am 10.05.22 um 15:30 schrieb Maxime Ripard:
>> Hi,
>> 
>> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
>>> May I ask what's the status/plan of  this patch series?
>> As far as I know it hasn't been merged yet.
>> 
>>> It seems it has not been merged yet, and I know we are a bit late in
>>> the 5.18 schedule, but I think this is a good fix for 5.18.
>> Fix for what? I don't think this series fix any bug?
> 
> i think this series (or at least parts of it) is a workaround for this
> issue [1].

No, not really. Bug which this patch set fixes is this one [2].
When using downstream dtb and up to date bootloader index 15 is
valid id RPI_FIRMWARE_VEC_CLK_ID which is used by vc4 module.

> 
> We better fix the root cause of the potential out of bounds access in
> clk-raspberrypi properly. I will send a patch soon.

If not mistaken after last rework driver already handle this properly.
clk-raspberrypi.c:362

Regards,
Ivan

> 
> [1] - https://github.com/raspberrypi/firmware/issues/1688

[2] https://bugzilla.suse.com/show_bug.cgi?id=1196632

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Ivan T. Ivanov]

Hi,

On 2022-07-10 14:12, Stefan Wahren wrote:
> Hi,
> 
> Am 10.05.22 um 15:30 schrieb Maxime Ripard:
>> Hi,
>> 
>> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
>>> May I ask what's the status/plan of  this patch series?
>> As far as I know it hasn't been merged yet.
>> 
>>> It seems it has not been merged yet, and I know we are a bit late in
>>> the 5.18 schedule, but I think this is a good fix for 5.18.
>> Fix for what? I don't think this series fix any bug?
> 
> i think this series (or at least parts of it) is a workaround for this
> issue [1].

No, not really. Bug which this patch set fixes is this one [2].
When using downstream dtb and up to date bootloader index 15 is
valid id RPI_FIRMWARE_VEC_CLK_ID which is used by vc4 module.

> 
> We better fix the root cause of the potential out of bounds access in
> clk-raspberrypi properly. I will send a patch soon.

If not mistaken after last rework driver already handle this properly.
clk-raspberrypi.c:362

Regards,
Ivan

> 
> [1] - https://github.com/raspberrypi/firmware/issues/1688

[2] https://bugzilla.suse.com/show_bug.cgi?id=1196632


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Stefan Wahren]

Hi,

Am 11.07.22 um 09:02 schrieb Ivan T. Ivanov:
>
> Hi,
>
> On 2022-07-10 14:12, Stefan Wahren wrote:
>> Hi,
>>
>> Am 10.05.22 um 15:30 schrieb Maxime Ripard:
>>> Hi,
>>>
>>> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
>>>> May I ask what's the status/plan of this patch series?
>>> As far as I know it hasn't been merged yet.
>>>
>>>> It seems it has not been merged yet, and I know we are a bit late in
>>>> the 5.18 schedule, but I think this is a good fix for 5.18.
>>> Fix for what? I don't think this series fix any bug?
>>
>> i think this series (or at least parts of it) is a workaround for this
>> issue [1].
>
> No, not really. Bug which this patch set fixes is this one [2].

Both are related. In your case the device tree defines a clock ID which 
isn't define in the kernel driver. So the behavior (abort probing in 
case of invalid DTB) is correct to me. But the log message isn't helpful 
to end users.

This is broken by design, since we need to synchronize videocore 
firmware, kernel and DTB at the same time. Maybe this works for 
Raspberry Pi OS, but not for all users.

We need to fix this driver before add new clocks.

> When using downstream dtb and up to date bootloader index 15 is
> valid id RPI_FIRMWARE_VEC_CLK_ID which is used by vc4 module.
I think this only applies to the downstream kernel. AFAIK the 
bcm2835-clk is still used for VEC in mainline.
>
>>
>> We better fix the root cause of the potential out of bounds access in
>> clk-raspberrypi properly. I will send a patch soon.
>
> If not mistaken after last rework driver already handle this properly.
> clk-raspberrypi.c:362

No, this doesn't prevent the possible out of bounds access, what i mean. 
It's the condition of the while loop.

Best regards

>
> Regards,
> Ivan
>
>>
>> [1] - https://github.com/raspberrypi/firmware/issues/1688
>
> [2] https://bugzilla.suse.com/show_bug.cgi?id=1196632
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Stefan Wahren]

Hi,

Am 11.07.22 um 09:02 schrieb Ivan T. Ivanov:
>
> Hi,
>
> On 2022-07-10 14:12, Stefan Wahren wrote:
>> Hi,
>>
>> Am 10.05.22 um 15:30 schrieb Maxime Ripard:
>>> Hi,
>>>
>>> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
>>>> May I ask what's the status/plan of this patch series?
>>> As far as I know it hasn't been merged yet.
>>>
>>>> It seems it has not been merged yet, and I know we are a bit late in
>>>> the 5.18 schedule, but I think this is a good fix for 5.18.
>>> Fix for what? I don't think this series fix any bug?
>>
>> i think this series (or at least parts of it) is a workaround for this
>> issue [1].
>
> No, not really. Bug which this patch set fixes is this one [2].

Both are related. In your case the device tree defines a clock ID which 
isn't define in the kernel driver. So the behavior (abort probing in 
case of invalid DTB) is correct to me. But the log message isn't helpful 
to end users.

This is broken by design, since we need to synchronize videocore 
firmware, kernel and DTB at the same time. Maybe this works for 
Raspberry Pi OS, but not for all users.

We need to fix this driver before add new clocks.

> When using downstream dtb and up to date bootloader index 15 is
> valid id RPI_FIRMWARE_VEC_CLK_ID which is used by vc4 module.
I think this only applies to the downstream kernel. AFAIK the 
bcm2835-clk is still used for VEC in mainline.
>
>>
>> We better fix the root cause of the potential out of bounds access in
>> clk-raspberrypi properly. I will send a patch soon.
>
> If not mistaken after last rework driver already handle this properly.
> clk-raspberrypi.c:362

No, this doesn't prevent the possible out of bounds access, what i mean. 
It's the condition of the while loop.

Best regards

>
> Regards,
> Ivan
>
>>
>> [1] - https://github.com/raspberrypi/firmware/issues/1688
>
> [2] https://bugzilla.suse.com/show_bug.cgi?id=1196632
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v4 0/3] clk: bcm: rpi: Add support for three more clocks

[Stephen Boyd]

Quoting Stefan Wahren (2022-07-11 04:55:36)
> Am 11.07.22 um 09:02 schrieb Ivan T. Ivanov:
> > On 2022-07-10 14:12, Stefan Wahren wrote:
> >> Am 10.05.22 um 15:30 schrieb Maxime Ripard:
> >>> On Tue, May 10, 2022 at 01:20:18PM +0000, Guillaume Gardet wrote:
> >>>> May I ask what's the status/plan of this patch series?
> >>> As far as I know it hasn't been merged yet.
> >>>
> >>>> It seems it has not been merged yet, and I know we are a bit late in
> >>>> the 5.18 schedule, but I think this is a good fix for 5.18.
> >>> Fix for what? I don't think this series fix any bug?
> >>
> >> i think this series (or at least parts of it) is a workaround for this
> >> issue [1].
> >
> > No, not really. Bug which this patch set fixes is this one [2].
> 
> Both are related. In your case the device tree defines a clock ID which 
> isn't define in the kernel driver. So the behavior (abort probing in 
> case of invalid DTB) is correct to me. But the log message isn't helpful 
> to end users.
> 
> This is broken by design, since we need to synchronize videocore 
> firmware, kernel and DTB at the same time. Maybe this works for 
> Raspberry Pi OS, but not for all users.
> 
> We need to fix this driver before add new clocks.
> 

Please resend this series. I didn't follow the discussion.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel