All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain and test-replication
@ 2018-10-01 13:20 Peter Maydell
  2018-10-02 20:11 ` [Qemu-devel] [Qemu-block] " John Snow
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2018-10-01 13:20 UTC (permalink / raw)
  To: qemu-devel
  Cc: patches, Max Reitz, Kevin Wolf, qemu-block, Wen Congyang, Xie Changlong

The test-bdrv-drain and test-replication tests have
intermittent errors which make my build testing process
fail way too often. Disable them both for the moment.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I'm having trouble making forward progress with applying
merges because of these flaky tests :-(

 tests/Makefile.include | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index d0c0a92e67d..1cb1e1a1da7 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -91,7 +91,7 @@ gcov-files-test-thread-pool-y = thread-pool.c
 gcov-files-test-hbitmap-y = util/hbitmap.c
 check-unit-y += tests/test-hbitmap$(EXESUF)
 gcov-files-test-hbitmap-y = blockjob.c
-check-unit-y += tests/test-bdrv-drain$(EXESUF)
+#check-unit-y += tests/test-bdrv-drain$(EXESUF)
 check-unit-y += tests/test-blockjob$(EXESUF)
 check-unit-y += tests/test-blockjob-txn$(EXESUF)
 check-unit-y += tests/test-block-backend$(EXESUF)
@@ -167,7 +167,7 @@ check-unit-y += tests/test-crypto-xts$(EXESUF)
 check-unit-y += tests/test-crypto-block$(EXESUF)
 check-unit-y += tests/test-logging$(EXESUF)
 gcov-files-test-logging-y = util/log.c
-check-unit-$(CONFIG_REPLICATION) += tests/test-replication$(EXESUF)
+#check-unit-$(CONFIG_REPLICATION) += tests/test-replication$(EXESUF)
 check-unit-y += tests/test-bufferiszero$(EXESUF)
 gcov-files-check-bufferiszero-y = util/bufferiszero.c
 check-unit-y += tests/test-uuid$(EXESUF)
-- 
2.19.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Disable test-bdrv-drain and test-replication
  2018-10-01 13:20 [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain and test-replication Peter Maydell
@ 2018-10-02 20:11 ` John Snow
  2018-10-03  9:28   ` Peter Maydell
  0 siblings, 1 reply; 3+ messages in thread
From: John Snow @ 2018-10-02 20:11 UTC (permalink / raw)
  To: Peter Maydell, qemu-devel
  Cc: Kevin Wolf, qemu-block, patches, Wen Congyang, Xie Changlong, Max Reitz



On 10/01/2018 09:20 AM, Peter Maydell wrote:
> The test-bdrv-drain and test-replication tests have
> intermittent errors which make my build testing process
> fail way too often. Disable them both for the moment.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I'm having trouble making forward progress with applying
> merges because of these flaky tests :-(
> 
>  tests/Makefile.include | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index d0c0a92e67d..1cb1e1a1da7 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -91,7 +91,7 @@ gcov-files-test-thread-pool-y = thread-pool.c
>  gcov-files-test-hbitmap-y = util/hbitmap.c
>  check-unit-y += tests/test-hbitmap$(EXESUF)
>  gcov-files-test-hbitmap-y = blockjob.c
> -check-unit-y += tests/test-bdrv-drain$(EXESUF)
> +#check-unit-y += tests/test-bdrv-drain$(EXESUF)
>  check-unit-y += tests/test-blockjob$(EXESUF)
>  check-unit-y += tests/test-blockjob-txn$(EXESUF)
>  check-unit-y += tests/test-block-backend$(EXESUF)
> @@ -167,7 +167,7 @@ check-unit-y += tests/test-crypto-xts$(EXESUF)
>  check-unit-y += tests/test-crypto-block$(EXESUF)
>  check-unit-y += tests/test-logging$(EXESUF)
>  gcov-files-test-logging-y = util/log.c
> -check-unit-$(CONFIG_REPLICATION) += tests/test-replication$(EXESUF)
> +#check-unit-$(CONFIG_REPLICATION) += tests/test-replication$(EXESUF)
>  check-unit-y += tests/test-bufferiszero$(EXESUF)
>  gcov-files-check-bufferiszero-y = util/bufferiszero.c
>  check-unit-y += tests/test-uuid$(EXESUF)
> 

Should we leave some kind of breadcrumb to remind ourselves to fix or
re-enable these for the 3.1 RC window?

--js

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-block] [PATCH] tests: Disable test-bdrv-drain and test-replication
  2018-10-02 20:11 ` [Qemu-devel] [Qemu-block] " John Snow
@ 2018-10-03  9:28   ` Peter Maydell
  0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2018-10-03  9:28 UTC (permalink / raw)
  To: John Snow
  Cc: QEMU Developers, Kevin Wolf, Qemu-block, patches, Wen Congyang,
	Xie Changlong, Max Reitz

On 2 October 2018 at 21:11, John Snow <jsnow@redhat.com> wrote:
>
>
> On 10/01/2018 09:20 AM, Peter Maydell wrote:
>> The test-bdrv-drain and test-replication tests have
>> intermittent errors which make my build testing process
>> fail way too often. Disable them both for the moment.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

> Should we leave some kind of breadcrumb to remind ourselves to fix or
> re-enable these for the 3.1 RC window?

Some fixes attempting to fix the tests have gone in instead
of this patch. There does still seem to be a problem with
test-bdrv-drain on OSX though.

thanks
-- PMM

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-03  9:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-01 13:20 [Qemu-devel] [PATCH] tests: Disable test-bdrv-drain and test-replication Peter Maydell
2018-10-02 20:11 ` [Qemu-devel] [Qemu-block] " John Snow
2018-10-03  9:28   ` Peter Maydell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.