All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: ard.biesheuvel@linaro.org, catalin.marinas@arm.com,
	linux-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux@armlinux.org.uk, tglx@linutronix.de, will@kernel.org,
	natechancellor@gmail.com
Subject: Re: Problems with arm64 compat vdso
Date: Tue, 24 Sep 2019 21:42:04 +0100	[thread overview]
Message-ID: <c164b359-75a0-5244-1e9b-7a4db1f52bd3@arm.com> (raw)
In-Reply-To: <20190924180634.206177-1-ndesaulniers@google.com>

Hi Nick,

thanks for reporting this.

On 9/24/19 7:06 PM, Nick Desaulniers wrote:
> Hi Vincenzo,
> We also are having issues building the cross vDSO with Clang:
> https://github.com/ClangBuiltLinux/linux/issues/595
> 

The initial implementation of vdso32 does not have support for Clang. I was
planning to add it with a second patch set but it seems requiring more work.

> It seems that `LINUXINCLUDE` in arch/arm64/kernel/vdso32/Makefile is including
> arm64 headers in the arm part of the vdso32 build, which causes Clang to error
> on the arm64 inline asm constraints being used in arm64.
> 
> I think if the issue Will described is fixed, it will be simpler for us to fix
> the rest to get it to build w/ Clang.
> 
> https://github.com/ClangBuiltLinux/linux/issues/595#issuecomment-509874891
> is the basis of such a patch.
> 

I agree with you this issue needs to be solved once and for all, but I feel that
the solution is not straight forward. Next week I will post a fix to the problem
Will raised and then will start investigating a more long term solution.

> Clang ships with all backends on by default, and uses a `-target <triple>` to
> cross compile; so the idea of passing two cross compiler binaries for a compat
> vDSO build doesn't really apply to Clang.
> 

My idea was to derivate the triple for clang from the compat cross compiler name
removing the final dash.

I have in my Makefile something on the lines:

CLANG_TRIPLE ?= $(CONFIG_CROSS_COMPILE_COMPAT_VDSO:"%-"=%)
...
COMPATCC := $(CC) --target=$(notdir $CLANG_TRIPLE)


-- 
Regards,
Vincenzo

  reply	other threads:[~2019-09-24 20:40 UTC|newest]

Thread overview: 127+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20 14:27 Problems with arm64 compat vdso Will Deacon
2019-09-20 16:33 ` Vincenzo Frascino
2019-09-23 16:41   ` Ard Biesheuvel
2019-09-24 12:11     ` Vincenzo Frascino
2019-09-24 18:06       ` Nick Desaulniers
2019-09-24 20:42         ` Vincenzo Frascino [this message]
2019-09-25 15:58     ` Ard Biesheuvel
2019-09-26  6:03 ` [PATCH 0/4] arm64: vdso32: Address various issues Vincenzo Frascino
2019-09-26  6:03   ` Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino
2019-09-26  6:03     ` Vincenzo Frascino
2019-09-26  8:06     ` Catalin Marinas
2019-09-26  8:06       ` Catalin Marinas
2019-09-26 10:56       ` Vincenzo Frascino
2019-09-26 10:56         ` Vincenzo Frascino
2019-09-26 11:02         ` Vincenzo Frascino
2019-09-26 11:02           ` Vincenzo Frascino
2019-09-26 15:23           ` Catalin Marinas
2019-09-26 15:23             ` Catalin Marinas
2019-09-26 12:22         ` Vincenzo Frascino
2019-09-26 12:22           ` Vincenzo Frascino
2019-09-26 15:17           ` Catalin Marinas
2019-09-26 15:17             ` Catalin Marinas
2019-09-26 20:17             ` Vincenzo Frascino
2019-09-26 20:17               ` Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 2/4] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-09-26  6:03     ` Vincenzo Frascino
2019-09-26  8:30     ` Catalin Marinas
2019-09-26  8:30       ` Catalin Marinas
2019-09-26 10:59       ` Vincenzo Frascino
2019-09-26 10:59         ` Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 3/4] arm64: vdso32: Fix compilation warning Vincenzo Frascino
2019-09-26  6:03     ` Vincenzo Frascino
2019-09-26  8:32     ` Catalin Marinas
2019-09-26  8:32       ` Catalin Marinas
2019-09-26 11:03       ` Vincenzo Frascino
2019-09-26 11:03         ` Vincenzo Frascino
2019-09-26  6:03   ` [PATCH 4/4] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-09-26  6:03     ` Vincenzo Frascino
2019-09-26  8:34     ` Catalin Marinas
2019-09-26  8:34       ` Catalin Marinas
2019-09-26 13:38 ` [PATCH v2 0/4] arm64: vdso32: Address various issues Vincenzo Frascino
2019-09-26 13:38   ` Vincenzo Frascino
2019-09-26 13:38   ` [PATCH v2 1/4] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino
2019-09-26 13:38     ` Vincenzo Frascino
2019-09-26 15:13     ` Catalin Marinas
2019-09-26 15:13       ` Catalin Marinas
2019-09-26 13:38   ` [PATCH v2 2/4] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-09-26 13:38     ` Vincenzo Frascino
2019-09-26 14:26     ` Catalin Marinas
2019-09-26 14:26       ` Catalin Marinas
2019-09-26 20:19       ` Vincenzo Frascino
2019-09-26 20:19         ` Vincenzo Frascino
2019-09-26 15:59     ` Catalin Marinas
2019-09-26 15:59       ` Catalin Marinas
2019-09-26 21:17       ` Vincenzo Frascino
2019-09-26 21:17         ` Vincenzo Frascino
2019-09-26 16:23     ` Nick Desaulniers
2019-09-26 16:23       ` Nick Desaulniers
2019-09-26 13:38   ` [PATCH v2 3/4] arm64: vdso32: Fix compilation warning Vincenzo Frascino
2019-09-26 13:38     ` Vincenzo Frascino
2019-09-26 15:22     ` Catalin Marinas
2019-09-26 15:22       ` Catalin Marinas
2019-09-26 13:38   ` [PATCH v2 4/4] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-09-26 13:38     ` Vincenzo Frascino
2019-09-26 15:31   ` [PATCH v2 0/4] arm64: vdso32: Address various issues Catalin Marinas
2019-09-26 15:31     ` Catalin Marinas
2019-09-26 20:29     ` Vincenzo Frascino
2019-09-26 20:29       ` Vincenzo Frascino
2019-09-26 21:43 ` [PATCH v3 0/5]arm64: " Vincenzo Frascino
2019-09-26 21:43   ` Vincenzo Frascino
2019-09-26 21:43   ` [PATCH v3 1/5] arm64: vdso32: Introduce COMPAT_CC_IS_GCC Vincenzo Frascino
2019-09-26 21:43     ` Vincenzo Frascino
2019-09-27  9:24     ` Catalin Marinas
2019-09-27  9:24       ` Catalin Marinas
2019-10-01 13:14     ` Will Deacon
2019-10-01 13:14       ` Will Deacon
2019-10-01 13:27       ` Catalin Marinas
2019-10-01 13:27         ` Catalin Marinas
2019-10-01 14:20         ` Vincenzo Frascino
2019-10-01 14:20           ` Vincenzo Frascino
2019-10-01 14:20           ` Will Deacon
2019-10-01 14:20             ` Will Deacon
2019-10-01 14:37             ` Vincenzo Frascino
2019-10-01 14:37               ` Vincenzo Frascino
2019-10-01 14:43               ` Will Deacon
2019-10-01 14:43                 ` Will Deacon
2019-10-01 14:59                 ` Vincenzo Frascino
2019-10-01 14:59                   ` Vincenzo Frascino
2019-10-01 15:30                 ` Catalin Marinas
2019-10-01 15:30                   ` Catalin Marinas
2019-10-01 16:46                   ` Will Deacon
2019-10-01 16:46                     ` Will Deacon
2019-10-01 16:59                     ` Nick Desaulniers
2019-10-01 16:59                       ` Nick Desaulniers
2019-10-01 17:07                       ` Will Deacon
2019-10-01 17:07                         ` Will Deacon
2019-10-01 17:12                         ` Nick Desaulniers
2019-10-01 17:12                           ` Nick Desaulniers
2019-10-01 17:14                           ` Will Deacon
2019-10-01 17:14                             ` Will Deacon
2019-09-26 21:43   ` [PATCH v3 2/5] arm64: vdso32: Detect binutils support for dmb ishld Vincenzo Frascino
2019-09-26 21:43     ` Vincenzo Frascino
2019-09-27  9:25     ` Catalin Marinas
2019-09-27  9:25       ` Catalin Marinas
2019-10-01 13:26     ` Will Deacon
2019-10-01 13:26       ` Will Deacon
2019-10-01 14:23       ` Vincenzo Frascino
2019-10-01 14:23         ` Vincenzo Frascino
2019-09-26 21:43   ` [PATCH v3 3/5] arm64: vdso32: Fix compilation warning Vincenzo Frascino
2019-09-26 21:43     ` Vincenzo Frascino
2019-09-27  9:26     ` Catalin Marinas
2019-09-27  9:26       ` Catalin Marinas
2019-10-01 13:21     ` Will Deacon
2019-10-01 13:21       ` Will Deacon
2019-10-01 14:41       ` Vincenzo Frascino
2019-10-01 14:41         ` Vincenzo Frascino
2019-09-26 21:43   ` [PATCH v3 4/5] arm64: Remove gettimeofday.S Vincenzo Frascino
2019-09-26 21:43     ` Vincenzo Frascino
2019-09-26 21:43   ` [PATCH v3 5/5] arm64: vdso32: Remove jump label config option in Makefile Vincenzo Frascino
2019-09-26 21:43     ` Vincenzo Frascino
2019-09-27  9:27     ` Catalin Marinas
2019-09-27  9:27       ` Catalin Marinas
2019-09-27 10:46   ` [PATCH v3 0/5]arm64: vdso32: Address various issues Catalin Marinas
2019-09-27 10:46     ` Catalin Marinas
2019-10-01 13:27   ` Will Deacon
2019-10-01 13:27     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c164b359-75a0-5244-1e9b-7a4db1f52bd3@arm.com \
    --to=vincenzo.frascino@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=natechancellor@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.