From: Vlastimil Babka <vbabka@suse.cz> To: Minchan Kim <minchan@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@techsingularity.net>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sangseok Lee <sangseok.lee@lge.com> Subject: Re: [PATCH 1/4] mm: adjust reserved highatomic count Date: Tue, 11 Oct 2016 11:40:33 +0200 [thread overview] Message-ID: <c177a63f-d243-b291-44a8-51217a602b5e@suse.cz> (raw) In-Reply-To: <20161011041916.GA30973@bbox> On 10/11/2016 06:19 AM, Minchan Kim wrote: > Hi Vlasimil, > > On Mon, Oct 10, 2016 at 08:57:40AM +0200, Vlastimil Babka wrote: >> On 10/07/2016 04:29 PM, Minchan Kim wrote: >> >>>In that case, we should adjust nr_reserved_highatomic. >> >>>Otherwise, VM cannot reserve highorderatomic pageblocks any more >> >>>although it doesn't reach 1% limit. It means highorder atomic >> >>>allocation failure would be higher. >> >>> >> >>>So, this patch decreases the account as well as migratetype >> >>>if it was MIGRATE_HIGHATOMIC. >> >>> >> >>>Signed-off-by: Minchan Kim <minchan@kernel.org> >> >> >> >>Hm wouldn't it be simpler just to prevent the pageblock's migratetype to be >> >>changed if it's highatomic? Possibly also not do move_freepages_block() in >> > >> >It could be. Actually, I did it with modifying can_steal_fallback which returns >> >false it found the pageblock is highorderatomic but changed to this way again >> >because I don't have any justification to prevent changing pageblock. >> >If you give concrete justification so others isn't against on it, I am happy to >> >do what you suggested. >> >> Well, MIGRATE_HIGHATOMIC is not listed in the fallbacks array at all, so we >> are not supposed to steal from it in the first place. Stealing will only >> happen due to races, which would be too costly to close, so we allow them >> and expect to be rare. But we shouldn't allow them to break the accounting. >> > > Fair enough. > How about this? Look sgood. > From 4a0b6a74ebf1af7f90720b0028da49e2e2a2b679 Mon Sep 17 00:00:00 2001 > From: Minchan Kim <minchan@kernel.org> > Date: Thu, 6 Oct 2016 13:38:35 +0900 > Subject: [PATCH] mm: don't steal highatomic pageblock > > In page freeing path, migratetype is racy so that a highorderatomic > page could free into non-highorderatomic free list. If that page > is allocated, VM can change the pageblock from higorderatomic to > something. In that case, highatomic pageblock accounting is broken > so it doesn't work(e.g., VM cannot reserve highorderatomic pageblocks > any more although it doesn't reach 1% limit). > > So, this patch prohibits the changing from highatomic to other type. > It's no problem because MIGRATE_HIGHATOMIC is not listed in fallback > array so stealing will only happen due to unexpected races which is > really rare. Also, such prohibiting keeps highatomic pageblock more > longer so it would be better for highorderatomic page allocation. > > Signed-off-by: Minchan Kim <minchan@kernel.org> Acked-by: Vlastimil Babka <vbabka@suse.cz> > --- > mm/page_alloc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 55ad0229ebf3..79853b258211 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2154,7 +2154,8 @@ __rmqueue_fallback(struct zone *zone, unsigned int order, int start_migratetype) > > page = list_first_entry(&area->free_list[fallback_mt], > struct page, lru); > - if (can_steal) > + if (can_steal && > + get_pageblock_migratetype(page) != MIGRATE_HIGHATOMIC) > steal_suitable_fallback(zone, page, start_migratetype); > > /* Remove the page from the freelists */ > @@ -2555,7 +2556,8 @@ int __isolate_free_page(struct page *page, unsigned int order) > struct page *endpage = page + (1 << order) - 1; > for (; page < endpage; page += pageblock_nr_pages) { > int mt = get_pageblock_migratetype(page); > - if (!is_migrate_isolate(mt) && !is_migrate_cma(mt)) > + if (!is_migrate_isolate(mt) && !is_migrate_cma(mt) > + && mt != MIGRATE_HIGHATOMIC) > set_pageblock_migratetype(page, > MIGRATE_MOVABLE); > } >
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz> To: Minchan Kim <minchan@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org>, Mel Gorman <mgorman@techsingularity.net>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sangseok Lee <sangseok.lee@lge.com> Subject: Re: [PATCH 1/4] mm: adjust reserved highatomic count Date: Tue, 11 Oct 2016 11:40:33 +0200 [thread overview] Message-ID: <c177a63f-d243-b291-44a8-51217a602b5e@suse.cz> (raw) In-Reply-To: <20161011041916.GA30973@bbox> On 10/11/2016 06:19 AM, Minchan Kim wrote: > Hi Vlasimil, > > On Mon, Oct 10, 2016 at 08:57:40AM +0200, Vlastimil Babka wrote: >> On 10/07/2016 04:29 PM, Minchan Kim wrote: >> >>>In that case, we should adjust nr_reserved_highatomic. >> >>>Otherwise, VM cannot reserve highorderatomic pageblocks any more >> >>>although it doesn't reach 1% limit. It means highorder atomic >> >>>allocation failure would be higher. >> >>> >> >>>So, this patch decreases the account as well as migratetype >> >>>if it was MIGRATE_HIGHATOMIC. >> >>> >> >>>Signed-off-by: Minchan Kim <minchan@kernel.org> >> >> >> >>Hm wouldn't it be simpler just to prevent the pageblock's migratetype to be >> >>changed if it's highatomic? Possibly also not do move_freepages_block() in >> > >> >It could be. Actually, I did it with modifying can_steal_fallback which returns >> >false it found the pageblock is highorderatomic but changed to this way again >> >because I don't have any justification to prevent changing pageblock. >> >If you give concrete justification so others isn't against on it, I am happy to >> >do what you suggested. >> >> Well, MIGRATE_HIGHATOMIC is not listed in the fallbacks array at all, so we >> are not supposed to steal from it in the first place. Stealing will only >> happen due to races, which would be too costly to close, so we allow them >> and expect to be rare. But we shouldn't allow them to break the accounting. >> > > Fair enough. > How about this? Look sgood. > From 4a0b6a74ebf1af7f90720b0028da49e2e2a2b679 Mon Sep 17 00:00:00 2001 > From: Minchan Kim <minchan@kernel.org> > Date: Thu, 6 Oct 2016 13:38:35 +0900 > Subject: [PATCH] mm: don't steal highatomic pageblock > > In page freeing path, migratetype is racy so that a highorderatomic > page could free into non-highorderatomic free list. If that page > is allocated, VM can change the pageblock from higorderatomic to > something. In that case, highatomic pageblock accounting is broken > so it doesn't work(e.g., VM cannot reserve highorderatomic pageblocks > any more although it doesn't reach 1% limit). > > So, this patch prohibits the changing from highatomic to other type. > It's no problem because MIGRATE_HIGHATOMIC is not listed in fallback > array so stealing will only happen due to unexpected races which is > really rare. Also, such prohibiting keeps highatomic pageblock more > longer so it would be better for highorderatomic page allocation. > > Signed-off-by: Minchan Kim <minchan@kernel.org> Acked-by: Vlastimil Babka <vbabka@suse.cz> > --- > mm/page_alloc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 55ad0229ebf3..79853b258211 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2154,7 +2154,8 @@ __rmqueue_fallback(struct zone *zone, unsigned int order, int start_migratetype) > > page = list_first_entry(&area->free_list[fallback_mt], > struct page, lru); > - if (can_steal) > + if (can_steal && > + get_pageblock_migratetype(page) != MIGRATE_HIGHATOMIC) > steal_suitable_fallback(zone, page, start_migratetype); > > /* Remove the page from the freelists */ > @@ -2555,7 +2556,8 @@ int __isolate_free_page(struct page *page, unsigned int order) > struct page *endpage = page + (1 << order) - 1; > for (; page < endpage; page += pageblock_nr_pages) { > int mt = get_pageblock_migratetype(page); > - if (!is_migrate_isolate(mt) && !is_migrate_cma(mt)) > + if (!is_migrate_isolate(mt) && !is_migrate_cma(mt) > + && mt != MIGRATE_HIGHATOMIC) > set_pageblock_migratetype(page, > MIGRATE_MOVABLE); > } > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-10-11 9:55 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-07 5:45 [PATCH 0/4] use up highorder free pages before OOM Minchan Kim 2016-10-07 5:45 ` Minchan Kim 2016-10-07 5:45 ` [PATCH 1/4] mm: adjust reserved highatomic count Minchan Kim 2016-10-07 5:45 ` Minchan Kim 2016-10-07 12:30 ` Vlastimil Babka 2016-10-07 12:30 ` Vlastimil Babka 2016-10-07 14:29 ` Minchan Kim 2016-10-07 14:29 ` Minchan Kim 2016-10-10 6:57 ` Vlastimil Babka 2016-10-10 6:57 ` Vlastimil Babka 2016-10-11 4:19 ` Minchan Kim 2016-10-11 4:19 ` Minchan Kim 2016-10-11 9:40 ` Vlastimil Babka [this message] 2016-10-11 9:40 ` Vlastimil Babka 2016-10-12 5:36 ` Mel Gorman 2016-10-12 5:36 ` Mel Gorman 2016-10-07 5:45 ` [PATCH 2/4] mm: prevent double decrease of nr_reserved_highatomic Minchan Kim 2016-10-07 5:45 ` Minchan Kim 2016-10-07 12:44 ` Vlastimil Babka 2016-10-07 12:44 ` Vlastimil Babka 2016-10-07 14:30 ` Minchan Kim 2016-10-07 14:30 ` Minchan Kim 2016-10-12 5:36 ` Mel Gorman 2016-10-12 5:36 ` Mel Gorman 2016-10-07 5:45 ` [PATCH 3/4] mm: unreserve highatomic free pages fully before OOM Minchan Kim 2016-10-07 5:45 ` Minchan Kim 2016-10-07 9:09 ` Michal Hocko 2016-10-07 9:09 ` Michal Hocko 2016-10-07 14:43 ` Minchan Kim 2016-10-07 14:43 ` Minchan Kim 2016-10-10 7:41 ` Michal Hocko 2016-10-10 7:41 ` Michal Hocko 2016-10-11 5:01 ` Minchan Kim 2016-10-11 5:01 ` Minchan Kim 2016-10-11 6:50 ` Michal Hocko 2016-10-11 6:50 ` Michal Hocko 2016-10-11 7:09 ` Minchan Kim 2016-10-11 7:09 ` Minchan Kim 2016-10-11 7:26 ` Michal Hocko 2016-10-11 7:26 ` Michal Hocko 2016-10-11 7:37 ` Minchan Kim 2016-10-11 7:37 ` Minchan Kim 2016-10-11 8:01 ` Michal Hocko 2016-10-11 8:01 ` Michal Hocko 2016-10-07 5:45 ` [PATCH 4/4] mm: skip to reserve pageblock crossed zone boundary for HIGHATOMIC Minchan Kim 2016-10-07 5:45 ` Minchan Kim 2016-10-07 9:16 ` [PATCH 0/4] use up highorder free pages before OOM Michal Hocko 2016-10-07 9:16 ` Michal Hocko 2016-10-07 15:04 ` Minchan Kim 2016-10-07 15:04 ` Minchan Kim 2016-10-10 7:47 ` Michal Hocko 2016-10-10 7:47 ` Michal Hocko 2016-10-11 5:06 ` Minchan Kim 2016-10-11 5:06 ` Minchan Kim 2016-10-11 6:53 ` Michal Hocko 2016-10-11 6:53 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c177a63f-d243-b291-44a8-51217a602b5e@suse.cz \ --to=vbabka@suse.cz \ --cc=akpm@linux-foundation.org \ --cc=iamjoonsoo.kim@lge.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@techsingularity.net \ --cc=minchan@kernel.org \ --cc=sangseok.lee@lge.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.