Re: [PATCH 2/2] arm64: dts: imx8mm-phyboard-polis-rdk: Remove 'fsl,spi-num-chipselects'

Re: [PATCH 2/2] arm64: dts: imx8mm-phyboard-polis-rdk: Remove 'fsl,spi-num-chipselects'

[Yannic Moog]

Hello Fabio,

On Wed, 2023-07-26 at 09:50 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The 'fsl,spi-num-chipselects' property is not a valid one, so remove
> it.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-
> rdk.dts b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> index 66a0bdaff8eb..92e62fe31929 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> @@ -143,7 +143,6 @@ can0: can@0 {
>  /* TPM */
>  &ecspi2 {
>         cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> -       fsl,spi-num-chipselects = <1>;

Is it possible or customary that you also add the property "num-cs =
<1>" as replacement or is this (generally) something where I should send
a patch to add the new node?

Yannic

>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_ecspi2>;
>         #address-cells = <1>;

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: imx8mm-phyboard-polis-rdk: Remove 'fsl,spi-num-chipselects'

[Fabio Estevam]

Hi Yannic,

On 27/07/2023 02:26, Yannic Moog wrote:

> Is it possible or customary that you also add the property "num-cs =
> <1>" as replacement or is this (generally) something where I should 
> send
> a patch to add the new node?


The cs-gpios property already contains the SPI chipselect list, so the 
information
about the number of the chipselect lines is taken from there.

No need to pass num-cs.

Regards,

Fabio Estevam

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] arm64: dts: imx8mm-phyboard-polis-rdk: Remove 'fsl,spi-num-chipselects'

[Yannic Moog]

On Wed, 2023-07-26 at 09:50 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The 'fsl,spi-num-chipselects' property is not a valid one, so remove
> it.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Reviewed-by: Yannic Moog <y.moog@phytec.de>

> ---
>  arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-
> rdk.dts b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> index 66a0bdaff8eb..92e62fe31929 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts
> @@ -143,7 +143,6 @@ can0: can@0 {
>  /* TPM */
>  &ecspi2 {
>         cs-gpios = <&gpio5 13 GPIO_ACTIVE_LOW>;
> -       fsl,spi-num-chipselects = <1>;
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_ecspi2>;
>         #address-cells = <1>;

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] arm64: dts: imx8dxl-evk: Remove 'fsl,spi-num-chipselects'

[Shawn Guo]

On Wed, Jul 26, 2023 at 09:50:24AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The 'fsl,spi-num-chipselects' property is not a valid one, so remove it.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied both, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel