[Buildroot] [PATCH 1/1] package/pure-ftpd: add optional support for linux-pam

[Buildroot] [PATCH 1/1] package/pure-ftpd: add optional support for linux-pam

[Artem Panfilov]

Signed-off-by: Artem Panfilov <apanfilov@spectracom.com>
---
 package/pure-ftpd/pure-ftpd.mk | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/pure-ftpd/pure-ftpd.mk b/package/pure-ftpd/pure-ftpd.mk
index 457e67ea60..ea7578c2cd 100644
--- a/package/pure-ftpd/pure-ftpd.mk
+++ b/package/pure-ftpd/pure-ftpd.mk
@@ -57,4 +57,9 @@ ifeq ($(BR2_PACKAGE_PURE_FTPD_UPLOADSCRIPT),y)
 PURE_FTPD_CONF_OPTS += --with-uploadscript
 endif
 
+ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
+PURE_FTPD_CONF_OPTS += --with-pam
+PURE_FTPD_DEPENDENCIES += linux-pam
+endif
+
 $(eval $(autotools-package))
-- 
2.17.1

[Buildroot] [PATCH 1/1] package/pure-ftpd: add optional support for linux-pam

[Bernd Kuhls]

Am Wed, 01 Aug 2018 16:21:14 +0300 schrieb Artem Panfilov:

> +ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
> +PURE_FTPD_CONF_OPTS += --with-pam
> +PURE_FTPD_DEPENDENCIES += linux-pam
> +endif

Hi Artem,

could you please add

	else
	PURE_FTPD_CONF_OPTS += --without-pam

to make sure the outcome of the configure step takes our config into 
account and not defaults chosen by upstream?

Thanks!

Regards, Bernd

[Buildroot] [PATCH 1/1] package/pure-ftpd: add optional support for linux-pam

[Artem Panfilov]

Hi Bernd,

 > could you please add
 >
 > ??? else
 > ??? PURE_FTPD_CONF_OPTS += --without-pam

I added your change, thanks.

Best Regards,
Artyom

 From fd70cdf2634e279eb604bbf3381ce70eefd9a7b2 Mon Sep 17 00:00:00 2001
From: Artem Panfilov <apanfilov@spectracom.com>
Date: Wed, 1 Aug 2018 16:05:59 +0300
Subject: [PATCH 1/1] package/pure-ftpd: add optional support for linux-pam

Signed-off-by: Artem Panfilov <apanfilov@spectracom.com>
---
 ?package/pure-ftpd/pure-ftpd.mk | 7 +++++++
 ?1 file changed, 7 insertions(+)

diff --git a/package/pure-ftpd/pure-ftpd.mk b/package/pure-ftpd/pure-ftpd.mk
index 457e67ea60..ae3ca9d1f0 100644
--- a/package/pure-ftpd/pure-ftpd.mk
+++ b/package/pure-ftpd/pure-ftpd.mk
@@ -57,4 +57,11 @@ ifeq ($(BR2_PACKAGE_PURE_FTPD_UPLOADSCRIPT),y)
 ?PURE_FTPD_CONF_OPTS += --with-uploadscript
 ?endif

+ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
+PURE_FTPD_CONF_OPTS += --with-pam
+PURE_FTPD_DEPENDENCIES += linux-pam
+else
+PURE_FTPD_CONF_OPTS += --without-pam
+endif
+
 ?$(eval $(autotools-package))
-- 
2.17.1

On 01.08.2018 19:22, Bernd Kuhls wrote:
> Am Wed, 01 Aug 2018 16:21:14 +0300 schrieb Artem Panfilov:
>
>> +ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
>> +PURE_FTPD_CONF_OPTS += --with-pam
>> +PURE_FTPD_DEPENDENCIES += linux-pam
>> +endif
> Hi Artem,
>
> could you please add
>
> 	else
> 	PURE_FTPD_CONF_OPTS += --without-pam
>
> to make sure the outcome of the configure step takes our config into
> account and not defaults chosen by upstream?
>
> Thanks!
>
> Regards, Bernd
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/1] package/pure-ftpd: add optional support for linux-pam

[Thomas Petazzoni]

Hello,

On Wed,  1 Aug 2018 16:21:14 +0300, Artem Panfilov wrote:
> Signed-off-by: Artem Panfilov <apanfilov@spectracom.com>
> ---
>  package/pure-ftpd/pure-ftpd.mk | 5 +++++
>  1 file changed, 5 insertions(+)

Applied to master after adding an explicit --without-pam, as suggested
by Bernd.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com