ceph-ci.git and pull requests

ceph-ci.git and pull requests

[Casey Bodley]

Hi,

I had pushed a branch to ceph/ceph-ci.git for testing, but was unable to 
open a pull request for it against ceph/ceph.git. The github ui wouldn't 
let me target branches in ceph-ci.git, presumably because it doesn't 
recognize it as a fork if ceph.git.

Has anyone else been able to figure this out?

Thanks,
Casey

Re: ceph-ci.git and pull requests

[Samuel Just]

Hmm, I always push branches like that to my own github account
ceph.git as well and do the PR from there.
-Sam

On Tue, Jan 3, 2017 at 9:23 AM, Casey Bodley <cbodley@redhat.com> wrote:
> Hi,
>
> I had pushed a branch to ceph/ceph-ci.git for testing, but was unable to
> open a pull request for it against ceph/ceph.git. The github ui wouldn't let
> me target branches in ceph-ci.git, presumably because it doesn't recognize
> it as a fork if ceph.git.
>
> Has anyone else been able to figure this out?
>
> Thanks,
> Casey
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ceph-ci.git and pull requests

[Ken Dreyer]

Right, I don't think GitHub allows an "upstream" repo and a "fork"
repo to exist within the same org (github.com/ceph). I do the same
thing Sam suggests.

- Ken

On Tue, Jan 3, 2017 at 10:40 AM, Samuel Just <sjust@redhat.com> wrote:
> Hmm, I always push branches like that to my own github account
> ceph.git as well and do the PR from there.
> -Sam
>
> On Tue, Jan 3, 2017 at 9:23 AM, Casey Bodley <cbodley@redhat.com> wrote:
>> Hi,
>>
>> I had pushed a branch to ceph/ceph-ci.git for testing, but was unable to
>> open a pull request for it against ceph/ceph.git. The github ui wouldn't let
>> me target branches in ceph-ci.git, presumably because it doesn't recognize
>> it as a fork if ceph.git.
>>
>> Has anyone else been able to figure this out?
>>
>> Thanks,
>> Casey
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: ceph-ci.git and pull requests

[Nathan Cutler]

Hi Casey:

Here's what I do, which I think is essentially the same as Sam and Ken 
are doing:

git clone https://github.com/smithfarm/ceph
git remote add ceph-ci https://github.com/ceph/ceph
<prepare wip-foo branch>
git push origin wip-foo
<open PR>
git push ceph-ci wip-foo
<wait for http://shaman.ceph.com to build>
<test in Sepia>

HTH,
Nathan

Re: ceph-ci.git and pull requests

[Casey Bodley]

Fair enough. In this case, I was going to push a backport to ceph-ci.git 
so that packages would be available when the backport team was ready to 
validate it. In other cases, it can be useful to target a PR against a 
public branch so that other devs with access can add fixes and continue 
testing.

Casey


On 01/03/2017 04:08 PM, Nathan Cutler wrote:
> Hi Casey:
>
> Here's what I do, which I think is essentially the same as Sam and Ken 
> are doing:
>
> git clone https://github.com/smithfarm/ceph
> git remote add ceph-ci https://github.com/ceph/ceph
> <prepare wip-foo branch>
> git push origin wip-foo
> <open PR>
> git push ceph-ci wip-foo
> <wait for http://shaman.ceph.com to build>
> <test in Sepia>
>
> HTH,
> Nathan

Re: ceph-ci.git and pull requests

[Nathan Cutler]

> Fair enough. In this case, I was going to push a backport to ceph-ci.git
> so that packages would be available when the backport team was ready to
> validate it.

That's probably not necessary. Typically, multiple backport PRs are 
ganged up in an integration branch for testing purposes. For example, 
the current hammer integration branch looks like this: 
http://tracker.ceph.com/issues/17151#note-37

The scripting used to prepare the integration branches is described 
here: 
http://tracker.ceph.com/projects/ceph-releases/wiki/HOWTO_populate_the_integration_branch

Nathan