From: Si-Wei Liu <si-wei.liu@oracle.com> To: "Eugenio Pérez" <eperezma@redhat.com>, virtualization@lists.linux-foundation.org, "Jason Wang" <jasowang@redhat.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stefano Garzarella <sgarzare@redhat.com>, Longpeng <longpeng2@huawei.com>, Zhu Lingshan <lingshan.zhu@intel.com>, martinh@xilinx.com, hanand@xilinx.com, dinang@xilinx.com, Eli Cohen <elic@nvidia.com>, lvivier@redhat.com, pabloc@xilinx.com, gautam.dawar@amd.com, Xie Yongji <xieyongji@bytedance.com>, habetsm.xilinx@gmail.com, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, tanuj.kamde@amd.com, Wu Zongyong <wuzongyong@linux.alibaba.com>, martinpo@xilinx.com, lulu@redhat.com, ecree.xilinx@gmail.com, Parav Pandit <parav@nvidia.com>, Dan Carpenter <dan.carpenter@oracle.com>, Zhang Min <zhang.min9@zte.com.cn> Subject: Re: [PATCH 2/4] vhost-vdpa: introduce STOP backend feature bit Date: Sat, 21 May 2022 03:24:50 -0700 [thread overview] Message-ID: <c1a31c3f-46c0-f0a2-eb43-757914d46ac3@oracle.com> (raw) In-Reply-To: <20220520172325.980884-3-eperezma@redhat.com> On 5/20/2022 10:23 AM, Eugenio Pérez wrote: > Userland knows if it can stop the device or not by checking this feature > bit. > > It's only offered if the vdpa driver backend implements the stop() > operation callback, and try to set it if the backend does not offer that > callback is an error. > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> > --- > drivers/vhost/vdpa.c | 13 +++++++++++++ > include/uapi/linux/vhost_types.h | 2 ++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index 1f1d1c425573..a325bc259afb 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -347,6 +347,14 @@ static long vhost_vdpa_set_config(struct vhost_vdpa *v, > return 0; > } > > +static bool vhost_vdpa_can_stop(const struct vhost_vdpa *v) > +{ > + struct vdpa_device *vdpa = v->vdpa; > + const struct vdpa_config_ops *ops = vdpa->config; > + > + return ops->stop; > +} > + > static long vhost_vdpa_get_features(struct vhost_vdpa *v, u64 __user *featurep) > { > struct vdpa_device *vdpa = v->vdpa; > @@ -577,6 +585,9 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep, > return -EFAULT; > if (features & ~VHOST_VDPA_BACKEND_FEATURES) > return -EOPNOTSUPP; > + if ((features & VHOST_BACKEND_F_STOP) && VHOST_BACKEND_F_STOP is not part of VHOST_VDPA_BACKEND_FEATURES. There's no chance for VHOST_BACKEND_F_STOP to get here. -Siwei > + !vhost_vdpa_can_stop(v)) > + return -EOPNOTSUPP; > vhost_set_backend_features(&v->vdev, features); > return 0; > } > @@ -624,6 +635,8 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep, > break; > case VHOST_GET_BACKEND_FEATURES: > features = VHOST_VDPA_BACKEND_FEATURES; > + if (vhost_vdpa_can_stop(v)) > + features |= VHOST_BACKEND_F_STOP; > if (copy_to_user(featurep, &features, sizeof(features))) > r = -EFAULT; > break; > diff --git a/include/uapi/linux/vhost_types.h b/include/uapi/linux/vhost_types.h > index 634cee485abb..2758e665791b 100644 > --- a/include/uapi/linux/vhost_types.h > +++ b/include/uapi/linux/vhost_types.h > @@ -161,5 +161,7 @@ struct vhost_vdpa_iova_range { > * message > */ > #define VHOST_BACKEND_F_IOTLB_ASID 0x3 > +/* Stop device from processing virtqueue buffers */ > +#define VHOST_BACKEND_F_STOP 0x4 > > #endif
WARNING: multiple messages have this Message-ID (diff)
From: Si-Wei Liu <si-wei.liu@oracle.com> To: "Eugenio Pérez" <eperezma@redhat.com>, virtualization@lists.linux-foundation.org, "Jason Wang" <jasowang@redhat.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lvivier@redhat.com, Zhang Min <zhang.min9@zte.com.cn>, Eli Cohen <elic@nvidia.com>, lulu@redhat.com, ecree.xilinx@gmail.com, gautam.dawar@amd.com, Christophe JAILLET <christophe.jaillet@wanadoo.fr>, tanuj.kamde@amd.com, martinh@xilinx.com, Xie Yongji <xieyongji@bytedance.com>, hanand@xilinx.com, habetsm.xilinx@gmail.com, Dan Carpenter <dan.carpenter@oracle.com>, martinpo@xilinx.com, dinang@xilinx.com, pabloc@xilinx.com, Longpeng <longpeng2@huawei.com>, Zhu Lingshan <lingshan.zhu@intel.com>, Wu Zongyong <wuzongyong@linux.alibaba.com> Subject: Re: [PATCH 2/4] vhost-vdpa: introduce STOP backend feature bit Date: Sat, 21 May 2022 03:24:50 -0700 [thread overview] Message-ID: <c1a31c3f-46c0-f0a2-eb43-757914d46ac3@oracle.com> (raw) In-Reply-To: <20220520172325.980884-3-eperezma@redhat.com> On 5/20/2022 10:23 AM, Eugenio Pérez wrote: > Userland knows if it can stop the device or not by checking this feature > bit. > > It's only offered if the vdpa driver backend implements the stop() > operation callback, and try to set it if the backend does not offer that > callback is an error. > > Signed-off-by: Eugenio Pérez <eperezma@redhat.com> > --- > drivers/vhost/vdpa.c | 13 +++++++++++++ > include/uapi/linux/vhost_types.h | 2 ++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index 1f1d1c425573..a325bc259afb 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -347,6 +347,14 @@ static long vhost_vdpa_set_config(struct vhost_vdpa *v, > return 0; > } > > +static bool vhost_vdpa_can_stop(const struct vhost_vdpa *v) > +{ > + struct vdpa_device *vdpa = v->vdpa; > + const struct vdpa_config_ops *ops = vdpa->config; > + > + return ops->stop; > +} > + > static long vhost_vdpa_get_features(struct vhost_vdpa *v, u64 __user *featurep) > { > struct vdpa_device *vdpa = v->vdpa; > @@ -577,6 +585,9 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep, > return -EFAULT; > if (features & ~VHOST_VDPA_BACKEND_FEATURES) > return -EOPNOTSUPP; > + if ((features & VHOST_BACKEND_F_STOP) && VHOST_BACKEND_F_STOP is not part of VHOST_VDPA_BACKEND_FEATURES. There's no chance for VHOST_BACKEND_F_STOP to get here. -Siwei > + !vhost_vdpa_can_stop(v)) > + return -EOPNOTSUPP; > vhost_set_backend_features(&v->vdev, features); > return 0; > } > @@ -624,6 +635,8 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep, > break; > case VHOST_GET_BACKEND_FEATURES: > features = VHOST_VDPA_BACKEND_FEATURES; > + if (vhost_vdpa_can_stop(v)) > + features |= VHOST_BACKEND_F_STOP; > if (copy_to_user(featurep, &features, sizeof(features))) > r = -EFAULT; > break; > diff --git a/include/uapi/linux/vhost_types.h b/include/uapi/linux/vhost_types.h > index 634cee485abb..2758e665791b 100644 > --- a/include/uapi/linux/vhost_types.h > +++ b/include/uapi/linux/vhost_types.h > @@ -161,5 +161,7 @@ struct vhost_vdpa_iova_range { > * message > */ > #define VHOST_BACKEND_F_IOTLB_ASID 0x3 > +/* Stop device from processing virtqueue buffers */ > +#define VHOST_BACKEND_F_STOP 0x4 > > #endif _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-05-21 10:25 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-20 17:23 [PATCH 0/4] Implement vdpasim stop operation Eugenio Pérez 2022-05-20 17:23 ` [PATCH 1/4] vdpa: Add " Eugenio Pérez 2022-05-21 10:13 ` Si-Wei Liu 2022-05-21 10:13 ` Si-Wei Liu 2022-05-23 19:20 ` Eugenio Perez Martin 2022-05-23 23:54 ` Si-Wei Liu 2022-05-23 23:54 ` Si-Wei Liu 2022-05-24 0:01 ` Si-Wei Liu 2022-05-24 0:01 ` Si-Wei Liu 2022-05-24 2:45 ` Jason Wang 2022-05-24 2:45 ` Jason Wang 2022-05-24 7:38 ` Eugenio Perez Martin 2022-05-24 7:09 ` Stefano Garzarella 2022-05-24 7:09 ` Stefano Garzarella 2022-05-24 7:42 ` Eugenio Perez Martin 2022-05-24 7:51 ` Stefano Garzarella 2022-05-24 7:51 ` Stefano Garzarella 2022-05-20 17:23 ` [PATCH 2/4] vhost-vdpa: introduce STOP backend feature bit Eugenio Pérez 2022-05-21 10:24 ` Si-Wei Liu [this message] 2022-05-21 10:24 ` Si-Wei Liu 2022-05-23 9:57 ` Eugenio Perez Martin 2022-05-20 17:23 ` [PATCH 3/4] vhost-vdpa: uAPI to stop the device Eugenio Pérez 2022-05-21 5:20 ` kernel test robot 2022-05-21 5:20 ` kernel test robot 2022-05-21 8:36 ` Martin Habets 2022-05-23 8:11 ` Eugenio Perez Martin 2022-05-20 17:23 ` [PATCH 4/4] vdpa_sim: Implement stop vdpa op Eugenio Pérez 2022-05-23 8:27 ` Stefano Garzarella 2022-05-23 8:27 ` Stefano Garzarella 2022-05-23 19:07 ` Eugenio Perez Martin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c1a31c3f-46c0-f0a2-eb43-757914d46ac3@oracle.com \ --to=si-wei.liu@oracle.com \ --cc=christophe.jaillet@wanadoo.fr \ --cc=dan.carpenter@oracle.com \ --cc=dinang@xilinx.com \ --cc=ecree.xilinx@gmail.com \ --cc=elic@nvidia.com \ --cc=eperezma@redhat.com \ --cc=gautam.dawar@amd.com \ --cc=habetsm.xilinx@gmail.com \ --cc=hanand@xilinx.com \ --cc=jasowang@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=lingshan.zhu@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=longpeng2@huawei.com \ --cc=lulu@redhat.com \ --cc=lvivier@redhat.com \ --cc=martinh@xilinx.com \ --cc=martinpo@xilinx.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=pabloc@xilinx.com \ --cc=parav@nvidia.com \ --cc=sgarzare@redhat.com \ --cc=tanuj.kamde@amd.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=wuzongyong@linux.alibaba.com \ --cc=xieyongji@bytedance.com \ --cc=zhang.min9@zte.com.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.