All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Pearson <mpearson@lenovo.com>
To: Jaroslav Kysela <perex@perex.cz>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Elimar Riesebieter <riesebie@lxtec.de>
Subject: Re: [alsa-devel] [External] Re: alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio
Date: Thu, 19 Sep 2019 15:14:06 +0000	[thread overview]
Message-ID: <c1cc53259b784e9f9bdd9ab8230ab605@lenovo.com> (raw)
In-Reply-To: <6449d5f6-959e-4384-4e80-b68171cd8091@perex.cz>

> 
> Too many commmented lines inside without any explanation. The author
> should send the patch with the signed-off-by line. Also, we are working on
> the LGPL to BSD 3-Clause licence change, so it would be nice to indicate the
> agreement with this.
> 
Thanks Jaroslav,

I originally got this file from Ubuntu where they worked with Lenovo when certifying our X1 Carbon Gen7 system with Ubuntu. I believe it originally came from Intel but I will confirm. I hadn't even considered licence issues as there isn't a licence in the file - my bad. 

I'm working my way through the steps to make sure support for our platforms gets into Debian but am new to the process. All pointers would be much appreciated - I'm assuming the two files are going to be generic to all platforms using the whiskeylake processor (and likely over Intel processors?) so the SOF and Intel team likely already have plans for this. 

I can certainly clean up the file and confirm its original providence. 

A dumb question - but what do you mean by the signed-off-by line? I looked for a guideline to submitting bugs on the alsa-project wiki and couldn't find any details. 

Thanks
Mark
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

      reply	other threads:[~2019-09-19 15:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 14:23 [alsa-devel] alsa-lib: Add ucm support for whiskeylake sof-skl_hda_card audio Elimar Riesebieter
2019-09-19 14:44 ` Pierre-Louis Bossart
     [not found]   ` <f11c5347d8504148a47fdbc48d920f59@lenovo.com>
2019-09-19 15:15     ` [alsa-devel] [External] " Pierre-Louis Bossart
2019-09-24 11:53       ` Jaroslav Kysela
2019-09-24 12:06         ` Mark Pearson
2019-09-27  8:21           ` Hui Wang
2019-09-27  9:01             ` Jaroslav Kysela
2019-09-28  3:33               ` Hui Wang
2019-10-03  2:07                 ` Hui Wang
2019-09-27 10:07         ` Jaska Uimonen
2019-09-27 10:57           ` Jaroslav Kysela
2019-09-27 14:00             ` Jaska Uimonen
2019-09-27 14:49               ` Jaroslav Kysela
2019-09-28 16:33                 ` Jaska Uimonen
2019-09-19 14:49 ` [alsa-devel] " Jaroslav Kysela
2019-09-19 15:14   ` Mark Pearson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1cc53259b784e9f9bdd9ab8230ab605@lenovo.com \
    --to=mpearson@lenovo.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=perex@perex.cz \
    --cc=riesebie@lxtec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.