From: Tariq Toukan <tariqt@mellanox.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Yishai Hadas <yishaih@mellanox.com>,
Eugenia Emantayev <eugenia@mellanox.com>
Cc: linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] net/mlx4: && vs & typo
Date: Tue, 28 Feb 2017 18:53:35 +0200 [thread overview]
Message-ID: <c20c76d1-13e9-7036-245e-765e65f40722@mellanox.com> (raw)
In-Reply-To: <20170228120215.GA27947@mwanda>
On 28/02/2017 2:02 PM, Dan Carpenter wrote:
> Bitwise & was obviously intended here.
Sure! Thanks for your patch.
>
> Fixes: 745d8ae4622c ("net/mlx4: Spoofcheck and zero MAC can't coexist")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Applies to net.git.
>
> diff --git a/include/linux/mlx4/driver.h b/include/linux/mlx4/driver.h
> index e965e5090d96..a858bcb6220b 100644
> --- a/include/linux/mlx4/driver.h
> +++ b/include/linux/mlx4/driver.h
> @@ -109,7 +109,7 @@ static inline void mlx4_u64_to_mac(u8 *addr, u64 mac)
> int i;
>
> for (i = ETH_ALEN; i > 0; i--) {
> - addr[i - 1] = mac && 0xFF;
> + addr[i - 1] = mac & 0xFF;
> mac >>= 8;
> }
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tariq Toukan <tariqt@mellanox.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Yishai Hadas <yishaih@mellanox.com>,
Eugenia Emantayev <eugenia@mellanox.com>
Cc: <linux-rdma@vger.kernel.org>, <netdev@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [patch] net/mlx4: && vs & typo
Date: Tue, 28 Feb 2017 18:53:35 +0200 [thread overview]
Message-ID: <c20c76d1-13e9-7036-245e-765e65f40722@mellanox.com> (raw)
In-Reply-To: <20170228120215.GA27947@mwanda>
On 28/02/2017 2:02 PM, Dan Carpenter wrote:
> Bitwise & was obviously intended here.
Sure! Thanks for your patch.
>
> Fixes: 745d8ae4622c ("net/mlx4: Spoofcheck and zero MAC can't coexist")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Applies to net.git.
>
> diff --git a/include/linux/mlx4/driver.h b/include/linux/mlx4/driver.h
> index e965e5090d96..a858bcb6220b 100644
> --- a/include/linux/mlx4/driver.h
> +++ b/include/linux/mlx4/driver.h
> @@ -109,7 +109,7 @@ static inline void mlx4_u64_to_mac(u8 *addr, u64 mac)
> int i;
>
> for (i = ETH_ALEN; i > 0; i--) {
> - addr[i - 1] = mac && 0xFF;
> + addr[i - 1] = mac & 0xFF;
> mac >>= 8;
> }
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tariq Toukan <tariqt@mellanox.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Yishai Hadas <yishaih@mellanox.com>,
Eugenia Emantayev <eugenia@mellanox.com>
Cc: linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] net/mlx4: && vs & typo
Date: Tue, 28 Feb 2017 16:53:35 +0000 [thread overview]
Message-ID: <c20c76d1-13e9-7036-245e-765e65f40722@mellanox.com> (raw)
In-Reply-To: <20170228120215.GA27947@mwanda>
On 28/02/2017 2:02 PM, Dan Carpenter wrote:
> Bitwise & was obviously intended here.
Sure! Thanks for your patch.
>
> Fixes: 745d8ae4622c ("net/mlx4: Spoofcheck and zero MAC can't coexist")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Applies to net.git.
>
> diff --git a/include/linux/mlx4/driver.h b/include/linux/mlx4/driver.h
> index e965e5090d96..a858bcb6220b 100644
> --- a/include/linux/mlx4/driver.h
> +++ b/include/linux/mlx4/driver.h
> @@ -109,7 +109,7 @@ static inline void mlx4_u64_to_mac(u8 *addr, u64 mac)
> int i;
>
> for (i = ETH_ALEN; i > 0; i--) {
> - addr[i - 1] = mac && 0xFF;
> + addr[i - 1] = mac & 0xFF;
> mac >>= 8;
> }
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
next prev parent reply other threads:[~2017-02-28 16:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 12:02 [patch] net/mlx4: && vs & typo Dan Carpenter
2017-02-28 12:02 ` Dan Carpenter
2017-02-28 15:35 ` Bart Van Assche
2017-02-28 15:35 ` Bart Van Assche
[not found] ` <1488296129.3056.1.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-02-28 22:23 ` Joe Perches
2017-02-28 22:23 ` Joe Perches
2017-02-28 22:45 ` Bart Van Assche
2017-02-28 22:45 ` Bart Van Assche
2017-03-01 6:52 ` Julia Lawall
2017-03-01 6:52 ` Julia Lawall
2017-03-01 8:34 ` Tariq Toukan
2017-03-01 8:34 ` Tariq Toukan
2017-02-28 16:53 ` Tariq Toukan [this message]
2017-02-28 16:53 ` Tariq Toukan
2017-02-28 16:53 ` Tariq Toukan
2017-03-01 17:52 ` David Miller
2017-03-01 17:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c20c76d1-13e9-7036-245e-765e65f40722@mellanox.com \
--to=tariqt@mellanox.com \
--cc=dan.carpenter@oracle.com \
--cc=eugenia@mellanox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.