* [PATCH] IB/hfi1: Add missing break in switch statement
@ 2019-02-21 1:02 Gustavo A. R. Silva
2019-02-21 13:47 ` Wan, Kaike
2019-02-21 21:09 ` Jason Gunthorpe
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-21 1:02 UTC (permalink / raw)
To: Kaike Wan, Mike Marciniszyn, Dennis Dalessandro, Doug Ledford,
Jason Gunthorpe
Cc: linux-rdma, linux-kernel, Gustavo A. R. Silva, Kees Cook
Fix the following warning by adding a missing break:
drivers/infiniband/hw/hfi1/tid_rdma.c: In function ‘hfi1_tid_rdma_wqe_interlock’:
drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
switch (prev->wr.opcode) {
^~~~~~
drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here
case IB_WR_RDMA_READ:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/infiniband/hw/hfi1/tid_rdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c b/drivers/infiniband/hw/hfi1/tid_rdma.c
index bc2ff83026f7..fdda33aca77f 100644
--- a/drivers/infiniband/hw/hfi1/tid_rdma.c
+++ b/drivers/infiniband/hw/hfi1/tid_rdma.c
@@ -3256,6 +3256,7 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp *qp, struct rvt_swqe *wqe)
default:
break;
}
+ break;
case IB_WR_RDMA_READ:
if (prev->wr.opcode != IB_WR_TID_RDMA_WRITE)
break;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] IB/hfi1: Add missing break in switch statement
2019-02-21 1:02 [PATCH] IB/hfi1: Add missing break in switch statement Gustavo A. R. Silva
@ 2019-02-21 13:47 ` Wan, Kaike
2019-02-21 21:09 ` Jason Gunthorpe
1 sibling, 0 replies; 4+ messages in thread
From: Wan, Kaike @ 2019-02-21 13:47 UTC (permalink / raw)
To: Gustavo A. R. Silva, Marciniszyn, Mike, Dalessandro, Dennis,
Doug Ledford, Jason Gunthorpe
Cc: linux-rdma, linux-kernel, Kees Cook
> -----Original Message-----
> From: Gustavo A. R. Silva [mailto:gustavo@embeddedor.com]
> Sent: Wednesday, February 20, 2019 8:03 PM
> To: Wan, Kaike <kaike.wan@intel.com>; Marciniszyn, Mike
> <mike.marciniszyn@intel.com>; Dalessandro, Dennis
> <dennis.dalessandro@intel.com>; Doug Ledford <dledford@redhat.com>;
> Jason Gunthorpe <jgg@ziepe.ca>
> Cc: linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R.
> Silva <gustavo@embeddedor.com>; Kees Cook <keescook@chromium.org>
> Subject: [PATCH] IB/hfi1: Add missing break in switch statement
>
> Fix the following warning by adding a missing break:
>
> drivers/infiniband/hw/hfi1/tid_rdma.c: In function
> ‘hfi1_tid_rdma_wqe_interlock’:
> drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may
> fall through [-Wimplicit-fallthrough=]
> switch (prev->wr.opcode) {
> ^~~~~~
> drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here
> case IB_WR_RDMA_READ:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
>
> Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and
> other requests")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/infiniband/hw/hfi1/tid_rdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/hfi1/tid_rdma.c
> b/drivers/infiniband/hw/hfi1/tid_rdma.c
> index bc2ff83026f7..fdda33aca77f 100644
> --- a/drivers/infiniband/hw/hfi1/tid_rdma.c
> +++ b/drivers/infiniband/hw/hfi1/tid_rdma.c
> @@ -3256,6 +3256,7 @@ bool hfi1_tid_rdma_wqe_interlock(struct rvt_qp
> *qp, struct rvt_swqe *wqe)
> default:
> break;
> }
> + break;
> case IB_WR_RDMA_READ:
> if (prev->wr.opcode != IB_WR_TID_RDMA_WRITE)
> break;
> --
Reviewed-by: Kaike Wan <Kaike.wan@intel.com>
> 2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/hfi1: Add missing break in switch statement
2019-02-21 1:02 [PATCH] IB/hfi1: Add missing break in switch statement Gustavo A. R. Silva
2019-02-21 13:47 ` Wan, Kaike
@ 2019-02-21 21:09 ` Jason Gunthorpe
2019-02-21 21:26 ` Gustavo A. R. Silva
1 sibling, 1 reply; 4+ messages in thread
From: Jason Gunthorpe @ 2019-02-21 21:09 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Kaike Wan, Mike Marciniszyn, Dennis Dalessandro, Doug Ledford,
linux-rdma, linux-kernel, Kees Cook
On Wed, Feb 20, 2019 at 07:02:33PM -0600, Gustavo A. R. Silva wrote:
> Fix the following warning by adding a missing break:
>
> drivers/infiniband/hw/hfi1/tid_rdma.c: In function ‘hfi1_tid_rdma_wqe_interlock’:
> drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
> switch (prev->wr.opcode) {
> ^~~~~~
> drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here
> case IB_WR_RDMA_READ:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Reviewed-by: Kaike Wan <Kaike.wan@intel.com>
> --
> drivers/infiniband/hw/hfi1/tid_rdma.c | 1 +
> 1 file changed, 1 insertion(+)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] IB/hfi1: Add missing break in switch statement
2019-02-21 21:09 ` Jason Gunthorpe
@ 2019-02-21 21:26 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-21 21:26 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Kaike Wan, Mike Marciniszyn, Dennis Dalessandro, Doug Ledford,
linux-rdma, linux-kernel, Kees Cook
On 2/21/19 3:09 PM, Jason Gunthorpe wrote:
> On Wed, Feb 20, 2019 at 07:02:33PM -0600, Gustavo A. R. Silva wrote:
>> Fix the following warning by adding a missing break:
>>
>> drivers/infiniband/hw/hfi1/tid_rdma.c: In function ‘hfi1_tid_rdma_wqe_interlock’:
>> drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> switch (prev->wr.opcode) {
>> ^~~~~~
>> drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here
>> case IB_WR_RDMA_READ:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> Reviewed-by: Kaike Wan <Kaike.wan@intel.com>
>> --
>> drivers/infiniband/hw/hfi1/tid_rdma.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Applied to for-next, thanks
>
Great. :)
Thank you both, Kaike and Jason.
--
Gustavo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-21 21:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-21 1:02 [PATCH] IB/hfi1: Add missing break in switch statement Gustavo A. R. Silva
2019-02-21 13:47 ` Wan, Kaike
2019-02-21 21:09 ` Jason Gunthorpe
2019-02-21 21:26 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.