All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
To: Punit Agrawal <punit.agrawal@arm.com>, kvmarm@lists.cs.columbia.edu
Cc: linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com,
	christoffer.dall@arm.com, linux-kernel@vger.kernel.org,
	will.deacon@arm.com
Subject: Re: [PATCH v6 1/8] KVM: arm/arm64: Share common code in user_mem_abort()
Date: Mon, 16 Jul 2018 13:45:05 +0100	[thread overview]
Message-ID: <c28e1aa4-c0f1-8010-6a11-005e7f1db01c@arm.com> (raw)
In-Reply-To: <20180716110857.19310-2-punit.agrawal@arm.com>

On 16/07/18 12:08, Punit Agrawal wrote:
> The code for operations such as marking the pfn as dirty, and
> dcache/icache maintenance during stage 2 fault handling is duplicated
> between normal pages and PMD hugepages.
> 
> Instead of creating another copy of the operations when we introduce
> PUD hugepages, let's share them across the different pagesizes.
> 
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Christoffer Dall <christoffer.dall@arm.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>

Thanks for splitting the patch. It looks much simpler this way.

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

WARNING: multiple messages have this Message-ID (diff)
From: Suzuki.Poulose@arm.com (Suzuki K Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 1/8] KVM: arm/arm64: Share common code in user_mem_abort()
Date: Mon, 16 Jul 2018 13:45:05 +0100	[thread overview]
Message-ID: <c28e1aa4-c0f1-8010-6a11-005e7f1db01c@arm.com> (raw)
In-Reply-To: <20180716110857.19310-2-punit.agrawal@arm.com>

On 16/07/18 12:08, Punit Agrawal wrote:
> The code for operations such as marking the pfn as dirty, and
> dcache/icache maintenance during stage 2 fault handling is duplicated
> between normal pages and PMD hugepages.
> 
> Instead of creating another copy of the operations when we introduce
> PUD hugepages, let's share them across the different pagesizes.
> 
> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
> Cc: Christoffer Dall <christoffer.dall@arm.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>

Thanks for splitting the patch. It looks much simpler this way.

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

  reply	other threads:[~2018-07-16 12:45 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16 11:08 [PATCH v6 0/8] KVM: Support PUD hugepages at stage 2 Punit Agrawal
2018-07-16 11:08 ` Punit Agrawal
2018-07-16 11:08 ` [PATCH v6 1/8] KVM: arm/arm64: Share common code in user_mem_abort() Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal
2018-07-16 12:45   ` Suzuki K Poulose [this message]
2018-07-16 12:45     ` Suzuki K Poulose
2018-07-16 13:28     ` Punit Agrawal
2018-07-16 13:28       ` Punit Agrawal
2018-07-16 11:08 ` [PATCH v6 2/8] KVM: arm/arm64: Re-factor setting the Stage 2 entry to exec on fault Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal
2018-07-16 12:46   ` Suzuki K Poulose
2018-07-16 12:46     ` Suzuki K Poulose
2018-07-16 12:46     ` Suzuki K Poulose
2018-07-16 11:08 ` [PATCH v6 3/8] KVM: arm/arm64: Introduce helpers to manipulate page table entries Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal
2018-07-16 11:08 ` [PATCH v6 4/8] KVM: arm64: Support dirty page tracking for PUD hugepages Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal
2018-07-16 11:08 ` [PATCH v6 5/8] KVM: arm64: Support PUD hugepage in stage2_is_exec() Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal
2018-07-16 11:08 ` [PATCH v6 6/8] KVM: arm64: Support handling access faults for PUD hugepages Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal
2018-07-16 12:49   ` Suzuki K Poulose
2018-07-16 12:49     ` Suzuki K Poulose
2018-07-16 11:08 ` [PATCH v6 7/8] KVM: arm64: Update age handlers to support " Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal
2018-07-16 11:08 ` [PATCH v6 8/8] KVM: arm64: Add support for creating PUD hugepages at stage 2 Punit Agrawal
2018-07-16 11:08   ` Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c28e1aa4-c0f1-8010-6a11-005e7f1db01c@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=christoffer.dall@arm.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=punit.agrawal@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.