dmaengine: ioatdma: set the completion address register after channel reset

dmaengine: ioatdma: set the completion address register after channel reset

[Dave Jiang]

On 06/11/2018 12:37 PM, Sinan Kaya wrote:
> On 6/11/2018 3:30 PM, Dave Jiang wrote:
>> +	/* set the completion address register again */
>> +	writel(((u64)ioat_chan->completion_dma) & 0x00000000FFFFFFFF,
>> +	       ioat_chan->reg_base + IOAT_CHANCMP_OFFSET_LOW);
>> +	writel(((u64)ioat_chan->completion_dma) >> 32,
>> +	       ioat_chan->reg_base + IOAT_CHANCMP_OFFSET_HIGH);
> 
> You could have used lower_32_bits() and upper_32_bits() macros here.
> 

I just copy and pasted legacy code from somewhere else in the driver. I
can update.
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

dmaengine: ioatdma: set the completion address register after channel reset

[Sinan Kaya]

On 6/11/2018 3:30 PM, Dave Jiang wrote:
> +	/* set the completion address register again */
> +	writel(((u64)ioat_chan->completion_dma) & 0x00000000FFFFFFFF,
> +	       ioat_chan->reg_base + IOAT_CHANCMP_OFFSET_LOW);
> +	writel(((u64)ioat_chan->completion_dma) >> 32,
> +	       ioat_chan->reg_base + IOAT_CHANCMP_OFFSET_HIGH);

You could have used lower_32_bits() and upper_32_bits() macros here.

dmaengine: ioatdma: set the completion address register after channel reset

[Dave Jiang]

It seems that starting with Skylake Xeon, channel reset clears the
completion address register. Make sure the completion address register is
set again after reset.

Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
 drivers/dma/ioat/dma.c |    6 ++++++
 1 file changed, 6 insertions(+)


--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
index 8b5b23a8ace9..71852751ef3c 100644
--- a/drivers/dma/ioat/dma.c
+++ b/drivers/dma/ioat/dma.c
@@ -688,6 +688,12 @@ static void ioat_restart_channel(struct ioatdma_chan *ioat_chan)
 {
 	u64 phys_complete;
 
+	/* set the completion address register again */
+	writel(((u64)ioat_chan->completion_dma) & 0x00000000FFFFFFFF,
+	       ioat_chan->reg_base + IOAT_CHANCMP_OFFSET_LOW);
+	writel(((u64)ioat_chan->completion_dma) >> 32,
+	       ioat_chan->reg_base + IOAT_CHANCMP_OFFSET_HIGH);
+
 	ioat_quiesce(ioat_chan, 0);
 	if (ioat_cleanup_preamble(ioat_chan, &phys_complete))
 		__cleanup(ioat_chan, phys_complete);