* [U-Boot] [PATCH] arm: dts: dra7: add qspi register map for control module
@ 2017-02-01 10:53 Jean-Jacques Hiblot
2017-02-03 16:52 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Jean-Jacques Hiblot @ 2017-02-01 10:53 UTC (permalink / raw)
To: u-boot
Add qspi control module register maps to device tree. This register map had
been removed by error when syncing the DTS with the latest linux at the
time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux").
Without this entry the driver do not support memory-mapped access and the
data read from the SF is invalid.
Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
---
arch/arm/dts/dra7.dtsi | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/arm/dts/dra7.dtsi b/arch/arm/dts/dra7.dtsi
index 5570e30..46febc5 100644
--- a/arch/arm/dts/dra7.dtsi
+++ b/arch/arm/dts/dra7.dtsi
@@ -1302,9 +1302,10 @@
qspi: qspi at 4b300000 {
compatible = "ti,dra7xxx-qspi";
reg = <0x4b300000 0x100>,
- <0x5c000000 0x4000000>;
- reg-names = "qspi_base", "qspi_mmap";
- syscon-chipselects = <&scm_conf 0x558>;
+ <0x5c000000 0x4000000>,
+ <0x4a002558 0x4>;
+ reg-names = "qspi_base", "qspi_mmap",
+ "qspi_ctrlmod";
#address-cells = <1>;
#size-cells = <0>;
ti,hwmods = "qspi";
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [U-Boot] [PATCH] arm: dts: dra7: add qspi register map for control module
2017-02-01 10:53 [U-Boot] [PATCH] arm: dts: dra7: add qspi register map for control module Jean-Jacques Hiblot
@ 2017-02-03 16:52 ` Tom Rini
2017-02-06 11:09 ` Jean-Jacques Hiblot
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2017-02-03 16:52 UTC (permalink / raw)
To: u-boot
On Wed, Feb 01, 2017 at 11:53:42AM +0100, Jean-Jacques Hiblot wrote:
> Add qspi control module register maps to device tree. This register map had
> been removed by error when syncing the DTS with the latest linux at the
> time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux").
> Without this entry the driver do not support memory-mapped access and the
> data read from the SF is invalid.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
Why is this not in the upstream DTS file?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170203/64420c96/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: dts: dra7: add qspi register map for control module
2017-02-03 16:52 ` Tom Rini
@ 2017-02-06 11:09 ` Jean-Jacques Hiblot
2017-02-06 12:47 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Jean-Jacques Hiblot @ 2017-02-06 11:09 UTC (permalink / raw)
To: u-boot
On 03/02/2017 17:52, Tom Rini wrote:
> On Wed, Feb 01, 2017 at 11:53:42AM +0100, Jean-Jacques Hiblot wrote:
>
>> Add qspi control module register maps to device tree. This register map had
>> been removed by error when syncing the DTS with the latest linux at the
>> time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux").
>> Without this entry the driver do not support memory-mapped access and the
>> data read from the SF is invalid.
>>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Why is this not in the upstream DTS file?
In Linux, a syscon/regmap is used to map this register while the QSPI
driver in u-boot uses a direct memory access.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: dts: dra7: add qspi register map for control module
2017-02-06 11:09 ` Jean-Jacques Hiblot
@ 2017-02-06 12:47 ` Tom Rini
2017-02-06 13:27 ` Jean-Jacques Hiblot
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2017-02-06 12:47 UTC (permalink / raw)
To: u-boot
On Mon, Feb 06, 2017 at 12:09:12PM +0100, Jean-Jacques Hiblot wrote:
>
>
> On 03/02/2017 17:52, Tom Rini wrote:
> >On Wed, Feb 01, 2017 at 11:53:42AM +0100, Jean-Jacques Hiblot wrote:
> >
> >>Add qspi control module register maps to device tree. This register map had
> >>been removed by error when syncing the DTS with the latest linux at the
> >>time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux").
> >>Without this entry the driver do not support memory-mapped access and the
> >>data read from the SF is invalid.
> >>
> >>Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> >Why is this not in the upstream DTS file?
> In Linux, a syscon/regmap is used to map this register while the
> QSPI driver in u-boot uses a direct memory access.
OK, but it's a valid part of the upstream kernel binding, yes?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170206/ba294d7a/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: dts: dra7: add qspi register map for control module
2017-02-06 12:47 ` Tom Rini
@ 2017-02-06 13:27 ` Jean-Jacques Hiblot
2017-02-06 13:37 ` Tom Rini
0 siblings, 1 reply; 7+ messages in thread
From: Jean-Jacques Hiblot @ 2017-02-06 13:27 UTC (permalink / raw)
To: u-boot
On 06/02/2017 13:47, Tom Rini wrote:
> On Mon, Feb 06, 2017 at 12:09:12PM +0100, Jean-Jacques Hiblot wrote:
>>
>> On 03/02/2017 17:52, Tom Rini wrote:
>>> On Wed, Feb 01, 2017 at 11:53:42AM +0100, Jean-Jacques Hiblot wrote:
>>>
>>>> Add qspi control module register maps to device tree. This register map had
>>>> been removed by error when syncing the DTS with the latest linux at the
>>>> time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux").
>>>> Without this entry the driver do not support memory-mapped access and the
>>>> data read from the SF is invalid.
>>>>
>>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>>> Why is this not in the upstream DTS file?
>> In Linux, a syscon/regmap is used to map this register while the
>> QSPI driver in u-boot uses a direct memory access.
> OK, but it's a valid part of the upstream kernel binding, yes?
syscon-chipselects is part of the mainlined binding. Using a 3rd memory
range used to be the way to do it, but it is not supported anymore (I
think it has been removed removed in 4.6).
Using a third memory range has been supported in u-boot for some time now.
So you think we should move to using the syscon ?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: dts: dra7: add qspi register map for control module
2017-02-06 13:27 ` Jean-Jacques Hiblot
@ 2017-02-06 13:37 ` Tom Rini
2017-02-07 14:43 ` Jean-Jacques Hiblot
0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2017-02-06 13:37 UTC (permalink / raw)
To: u-boot
On Mon, Feb 06, 2017 at 02:27:42PM +0100, Jean-Jacques Hiblot wrote:
>
>
> On 06/02/2017 13:47, Tom Rini wrote:
> >On Mon, Feb 06, 2017 at 12:09:12PM +0100, Jean-Jacques Hiblot wrote:
> >>
> >>On 03/02/2017 17:52, Tom Rini wrote:
> >>>On Wed, Feb 01, 2017 at 11:53:42AM +0100, Jean-Jacques Hiblot wrote:
> >>>
> >>>>Add qspi control module register maps to device tree. This register map had
> >>>>been removed by error when syncing the DTS with the latest linux at the
> >>>>time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux").
> >>>>Without this entry the driver do not support memory-mapped access and the
> >>>>data read from the SF is invalid.
> >>>>
> >>>>Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> >>>Why is this not in the upstream DTS file?
> >>In Linux, a syscon/regmap is used to map this register while the
> >>QSPI driver in u-boot uses a direct memory access.
> >OK, but it's a valid part of the upstream kernel binding, yes?
> syscon-chipselects is part of the mainlined binding. Using a 3rd
> memory range used to be the way to do it, but it is not supported
> anymore (I think it has been removed removed in 4.6).
> Using a third memory range has been supported in u-boot for some time now.
> So you think we should move to using the syscon ?
Based on what I see in v4.10-rc7, yes, we should adapt the driver to
know about the new property and things are working as expected wrt DT
compatibility.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170206/52230607/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm: dts: dra7: add qspi register map for control module
2017-02-06 13:37 ` Tom Rini
@ 2017-02-07 14:43 ` Jean-Jacques Hiblot
0 siblings, 0 replies; 7+ messages in thread
From: Jean-Jacques Hiblot @ 2017-02-07 14:43 UTC (permalink / raw)
To: u-boot
On 06/02/2017 14:37, Tom Rini wrote:
> On Mon, Feb 06, 2017 at 02:27:42PM +0100, Jean-Jacques Hiblot wrote:
>>
>> On 06/02/2017 13:47, Tom Rini wrote:
>>> On Mon, Feb 06, 2017 at 12:09:12PM +0100, Jean-Jacques Hiblot wrote:
>>>> On 03/02/2017 17:52, Tom Rini wrote:
>>>>> On Wed, Feb 01, 2017 at 11:53:42AM +0100, Jean-Jacques Hiblot wrote:
>>>>>
>>>>>> Add qspi control module register maps to device tree. This register map had
>>>>>> been removed by error when syncing the DTS with the latest linux at the
>>>>>> time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux").
>>>>>> Without this entry the driver do not support memory-mapped access and the
>>>>>> data read from the SF is invalid.
>>>>>>
>>>>>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>>>>> Why is this not in the upstream DTS file?
>>>> In Linux, a syscon/regmap is used to map this register while the
>>>> QSPI driver in u-boot uses a direct memory access.
>>> OK, but it's a valid part of the upstream kernel binding, yes?
>> syscon-chipselects is part of the mainlined binding. Using a 3rd
>> memory range used to be the way to do it, but it is not supported
>> anymore (I think it has been removed removed in 4.6).
>> Using a third memory range has been supported in u-boot for some time now.
>> So you think we should move to using the syscon ?
> Based on what I see in v4.10-rc7, yes, we should adapt the driver to
> know about the new property and things are working as expected wrt DT
> compatibility.
Ok. I have prepared a new series to do this
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-02-07 14:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-01 10:53 [U-Boot] [PATCH] arm: dts: dra7: add qspi register map for control module Jean-Jacques Hiblot
2017-02-03 16:52 ` Tom Rini
2017-02-06 11:09 ` Jean-Jacques Hiblot
2017-02-06 12:47 ` Tom Rini
2017-02-06 13:27 ` Jean-Jacques Hiblot
2017-02-06 13:37 ` Tom Rini
2017-02-07 14:43 ` Jean-Jacques Hiblot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.