* [PATCH v2] megaraid_sas: add an i/o barrier
@ 2016-02-01 14:12 Tomas Henzl
2016-02-01 20:41 ` Greg KH
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Tomas Henzl @ 2016-02-01 14:12 UTC (permalink / raw)
To: 'linux-scsi@vger.kernel.org'
Cc: Sumit.Saxena, Desai, Kashyap, Uday Lingala, stable
A barrier should be added to ensure proper
ordering of memory mapped writes.
V2: - added the barrier also to megasas_fire_cmd_skinny,
as suggested by Kashyap Desai
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 1 +
drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index cc92c8198d..9f7689515c 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -749,6 +749,7 @@ megasas_fire_cmd_skinny(struct megasas_instance *instance,
&(regs)->inbound_high_queue_port);
writel((lower_32_bits(frame_phys_addr) | (frame_count<<1))|1,
&(regs)->inbound_low_queue_port);
+ mmiowb();
spin_unlock_irqrestore(&instance->hba_lock, flags);
}
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index d9d0029fb1..98a848bdfd 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -204,6 +204,7 @@ megasas_fire_cmd_fusion(struct megasas_instance *instance,
&instance->reg_set->inbound_low_queue_port);
writel(le32_to_cpu(req_desc->u.high),
&instance->reg_set->inbound_high_queue_port);
+ mmiowb();
spin_unlock_irqrestore(&instance->hba_lock, flags);
#endif
}
--
2.4.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] megaraid_sas: add an i/o barrier
2016-02-01 14:12 [PATCH v2] megaraid_sas: add an i/o barrier Tomas Henzl
@ 2016-02-01 20:41 ` Greg KH
2016-02-10 17:25 ` Martin K. Petersen
2016-02-11 0:17 ` Martin K. Petersen
2 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2016-02-01 20:41 UTC (permalink / raw)
To: Tomas Henzl
Cc: 'linux-scsi@vger.kernel.org',
Sumit.Saxena, Desai, Kashyap, Uday Lingala, stable
On Mon, Feb 01, 2016 at 03:12:04PM +0100, Tomas Henzl wrote:
> A barrier should be added to ensure proper
> ordering of memory mapped writes.
>
> V2: - added the barrier also to megasas_fire_cmd_skinny,
> as suggested by Kashyap Desai
>
> Signed-off-by: Tomas Henzl <thenzl@redhat.com>
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 1 +
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 +
> 2 files changed, 2 insertions(+)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] megaraid_sas: add an i/o barrier
2016-02-01 14:12 [PATCH v2] megaraid_sas: add an i/o barrier Tomas Henzl
@ 2016-02-10 17:25 ` Martin K. Petersen
2016-02-10 17:25 ` Martin K. Petersen
2016-02-11 0:17 ` Martin K. Petersen
2 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2016-02-10 17:25 UTC (permalink / raw)
To: Tomas Henzl
Cc: 'linux-scsi@vger.kernel.org',
Sumit.Saxena, Desai, Kashyap, Uday Lingala, stable
>>>>> "Tomas" == Tomas Henzl <thenzl@redhat.com> writes:
Tomas> A barrier should be added to ensure proper ordering of memory
Tomas> mapped writes.
Tomas> V2: - added the barrier also to megasas_fire_cmd_skinny, as
Tomas> suggested by Kashyap Desai
Sumit, Kashyap: Please review this patch.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] megaraid_sas: add an i/o barrier
@ 2016-02-10 17:25 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2016-02-10 17:25 UTC (permalink / raw)
To: Tomas Henzl
Cc: 'linux-scsi@vger.kernel.org',
Sumit.Saxena, Desai, Kashyap, Uday Lingala, stable
>>>>> "Tomas" == Tomas Henzl <thenzl@redhat.com> writes:
Tomas> A barrier should be added to ensure proper ordering of memory
Tomas> mapped writes.
Tomas> V2: - added the barrier also to megasas_fire_cmd_skinny, as
Tomas> suggested by Kashyap Desai
Sumit, Kashyap: Please review this patch.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v2] megaraid_sas: add an i/o barrier
2016-02-10 17:25 ` Martin K. Petersen
(?)
@ 2016-02-10 18:56 ` Kashyap Desai
-1 siblings, 0 replies; 7+ messages in thread
From: Kashyap Desai @ 2016-02-10 18:56 UTC (permalink / raw)
To: Martin K. Petersen, Tomas Henzl
Cc: linux-scsi, Sumit.Saxena, Desai, Kashyap, Uday Lingala, stable,
kashyap.desai
> -----Original Message-----
> From: Martin K. Petersen [mailto:martin.petersen@oracle.com]
> Sent: Wednesday, February 10, 2016 10:55 PM
> To: Tomas Henzl
> Cc: 'linux-scsi@vger.kernel.org'; Sumit.Saxena@avagotech.com; Desai,
> Kashyap; Uday Lingala; stable@vger.kernel.org
> Subject: Re: [PATCH v2] megaraid_sas: add an i/o barrier
>
> >>>>> "Tomas" == Tomas Henzl <thenzl@redhat.com> writes:
>
> Tomas> A barrier should be added to ensure proper ordering of memory
> Tomas> mapped writes.
>
> Tomas> V2: - added the barrier also to megasas_fire_cmd_skinny, as
> Tomas> suggested by Kashyap Desai
Reviewed-by: Kashyap Desai <kashyap.desai@broadcom.com>
Acked-by: Kashyap Desai <kashyap.desai@broadcom.com>
>
> Sumit, Kashyap: Please review this patch.
>
> --
> Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] megaraid_sas: add an i/o barrier
2016-02-01 14:12 [PATCH v2] megaraid_sas: add an i/o barrier Tomas Henzl
@ 2016-02-11 0:17 ` Martin K. Petersen
2016-02-10 17:25 ` Martin K. Petersen
2016-02-11 0:17 ` Martin K. Petersen
2 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2016-02-11 0:17 UTC (permalink / raw)
To: Tomas Henzl
Cc: 'linux-scsi@vger.kernel.org',
Sumit.Saxena, Desai, Kashyap, Uday Lingala, stable
>>>>> "Tomas" == Tomas Henzl <thenzl@redhat.com> writes:
Tomas> A barrier should be added to ensure proper ordering of memory
Tomas> mapped writes.
Applied to 4.6/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] megaraid_sas: add an i/o barrier
@ 2016-02-11 0:17 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2016-02-11 0:17 UTC (permalink / raw)
To: Tomas Henzl
Cc: 'linux-scsi@vger.kernel.org',
Sumit.Saxena, Desai, Kashyap, Uday Lingala, stable
>>>>> "Tomas" == Tomas Henzl <thenzl@redhat.com> writes:
Tomas> A barrier should be added to ensure proper ordering of memory
Tomas> mapped writes.
Applied to 4.6/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-02-11 0:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-01 14:12 [PATCH v2] megaraid_sas: add an i/o barrier Tomas Henzl
2016-02-01 20:41 ` Greg KH
2016-02-10 17:25 ` Martin K. Petersen
2016-02-10 17:25 ` Martin K. Petersen
2016-02-10 18:56 ` Kashyap Desai
2016-02-11 0:17 ` Martin K. Petersen
2016-02-11 0:17 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.