All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>, mathias.nyman@intel.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xhci: Fix front USB ports on ASUS PRIME B350M-A
Date: Tue, 20 Feb 2018 10:24:42 +0200	[thread overview]
Message-ID: <c32af5ea-c8ca-b68b-790e-102c7a8f89f6@linux.intel.com> (raw)
In-Reply-To: <20180219190621.6632-1-kai.heng.feng@canonical.com>

Hi

On 19.02.2018 21:06, Kai-Heng Feng wrote:
> When a USB device gets plugged on ASUS PRIME B350M-A's front ports, the
> xHC stops working:
> [  549.114587] xhci_hcd 0000:02:00.0: WARN: xHC CMD_RUN timeout
> [  549.114608] suspend_common(): xhci_pci_suspend+0x0/0xc0 returns -110
> [  549.114638] xhci_hcd 0000:02:00.0: can't suspend (hcd_pci_runtime_suspend returned -110)

Is the xhci runtime suspend something that you expected here?
I mean was the plugged device first enumerated normally, driver bound, inactive and runtime suspended
first?

> 
> Delay before running xHC command CMD_RUN can workaround the issue.
> 
> Use a new quirk to make the delay only targets to the affected xHC.

Is this some known issue with this chip, or something figured out by trial and error?

> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Thanks, otherwise workaround seems fine, just curious about the two details above

-Mathias
  

WARNING: multiple messages have this Message-ID (diff)
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>, mathias.nyman@intel.com
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [v2] xhci: Fix front USB ports on ASUS PRIME B350M-A
Date: Tue, 20 Feb 2018 10:24:42 +0200	[thread overview]
Message-ID: <c32af5ea-c8ca-b68b-790e-102c7a8f89f6@linux.intel.com> (raw)

Hi

On 19.02.2018 21:06, Kai-Heng Feng wrote:
> When a USB device gets plugged on ASUS PRIME B350M-A's front ports, the
> xHC stops working:
> [  549.114587] xhci_hcd 0000:02:00.0: WARN: xHC CMD_RUN timeout
> [  549.114608] suspend_common(): xhci_pci_suspend+0x0/0xc0 returns -110
> [  549.114638] xhci_hcd 0000:02:00.0: can't suspend (hcd_pci_runtime_suspend returned -110)

Is the xhci runtime suspend something that you expected here?
I mean was the plugged device first enumerated normally, driver bound, inactive and runtime suspended
first?

> 
> Delay before running xHC command CMD_RUN can workaround the issue.
> 
> Use a new quirk to make the delay only targets to the affected xHC.

Is this some known issue with this chip, or something figured out by trial and error?

> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Thanks, otherwise workaround seems fine, just curious about the two details above

-Mathias
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-02-20  8:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19 19:06 [PATCH v2] xhci: Fix front USB ports on ASUS PRIME B350M-A Kai-Heng Feng
2018-02-19 19:06 ` [v2] " Kai-Heng Feng
2018-02-20  8:24 ` Mathias Nyman [this message]
2018-02-20  8:24   ` Mathias Nyman
2018-02-20 11:13   ` [PATCH v2] " Kai-Heng Feng
2018-02-20 11:13     ` [v2] " Kai-Heng Feng
2018-03-07  6:09     ` [PATCH v2] " Kai Heng Feng
2018-03-07  6:09       ` [v2] " Kai-Heng Feng
2018-03-08 13:14       ` [PATCH v2] " Mathias Nyman
2018-03-08 13:14         ` [v2] " Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c32af5ea-c8ca-b68b-790e-102c7a8f89f6@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.