All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: dts: renesas: Upgrade to PSCI v1.0 to support Suspend-to-RAM
@ 2017-02-17 17:00 ` Geert Uytterhoeven
  0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-02-17 17:00 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Khiem Nguyen, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven

	Hi Simon, Magnus,

This patch series upgrades the version of the PSCI firmware, as
advertised in DT on Renesas R-Car Gen3 systems, from v0.2 to v1.0.

Note that this series does not have any runtime effects: as of PSCI
v0.2, PSCI provides a VERSION API.  Hence Linux always detected the
actual version, regardless of what was stated in DT, and enabled v1.0
features like system suspend:

    PSCIv1.0 detected in firmware.

However, it is better to have the real hardware^H^H^H^H^H^H^H^Hfirmware
description in DT.

Tested on Salvator-X (both H3 and M3-W) with firmware v2.16.0, but I do
have old boot logs showing that PSCIv1.0 has been detected for a long
time.

Thanks for applying!

Khiem Nguyen (2):
  arm64: dts: r8a7795: Upgrade to PSCI v1.0 to support Suspend-to-RAM
  arm64: dts: r8a7796: Upgrade to PSCI v1.0 to support Suspend-to-RAM

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 0/2] arm64: dts: renesas: Upgrade to PSCI v1.0 to support Suspend-to-RAM
@ 2017-02-17 17:00 ` Geert Uytterhoeven
  0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-02-17 17:00 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Khiem Nguyen, linux-renesas-soc, linux-arm-kernel, devicetree,
	Geert Uytterhoeven

	Hi Simon, Magnus,

This patch series upgrades the version of the PSCI firmware, as
advertised in DT on Renesas R-Car Gen3 systems, from v0.2 to v1.0.

Note that this series does not have any runtime effects: as of PSCI
v0.2, PSCI provides a VERSION API.  Hence Linux always detected the
actual version, regardless of what was stated in DT, and enabled v1.0
features like system suspend:

    PSCIv1.0 detected in firmware.

However, it is better to have the real hardware^H^H^H^H^H^H^H^Hfirmware
description in DT.

Tested on Salvator-X (both H3 and M3-W) with firmware v2.16.0, but I do
have old boot logs showing that PSCIv1.0 has been detected for a long
time.

Thanks for applying!

Khiem Nguyen (2):
  arm64: dts: r8a7795: Upgrade to PSCI v1.0 to support Suspend-to-RAM
  arm64: dts: r8a7796: Upgrade to PSCI v1.0 to support Suspend-to-RAM

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 0/2] arm64: dts: renesas: Upgrade to PSCI v1.0 to support Suspend-to-RAM
@ 2017-02-17 17:00 ` Geert Uytterhoeven
  0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-02-17 17:00 UTC (permalink / raw)
  To: linux-arm-kernel

	Hi Simon, Magnus,

This patch series upgrades the version of the PSCI firmware, as
advertised in DT on Renesas R-Car Gen3 systems, from v0.2 to v1.0.

Note that this series does not have any runtime effects: as of PSCI
v0.2, PSCI provides a VERSION API.  Hence Linux always detected the
actual version, regardless of what was stated in DT, and enabled v1.0
features like system suspend:

    PSCIv1.0 detected in firmware.

However, it is better to have the real hardware^H^H^H^H^H^H^H^Hfirmware
description in DT.

Tested on Salvator-X (both H3 and M3-W) with firmware v2.16.0, but I do
have old boot logs showing that PSCIv1.0 has been detected for a long
time.

Thanks for applying!

Khiem Nguyen (2):
  arm64: dts: r8a7795: Upgrade to PSCI v1.0 to support Suspend-to-RAM
  arm64: dts: r8a7796: Upgrade to PSCI v1.0 to support Suspend-to-RAM

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/2] arm64: dts: r8a7795: Upgrade to PSCI v1.0 to support Suspend-to-RAM
  2017-02-17 17:00 ` Geert Uytterhoeven
@ 2017-02-17 17:00   ` Geert Uytterhoeven
  -1 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-02-17 17:00 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Khiem Nguyen, linux-renesas-soc, linux-arm-kernel, devicetree,
	Takeshi Kihara, Geert Uytterhoeven

From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>

>From PSCI v1.0, Suspend-to-RAM is supported via SYSTEM_SUSPEND PSCI
function call. Hence, upgrade PSCI version for R-Car H3 to support
Suspend-to-RAM.

The Suspend-to-RAM is highly dependent on ARM Trusted Firwmare support
since necessary callback functions will be registered after a query
to ARM Trusted Firmware about SYSTEM_SUSPEND support.

Since PSCI v1.0 is backward compatible with PSCI v0.2, CPU Hotplug and
CPUIdle should be able to work normally with this change.

Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Khiem: I've updated your email address.
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 98cd42f586b5fd62..4eae2d471d41ee55 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -29,7 +29,7 @@
 	};
 
 	psci {
-		compatible = "arm,psci-0.2";
+		compatible = "arm,psci-1.0";
 		method = "smc";
 	};
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 1/2] arm64: dts: r8a7795: Upgrade to PSCI v1.0 to support Suspend-to-RAM
@ 2017-02-17 17:00   ` Geert Uytterhoeven
  0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-02-17 17:00 UTC (permalink / raw)
  To: linux-arm-kernel

From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>

>From PSCI v1.0, Suspend-to-RAM is supported via SYSTEM_SUSPEND PSCI
function call. Hence, upgrade PSCI version for R-Car H3 to support
Suspend-to-RAM.

The Suspend-to-RAM is highly dependent on ARM Trusted Firwmare support
since necessary callback functions will be registered after a query
to ARM Trusted Firmware about SYSTEM_SUSPEND support.

Since PSCI v1.0 is backward compatible with PSCI v0.2, CPU Hotplug and
CPUIdle should be able to work normally with this change.

Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Khiem: I've updated your email address.
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 98cd42f586b5fd62..4eae2d471d41ee55 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -29,7 +29,7 @@
 	};
 
 	psci {
-		compatible = "arm,psci-0.2";
+		compatible = "arm,psci-1.0";
 		method = "smc";
 	};
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] arm64: dts: r8a7796: Upgrade to PSCI v1.0 to support Suspend-to-RAM
  2017-02-17 17:00 ` Geert Uytterhoeven
@ 2017-02-17 17:00   ` Geert Uytterhoeven
  -1 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-02-17 17:00 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Khiem Nguyen, linux-renesas-soc, linux-arm-kernel, devicetree,
	Takeshi Kihara, Geert Uytterhoeven

From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>

>From PSCI v1.0, Suspend-to-RAM is supported via SYSTEM_SUSPEND PSCI
function call. Hence, upgrade PSCI version for R-Car M3 to support
Suspend-to-RAM.

The Suspend-to-RAM is highly dependent on ARM Trusted Firwmare support
since necessary callback functions will be registered after a query
to ARM Trusted Firmware about SYSTEM_SUSPEND support.

Since PSCI v1.0 is backward compatible with PSCI v0.2, CPU Hotplug and
CPUIdle should be able to work normally with this change.

Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Khiem: I've updated your email address.
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 0cd83974e42154c0..0cfcc15e9177159a 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -29,7 +29,7 @@
 	};
 
 	psci {
-		compatible = "arm,psci-0.2";
+		compatible = "arm,psci-1.0";
 		method = "smc";
 	};
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] arm64: dts: r8a7796: Upgrade to PSCI v1.0 to support Suspend-to-RAM
@ 2017-02-17 17:00   ` Geert Uytterhoeven
  0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-02-17 17:00 UTC (permalink / raw)
  To: linux-arm-kernel

From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>

>From PSCI v1.0, Suspend-to-RAM is supported via SYSTEM_SUSPEND PSCI
function call. Hence, upgrade PSCI version for R-Car M3 to support
Suspend-to-RAM.

The Suspend-to-RAM is highly dependent on ARM Trusted Firwmare support
since necessary callback functions will be registered after a query
to ARM Trusted Firmware about SYSTEM_SUSPEND support.

Since PSCI v1.0 is backward compatible with PSCI v0.2, CPU Hotplug and
CPUIdle should be able to work normally with this change.

Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Khiem: I've updated your email address.
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 0cd83974e42154c0..0cfcc15e9177159a 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -29,7 +29,7 @@
 	};
 
 	psci {
-		compatible = "arm,psci-0.2";
+		compatible = "arm,psci-1.0";
 		method = "smc";
 	};
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] arm64: dts: r8a7795: Upgrade to PSCI v1.0 to support Suspend-to-RAM
  2017-02-17 17:00   ` Geert Uytterhoeven
@ 2017-02-17 18:06     ` Sudeep Holla
  -1 siblings, 0 replies; 9+ messages in thread
From: Sudeep Holla @ 2017-02-17 18:06 UTC (permalink / raw)
  To: Geert Uytterhoeven, Simon Horman, Magnus Damm
  Cc: Sudeep Holla, Khiem Nguyen, linux-renesas-soc, linux-arm-kernel,
	devicetree, Takeshi Kihara



On 17/02/17 17:00, Geert Uytterhoeven wrote:
> From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
> 
> From PSCI v1.0, Suspend-to-RAM is supported via SYSTEM_SUSPEND PSCI
> function call. Hence, upgrade PSCI version for R-Car H3 to support
> Suspend-to-RAM.
> 
> The Suspend-to-RAM is highly dependent on ARM Trusted Firwmare support
> since necessary callback functions will be registered after a query
> to ARM Trusted Firmware about SYSTEM_SUSPEND support.
> 
> Since PSCI v1.0 is backward compatible with PSCI v0.2, CPU Hotplug and
> CPUIdle should be able to work normally with this change.
> 

Why not retain "arm,psci-0.2" and just add "arm,psci-1.0" so that you
can continue to run older kernel without PSCI v1.0 or system suspend
support in case you need to backward compatible with older/stable kernel
versions.

> Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Khiem: I've updated your email address.
> ---
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index 98cd42f586b5fd62..4eae2d471d41ee55 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -29,7 +29,7 @@
>  	};
>  
>  	psci {
> -		compatible = "arm,psci-0.2";
> +		compatible = "arm,psci-1.0";
>  		method = "smc";
>  	};
>  
> 

-- 
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/2] arm64: dts: r8a7795: Upgrade to PSCI v1.0 to support Suspend-to-RAM
@ 2017-02-17 18:06     ` Sudeep Holla
  0 siblings, 0 replies; 9+ messages in thread
From: Sudeep Holla @ 2017-02-17 18:06 UTC (permalink / raw)
  To: linux-arm-kernel



On 17/02/17 17:00, Geert Uytterhoeven wrote:
> From: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
> 
> From PSCI v1.0, Suspend-to-RAM is supported via SYSTEM_SUSPEND PSCI
> function call. Hence, upgrade PSCI version for R-Car H3 to support
> Suspend-to-RAM.
> 
> The Suspend-to-RAM is highly dependent on ARM Trusted Firwmare support
> since necessary callback functions will be registered after a query
> to ARM Trusted Firmware about SYSTEM_SUSPEND support.
> 
> Since PSCI v1.0 is backward compatible with PSCI v0.2, CPU Hotplug and
> CPUIdle should be able to work normally with this change.
> 

Why not retain "arm,psci-0.2" and just add "arm,psci-1.0" so that you
can continue to run older kernel without PSCI v1.0 or system suspend
support in case you need to backward compatible with older/stable kernel
versions.

> Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Khiem: I've updated your email address.
> ---
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index 98cd42f586b5fd62..4eae2d471d41ee55 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -29,7 +29,7 @@
>  	};
>  
>  	psci {
> -		compatible = "arm,psci-0.2";
> +		compatible = "arm,psci-1.0";
>  		method = "smc";
>  	};
>  
> 

-- 
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-02-17 18:06 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-17 17:00 [PATCH 0/2] arm64: dts: renesas: Upgrade to PSCI v1.0 to support Suspend-to-RAM Geert Uytterhoeven
2017-02-17 17:00 ` Geert Uytterhoeven
2017-02-17 17:00 ` Geert Uytterhoeven
2017-02-17 17:00 ` [PATCH 1/2] arm64: dts: r8a7795: " Geert Uytterhoeven
2017-02-17 17:00   ` Geert Uytterhoeven
2017-02-17 18:06   ` Sudeep Holla
2017-02-17 18:06     ` Sudeep Holla
2017-02-17 17:00 ` [PATCH 2/2] arm64: dts: r8a7796: " Geert Uytterhoeven
2017-02-17 17:00   ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.