* [PATCH] x86: fix build race when generating temporary object files (take 2)
@ 2021-04-26 9:54 Jan Beulich
2021-05-07 8:28 ` Ping: " Jan Beulich
2021-05-25 11:13 ` Ping²: " Jan Beulich
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2021-04-26 9:54 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Wei Liu, Roger Pau Monné
The original commit wasn't quite sufficient: Emptying DEPS is helpful
only when nothing will get added to it subsequently. xen/Rules.mk will,
after including the local Makefile, amend DEPS by dependencies for
objects living in sub-directories though. For the purpose of suppressing
dependencies of the makefiles on the .*.d2 files (and thus to avoid
their re-generation) it is, however, not necessary at all to play with
DEPS. Instead we can override DEPS_INCLUDE (which generally is a late-
expansion variable).
Fixes: 761bb575ce97 ("x86: fix build race when generating temporary object files")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/Makefile
+++ b/xen/arch/x86/Makefile
@@ -314,5 +314,5 @@ clean::
# Suppress loading of DEPS files for internal, temporary target files. This
# then also suppresses re-generation of the respective .*.d2 files.
ifeq ($(filter-out .xen%.o,$(notdir $(MAKECMDGOALS))),)
-DEPS:=
+DEPS_INCLUDE:=
endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Ping: [PATCH] x86: fix build race when generating temporary object files (take 2)
2021-04-26 9:54 [PATCH] x86: fix build race when generating temporary object files (take 2) Jan Beulich
@ 2021-05-07 8:28 ` Jan Beulich
2021-05-25 11:13 ` Ping²: " Jan Beulich
1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2021-05-07 8:28 UTC (permalink / raw)
To: Andrew Cooper, Roger Pau Monné, Wei Liu, Ian Jackson; +Cc: xen-devel
On 26.04.2021 11:54, Jan Beulich wrote:
> The original commit wasn't quite sufficient: Emptying DEPS is helpful
> only when nothing will get added to it subsequently. xen/Rules.mk will,
> after including the local Makefile, amend DEPS by dependencies for
> objects living in sub-directories though. For the purpose of suppressing
> dependencies of the makefiles on the .*.d2 files (and thus to avoid
> their re-generation) it is, however, not necessary at all to play with
> DEPS. Instead we can override DEPS_INCLUDE (which generally is a late-
> expansion variable).
>
> Fixes: 761bb575ce97 ("x86: fix build race when generating temporary object files")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Ping?
Ian, I'm also including you here because iirc the .*.d2 thing was an
invention of yours, so you may have an opinion.
Jan
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -314,5 +314,5 @@ clean::
> # Suppress loading of DEPS files for internal, temporary target files. This
> # then also suppresses re-generation of the respective .*.d2 files.
> ifeq ($(filter-out .xen%.o,$(notdir $(MAKECMDGOALS))),)
> -DEPS:=
> +DEPS_INCLUDE:=
> endif
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Ping²: [PATCH] x86: fix build race when generating temporary object files (take 2)
2021-04-26 9:54 [PATCH] x86: fix build race when generating temporary object files (take 2) Jan Beulich
2021-05-07 8:28 ` Ping: " Jan Beulich
@ 2021-05-25 11:13 ` Jan Beulich
1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2021-05-25 11:13 UTC (permalink / raw)
To: Andrew Cooper, Roger Pau Monné, Wei Liu, Ian Jackson; +Cc: xen-devel
On 26.04.2021 11:54, Jan Beulich wrote:
> The original commit wasn't quite sufficient: Emptying DEPS is helpful
> only when nothing will get added to it subsequently. xen/Rules.mk will,
> after including the local Makefile, amend DEPS by dependencies for
> objects living in sub-directories though. For the purpose of suppressing
> dependencies of the makefiles on the .*.d2 files (and thus to avoid
> their re-generation) it is, however, not necessary at all to play with
> DEPS. Instead we can override DEPS_INCLUDE (which generally is a late-
> expansion variable).
>
> Fixes: 761bb575ce97 ("x86: fix build race when generating temporary object files")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Ping (again)? I'll give it till Wednesday, and if I don't hear back,
I'll commit without any acks.
Ian, I'm also including you here because iirc the .*.d2 thing was an
invention of yours, so you may have an opinion.
Jan
> --- a/xen/arch/x86/Makefile
> +++ b/xen/arch/x86/Makefile
> @@ -314,5 +314,5 @@ clean::
> # Suppress loading of DEPS files for internal, temporary target files. This
> # then also suppresses re-generation of the respective .*.d2 files.
> ifeq ($(filter-out .xen%.o,$(notdir $(MAKECMDGOALS))),)
> -DEPS:=
> +DEPS_INCLUDE:=
> endif
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-25 11:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-26 9:54 [PATCH] x86: fix build race when generating temporary object files (take 2) Jan Beulich
2021-05-07 8:28 ` Ping: " Jan Beulich
2021-05-25 11:13 ` Ping²: " Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.